Fuzzysearch #22
Merged
Fuzzysearch #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipanda
force-pushed
the
fuzzysearch
branch
2 times, most recently
from
bf03a0a to
d2da701
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
philipanda
force-pushed
the
fuzzysearch
branch
2 times, most recently
from
b18aa3d to
88644b8
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
macpijan
reviewed
Aug 5, 2025
macpijan
approved these changes
Aug 5, 2025
Signed-off-by: Filip Gołaś <[email protected]>
philipanda
force-pushed
the
fuzzysearch
branch
2 times, most recently
from
408679e to
9c42c5d
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
…thods Signed-off-by: Filip Gołaś <[email protected]>
…ethods Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
philipanda
force-pushed
the
fuzzysearch
branch
from
bee29f3 to
c1d1993
Compare
Signed-off-by: Filip Gołaś <[email protected]>
Signed-off-by: Filip Gołaś <[email protected]>
Member
|
@philipanda do we know why CI fails with Maybe the added library is not listed/included somewhere? |
Signed-off-by: Filip Gołaś <[email protected]>
Author
Yup, looks like unit tests and acceptance tests use separate |
Author
|
@filipleple looks like the problems with keeping all the python requirements in check is not unique to OSFV. |
setting max_errors, max_insertions and max_deletions, but not max_substitutions allowed for an edge case to trigger where the fuzzysearch library was crashing. Changing the interface like that should prevent unhandled situations Signed-off-by: Filip Gołaś <[email protected]>
philipanda
force-pushed
the
fuzzysearch
branch
from
0627abb to
4725e9c
Compare
wiktormowinski
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.