Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

undo / redo for position/rotation/scale only as v1 #590

Closed
kfarr opened this issue Apr 2, 2024 · 2 comments · Fixed by #676
Closed

undo / redo for position/rotation/scale only as v1 #590

kfarr opened this issue Apr 2, 2024 · 2 comments · Fixed by #676
Assignees
@vincentfretin

Comments

@kfarr
Copy link
Collaborator

kfarr commented Apr 2, 2024 •
edited
Loading

As a user I wish to undo past actions and redo those once undone. It's ok to have a limit of undo actions such as 20 deep.

It's also ok to start with just 1 action, such as position/rotation/scale
@vincentfretin
Copy link
Collaborator

I have some notes about how to implement an undo feature with the Command Design Pattern in c-frame/aframe-editor#2

@kfarr kfarr transferred this issue from 3DStreet/3dstreet-editor Jun 10, 2024
@kfarr kfarr moved this from To Do - Soon to To Do - High Prio in 3DStreet Dev Tracking Jun 10, 2024
@kfarr kfarr changed the title feat: undo / redo undo / redo for position/rotation/scale only as v1 Jun 11, 2024
@vincentfretin vincentfretin moved this from To Do - High Prio to In progress in 3DStreet Dev Tracking Jun 25, 2024
@vincentfretin vincentfretin mentioned this issue Jun 27, 2024
Merged
4 tasks
@vincentfretin
Copy link
Collaborator

PR #676

@vincentfretin vincentfretin moved this from In progress to For Review in 3DStreet Dev Tracking Jun 28, 2024
@github-project-automation github-project-automation bot moved this from For Review to Done in 3DStreet Dev Tracking Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincentfretin vincentfretin

Labels
None yet
Projects
3DStreet Dev Tracking
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Undo/redo position/rotation/scale 3DStreet/3dstreet
2 participants
@vincentfretin @kfarr