Repackaged .cia failing to run on Citra & Real Hardware

[vulcandth]

Background: As you may or may not be aware; I am creating an extension for the Pokemon Generation I / II disassemblies. Many people making rom hacks for the game utilize these diassemblies to make their own romhacks. Recently I helped them implement a method to generate .patch files that are used by the Nintendo 3DS Virtual Console to know what addresses it needs to look for to enable wireless link capabilities, as well as what addresses it needs to patch. My extension is designed to extract an original dumped .cia of the Pokemon Virtual Console versions (Red, Blue, Yellow, Gold, Silver, Crystal)... Replace the rom and .patch file in the extracted contents... and then repackage the .cia all in one command.

The Problem: .cia files extracted using ctrtool greater than 0.7 appears to repackage successfully... but crashes both Citra and the Actual 3DS. Changing the version of makerom has no effect.

Log output was generated using the following versions:
CTRTool v1.0.2 (C) jakcron
CTR MAKEROM v0.18 (C) 3DSGuy 2021
Windows Subsystem for Linux: Ubuntu 20.04 LTS

Pull Request used during this test: vulcandth/poke-cia#1

Command only console output during Build: supressedlog.txt

Standard console output Build: standardoutput.txt

ctrtool -v (Verbose) output Build: verboseoutput.txt

Citra Log: citra_log.txt.old.txt

If you could point me in the right direction of what I might be doing wrong; or see if there is a bug that needs to be addressed. If you require any further information from me, i'd be happy to provide it. I greatly appreciate your assistance in this matter.

[jakcron]

Looking at the pull-request, the issue was introduced by updating CTRTool. So I did a test extracting pokemon yellow with CTRTool v0.7 and v1.0.2.

And the only thing that was different after being extracted was the exefs/code.bin.

This turned out to be a bug preventing it from being decompressed.

I'm working on a fix...

[jakcron]

I've released CTRTool v1.0.3, which fixed the exefs:/.code decompress bug. You can get it here https://github.com/3DSGuy/Project_CTR/releases/tag/ctrtool-v1.0.3

Please let me know if this fixes the issue.

[vulcandth]

Perfect; after testing with CTRTool v1.0.3 it fixed my issue. Thank you so much for taking your time to go to extra mile and even download not only one, but two other repositories, just to troubleshoot my issue! :)