Remove rusqlite dependency
#489
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked/experimented with BDK, particularly the `bdk_chain`, and I think [this method](https://docs.rs/bdk_chain/latest/bdk_chain/struct.CheckPoint.html#method.insert) is sufficient to remove the store entirely instead of deprecating it. Since every block header is now emitted, the `bdk_kyoto` integration can make use of this to avoid starting on an orphan block. Reorganizations don't need to be explicitly emitted. Rather, the node can just emit whatever chain it is on and `CheckPoint::insert` will reconsile the changes. It looks like there will also be nice [user facing events](bitcoindevkit/bdk_wallet#310), so explicitly informing about a re-org might even be returned in the wallet update. This Kyoto now acts as a decision-maker for the the chain of most work, but there is now a single source-of-truth for the history of headers.
rustaceanrob
force-pushed
the
9-17-rm
branch
from
7ff7445 to
56d0097
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked/experimented with BDK, particularly the
bdk_chain, and I think thismethod is sufficient to remove the store entirely instead of deprecating it. Since every block header is now emitted, the
bdk_kyotointegration can make use of this to avoid starting on an orphan block. Reorganizations don't need to be explicitly emitted. Rather, the node can just emit whatever chain it is on andCheckPoint::insertwill reconsile the changes.It looks like there will also be nice user facing events, so explicitly informing about a re-org might even be returned in the wallet update.
This Kyoto now acts as a decision-maker for the the chain of most work, but there is now a single source-of-truth for the history of headers.