Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and cleanup manage script #2

Open
genaris opened this issue Jul 9, 2024 · 0 comments
Open

Update and cleanup manage script #2

genaris opened this issue Jul 9, 2024 · 0 comments

Comments

@genaris
Copy link
Contributor

genaris commented Jul 9, 2024

manage script is populated with lots of variables that are either not used or convenient for our implementation. For example:

  export ST_ACAPY_ADMIN_API_KEY_NAME="x-api-key"
 export AGENT_ADMIN_API_KEY=${AGENT_ADMIN_API_KEY}
  export AGENT_ADMIN_MODE="admin-insecure-mode"
  if [ ! -z "${AGENT_ADMIN_API_KEY}" ]; then
    AGENT_ADMIN_MODE="admin-api-key ${AGENT_ADMIN_API_KEY}"
  fi
  export MT_ACAPY_WALLET_ID=${MT_ACAPY_WALLET_ID}
  export MT_ACAPY_WALLET_KEY=${MT_ACAPY_WALLET_KEY}

Are not used. And the default values for these should be the opposite.

  export USE_OOB_PRESENT_PROOF=${USE_OOB_PRESENT_PROOF:-"false"}
  export USE_OOB_LOCAL_DID_SERVICE=${USE_OOB_LOCAL_DID_SERVICE:-"true"}

It is also a bit outdated after last merge with original vc-authn project, so some variables might be missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@genaris