Invert return value of noLogRepeatEnabledP

Author: jamesnvc

src/components/OrgFile/OrgFile.unit.test.js

@@ -121,25 +121,25 @@ describe('Unit Tests for Org file', () => {
       test('Detects "nologrepeat" when set in #+STARTUP as only option', () => {
         const testOrgFile = readFixture('schedule_with_repeater_and_nologrepeat');
         const state = parseOrg(testOrgFile);
-        expect(noLogRepeatEnabledP({ state, headerIndex: 0 })).toBe(false);
+        expect(noLogRepeatEnabledP({ state, headerIndex: 0 })).toBe(true);
       });
       test('Detects "nologrepeat" when set in #+STARTUP with other options', () => {
         const testOrgFile = readFixture('schedule_with_repeater_and_nologrepeat_and_other_options');
         const state = parseOrg(testOrgFile);
-        expect(noLogRepeatEnabledP({ state, headerIndex: 0 })).toBe(false);
+        expect(noLogRepeatEnabledP({ state, headerIndex: 0 })).toBe(true);
       });
       test('Does not detect "nologrepeat" when not set', () => {
         const testOrgFile = readFixture('schedule_with_repeater');
         const state = parseOrg(testOrgFile);
-        expect(noLogRepeatEnabledP({ state, headerIndex: 0 })).toBe(true);
+        expect(noLogRepeatEnabledP({ state, headerIndex: 0 })).toBe(false);
       });
       test('Detects "nologrepeat" when set via a property list', () => {
         const testOrgFile = readFixture('schedule_with_repeater_and_nologrepeat_property');
         const state = parseOrg(testOrgFile);
-        expect(noLogRepeatEnabledP({ state, headerIndex: 1 })).toBe(false);
-        expect(noLogRepeatEnabledP({ state, headerIndex: 2 })).toBe(false);
-        expect(noLogRepeatEnabledP({ state, headerIndex: 5 })).toBe(true);
-        expect(noLogRepeatEnabledP({ state, headerIndex: 7 })).toBe(false);
+        expect(noLogRepeatEnabledP({ state, headerIndex: 1 })).toBe(true);
+        expect(noLogRepeatEnabledP({ state, headerIndex: 2 })).toBe(true);
+        expect(noLogRepeatEnabledP({ state, headerIndex: 5 })).toBe(false);
+        expect(noLogRepeatEnabledP({ state, headerIndex: 7 })).toBe(true);
       });
     });
   });

src/reducers/org.js

@@ -1043,7 +1043,7 @@ function updatePlanningItemsWithRepeaters(
     ['headers', headerIndex, 'titleLine', 'todoKeyword'],
     currentTodoSet.get('keywords').first()
   );
-  if (noLogRepeatEnabledP({ state, headerIndex })) {
+  if (!noLogRepeatEnabledP({ state, headerIndex })) {
     const lastRepeatTimestamp = getCurrentTimestamp({ isActive: false, withStartTime: true });
     const newLastRepeatValue = [
       {
@@ -1096,14 +1096,12 @@ export function noLogRepeatEnabledP({ state, headerIndex }) {
     .get('fileConfigLines')
     .some(elt => elt.match(/^#\+STARTUP:.*nologrepeat.*/));
   const loggingProp = inheritedValueOfProperty(state.get('headers'), headerIndex, 'LOGGING');
-  return (
-    !startupOptNoLogRepeat &&
-    !(
-      loggingProp &&
+  return !!(
+    startupOptNoLogRepeat ||
+    (loggingProp &&
       loggingProp.some(
         v => v.get('type') === 'text' && v.get('contents').match(/\s*nologrepeat\s*/)
-      )
-    )
+      ))
   );
 }