Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better thumbnail flow #513

Open
jawndiego opened this issue Feb 26, 2024 · 2 comments
Open

better thumbnail flow #513

jawndiego opened this issue Feb 26, 2024 · 2 comments

Comments

@jawndiego
Copy link
Contributor

from @0xTranqui in PR #512

"i wonder if instead of the "thumbnail types to render" you could just have some url helper depending on if content is video or if content is image

like the video renderer Image thumbnail has src of getVidThumbnail(x) or something like that"

@ioeylim
Copy link
Contributor

ioeylim commented Feb 26, 2024

Chiming in here after seeing #514

Noticing that the thumbnail takes at least a few minutes to appear on the item card, which makes me wonder ... unless the better thumbnail flow enhances the speed similar to grabbing thumbnails of image files, maybe we can show the fallback card until it processes?

Curious how are you thinking @jawndiego

@0xTranqui
Copy link
Contributor

i thin think answer for that is, in the item card code:

  • if content type = video
  • ping mux ehdpoint for processing status
  • if processed, show thumbnail
  • if not processed, show default grey state?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants