Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsNumberString returns false for none integers #10

Closed
AmirSasson opened this issue Mar 28, 2018 · 2 comments
Closed

IsNumberString returns false for none integers #10

AmirSasson opened this issue Mar 28, 2018 · 2 comments
Labels
out of scope

Comments

@AmirSasson
Copy link

such as "-0.8" a valid numeric string, i get an error.
seems like the regex used to validate that missing a dot
@MichalLytek
Copy link
Owner

MichalLytek commented Mar 28, 2018 •
edited
Loading

This is the regex:
https://github.com/chriso/validator.js/blob/master/src/lib/isNumeric.js

If you think it's buggy, create an issue or PR on validator.js repository.

@AmirSasson AmirSasson mentioned this issue Apr 1, 2018
Merged
@AmirSasson
Copy link
Author

submitted a PR to validator JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
out of scope
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MichalLytek @AmirSasson