diff --git a/lib/saml_idp/metadata_builder.rb b/lib/saml_idp/metadata_builder.rb index 0ce0d98a..c9f6a8fc 100644 --- a/lib/saml_idp/metadata_builder.rb +++ b/lib/saml_idp/metadata_builder.rb @@ -33,10 +33,6 @@ def fresh entity.IDPSSODescriptor protocolSupportEnumeration: protocol_enumeration do |descriptor| build_key_descriptor descriptor build_name_id_formats descriptor - descriptor.SingleLogoutService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST", - Location: single_logout_service_post_location - descriptor.SingleLogoutService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect", - Location: single_logout_service_post_location descriptor.SingleSignOnService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST", Location: single_service_post_location descriptor.SingleSignOnService Binding: "urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect", diff --git a/spec/lib/saml_idp/metadata_builder_spec.rb b/spec/lib/saml_idp/metadata_builder_spec.rb index 3255b0b8..69c65d6a 100644 --- a/spec/lib/saml_idp/metadata_builder_spec.rb +++ b/spec/lib/saml_idp/metadata_builder_spec.rb @@ -2,7 +2,7 @@ module SamlIdp describe MetadataBuilder do include CloudhsmMockable - + it "has a valid fresh" do expect(subject.fresh).not_to be_empty end @@ -33,9 +33,7 @@ module SamlIdp it "includes logout element" do subject.configurator.single_logout_service_post_location = 'https://example.com/saml/logout' - expect(subject.fresh).to match( - '' - ) + expect(subject.fresh).not_to include('SingleLogoutService') end end end diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb index 0e1b089d..b3ef0b38 100644 --- a/spec/spec_helper.rb +++ b/spec/spec_helper.rb @@ -13,7 +13,6 @@ require 'rspec' require 'capybara/rspec' require 'capybara/rails' -require 'pry-byebug' require 'ruby-saml' require 'saml_idp'