diff --git a/app/controllers/idv/cancellations_controller.rb b/app/controllers/idv/cancellations_controller.rb index c70401590b4..1f48f3ce8e1 100644 --- a/app/controllers/idv/cancellations_controller.rb +++ b/app/controllers/idv/cancellations_controller.rb @@ -67,7 +67,6 @@ def cancel_session idv_session = user_session[:idv] idv_session&.clear user_session['idv/in_person'] = {} - reset_doc_auth end end @@ -83,11 +82,6 @@ def location_params params.permit(:step, :location).to_h.symbolize_keys end - def reset_doc_auth - user_session.delete('idv/doc_auth') - user_session['idv'] = {} - end - def cancel_document_capture_session document_capture_session&.update(cancelled_at: Time.zone.now) end diff --git a/app/controllers/idv/sessions_controller.rb b/app/controllers/idv/sessions_controller.rb index bdd5293c374..f967e623100 100644 --- a/app/controllers/idv/sessions_controller.rb +++ b/app/controllers/idv/sessions_controller.rb @@ -55,7 +55,6 @@ def cancel_in_person_enrollment_if_exists end def clear_session - user_session['idv/doc_auth'] = {} user_session['idv/in_person'] = {} idv_session.clear Pii::Cacher.new(current_user, user_session).delete diff --git a/lib/session_encryptor.rb b/lib/session_encryptor.rb index 22c9ff3f488..77b94875441 100644 --- a/lib/session_encryptor.rb +++ b/lib/session_encryptor.rb @@ -19,11 +19,10 @@ class SensitiveValueError < StandardError; end COMPRESSED_KEY = 'c' VERSION_KEY = 'v' - # 'idv/doc_auth' and 'idv' are used during the proofing process and can contain PII + # 'idv/in_person' and 'idv' are used during the proofing process and can contain PII # personal keys are generated and stored in the session between requests, but are used # to decrypt PII bundles, so we treat them similarly to the PII itself. SENSITIVE_PATHS = [ - ['warden.user.user.session', 'idv/doc_auth'], ['warden.user.user.session', 'idv/in_person'], ['warden.user.user.session', 'idv'], ['warden.user.user.session', 'personal_key'], diff --git a/spec/controllers/idv/agreement_controller_spec.rb b/spec/controllers/idv/agreement_controller_spec.rb index 788ea74716a..5411112667d 100644 --- a/spec/controllers/idv/agreement_controller_spec.rb +++ b/spec/controllers/idv/agreement_controller_spec.rb @@ -12,7 +12,6 @@ before do stub_sign_in(user) stub_analytics - subject.user_session['idv/doc_auth'] = {} subject.idv_session.welcome_visited = true allow(subject).to receive(:ab_test_analytics_buckets).and_return(ab_test_args) end diff --git a/spec/controllers/idv/cancellations_controller_spec.rb b/spec/controllers/idv/cancellations_controller_spec.rb index c0c316700a1..939a2fc136d 100644 --- a/spec/controllers/idv/cancellations_controller_spec.rb +++ b/spec/controllers/idv/cancellations_controller_spec.rb @@ -207,12 +207,6 @@ stub_sign_in(user) end - it 'destroys session' do - expect(subject.user_session).to receive(:delete).with('idv/doc_auth') - - delete :destroy - end - it 'renders template' do delete :destroy diff --git a/spec/controllers/idv/getting_started_controller_spec.rb b/spec/controllers/idv/getting_started_controller_spec.rb index d47e4204838..fee61da3edb 100644 --- a/spec/controllers/idv/getting_started_controller_spec.rb +++ b/spec/controllers/idv/getting_started_controller_spec.rb @@ -12,7 +12,6 @@ before do stub_sign_in(user) stub_analytics - subject.user_session['idv/doc_auth'] = {} allow(subject).to receive(:ab_test_analytics_buckets).and_return(ab_test_args) end diff --git a/spec/controllers/idv/hybrid_handoff_controller_spec.rb b/spec/controllers/idv/hybrid_handoff_controller_spec.rb index 59f63c2fd25..673aac94439 100644 --- a/spec/controllers/idv/hybrid_handoff_controller_spec.rb +++ b/spec/controllers/idv/hybrid_handoff_controller_spec.rb @@ -13,7 +13,6 @@ stub_sign_in(user) stub_analytics stub_attempts_tracker - subject.user_session['idv/doc_auth'] = {} subject.idv_session.idv_consent_given = true allow(subject).to receive(:ab_test_analytics_buckets).and_return(ab_test_args) end diff --git a/spec/controllers/idv/sessions_controller_spec.rb b/spec/controllers/idv/sessions_controller_spec.rb index b72c8e45de8..dac915c0873 100644 --- a/spec/controllers/idv/sessions_controller_spec.rb +++ b/spec/controllers/idv/sessions_controller_spec.rb @@ -13,7 +13,6 @@ before do allow(idv_session).to receive(:clear) allow(subject).to receive(:idv_session).and_return(idv_session) - controller.user_session['idv/doc_auth'] = flow_session controller.user_session['idv/in_person'] = flow_session controller.user_session[:decrypted_pii] = pii end @@ -29,10 +28,6 @@ delete :destroy end - it 'clears the idv/doc_auth session' do - expect(controller.user_session['idv/doc_auth']).to be_blank - end - it 'clears the idv/in_person session' do expect(controller.user_session['idv/in_person']).to be_blank end diff --git a/spec/controllers/idv/welcome_controller_spec.rb b/spec/controllers/idv/welcome_controller_spec.rb index efbf607f1ab..7dfcd41267e 100644 --- a/spec/controllers/idv/welcome_controller_spec.rb +++ b/spec/controllers/idv/welcome_controller_spec.rb @@ -12,7 +12,6 @@ before do stub_sign_in(user) stub_analytics - subject.user_session['idv/doc_auth'] = {} allow(subject).to receive(:ab_test_analytics_buckets).and_return(ab_test_args) end diff --git a/spec/lib/session_encryptor_spec.rb b/spec/lib/session_encryptor_spec.rb index 7220adb8f7a..e2eeb30cdc4 100644 --- a/spec/lib/session_encryptor_spec.rb +++ b/spec/lib/session_encryptor_spec.rb @@ -18,7 +18,7 @@ it 'transparently encrypts/decrypts sensitive elements of the session' do session = { 'warden.user.user.session' => { 'idv' => { 'ssn' => '666-66-6666' }, - 'idv/doc_auth' => { 'ssn' => '666-66-6666' }, + 'idv/in_person' => { 'ssn' => '666-66-6666' }, 'other_value' => 42, } } @@ -28,7 +28,7 @@ expect(result).to eq( { 'warden.user.user.session' => { 'idv' => { 'ssn' => '666-66-6666' }, - 'idv/doc_auth' => { 'ssn' => '666-66-6666' }, + 'idv/in_person' => { 'ssn' => '666-66-6666' }, 'other_value' => 42, } }, ) @@ -71,7 +71,7 @@ it 'KMS encrypts/decrypts doc auth elements of the session' do session = { 'warden.user.user.session' => { 'idv' => { 'ssn' => '666-66-6666' }, - 'idv/doc_auth' => { 'ssn' => '666-66-6666' }, + 'idv/in_person' => { 'ssn' => '666-66-6666' }, 'other_value' => 42, } } ciphertext = subject.dump(session) @@ -82,7 +82,7 @@ partially_decrypted_json = JSON.parse(partially_decrypted) expect(partially_decrypted_json.fetch('warden.user.user.session')['idv']).to eq nil - expect(partially_decrypted_json.fetch('warden.user.user.session')['idv/doc_auth']).to eq nil + expect(partially_decrypted_json.fetch('warden.user.user.session')['idv/in_person']).to eq nil expect( partially_decrypted_json.fetch('sensitive_data'), ).to_not eq nil