From 23ea0b35b05692a3692a729d14c36c711e4abbf4 Mon Sep 17 00:00:00 2001 From: charleyf Date: Thu, 28 Sep 2023 08:57:20 -0400 Subject: [PATCH 1/6] Add draft of phone question a_b variable --- config/application.yml.default | 1 + 1 file changed, 1 insertion(+) diff --git a/config/application.yml.default b/config/application.yml.default index 728986ea5f8..4f856119b8c 100644 --- a/config/application.yml.default +++ b/config/application.yml.default @@ -120,6 +120,7 @@ idv_acuant_sdk_version_alternate: '11.8.1' idv_acuant_sdk_upgrade_a_b_testing_enabled: false idv_acuant_sdk_upgrade_a_b_testing_percent: 50 idv_getting_started_a_b_testing: '{"welcome_default":100, "welcome_new":0, "getting_started":0}' +idv_show_phone_question_a_b_testing: '{"default_no_phone_question":100, "new_show_phone_question":0}' idv_send_link_attempt_window_in_minutes: 10 idv_send_link_max_attempts: 5 idv_sp_required: false From 16c676c58965a732c38f9fa0f1b9301f26861b30 Mon Sep 17 00:00:00 2001 From: charleyf Date: Thu, 28 Sep 2023 11:34:12 -0400 Subject: [PATCH 2/6] Change naming --- config/application.yml.default | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/application.yml.default b/config/application.yml.default index 4f856119b8c..db45be010db 100644 --- a/config/application.yml.default +++ b/config/application.yml.default @@ -120,7 +120,7 @@ idv_acuant_sdk_version_alternate: '11.8.1' idv_acuant_sdk_upgrade_a_b_testing_enabled: false idv_acuant_sdk_upgrade_a_b_testing_percent: 50 idv_getting_started_a_b_testing: '{"welcome_default":100, "welcome_new":0, "getting_started":0}' -idv_show_phone_question_a_b_testing: '{"default_no_phone_question":100, "new_show_phone_question":0}' +idv_phone_question_a_b_testing: '{"hide_phone_question":100, "show_phone_question":0}' idv_send_link_attempt_window_in_minutes: 10 idv_send_link_max_attempts: 5 idv_sp_required: false From 05f85a0c65b4c4c35497d040bbce4f5b379ad3e1 Mon Sep 17 00:00:00 2001 From: charleyf Date: Thu, 28 Sep 2023 12:54:49 -0400 Subject: [PATCH 3/6] changelog: Internal, In-Person Proofing, add variable for phone question A/B test From 293660a0c0a4aae0b64aba7fecc197292b469f4b Mon Sep 17 00:00:00 2001 From: charleyf Date: Mon, 2 Oct 2023 09:48:40 -0400 Subject: [PATCH 4/6] Remove redundant key/value in a/b config --- config/application.yml.default | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config/application.yml.default b/config/application.yml.default index d254bd3b9d4..f6d2983ead7 100644 --- a/config/application.yml.default +++ b/config/application.yml.default @@ -120,7 +120,7 @@ idv_acuant_sdk_version_alternate: '11.8.1' idv_acuant_sdk_upgrade_a_b_testing_enabled: false idv_acuant_sdk_upgrade_a_b_testing_percent: 50 idv_getting_started_a_b_testing: '{"welcome_default":100, "welcome_new":0, "getting_started":0}' -idv_phone_question_a_b_testing: '{"hide_phone_question":100, "show_phone_question":0}' +idv_phone_question_a_b_testing: '{"show_phone_question":0}' idv_send_link_attempt_window_in_minutes: 10 idv_send_link_max_attempts: 5 idv_sp_required: false From dc7b35c93a5c948984e5f7d90e3e658f2e40ef40 Mon Sep 17 00:00:00 2001 From: charleyf Date: Mon, 2 Oct 2023 09:51:14 -0400 Subject: [PATCH 5/6] Add variable to IdentityConfig --- lib/identity_config.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/identity_config.rb b/lib/identity_config.rb index efd6d81840e..3ac87ce1817 100644 --- a/lib/identity_config.rb +++ b/lib/identity_config.rb @@ -230,6 +230,7 @@ def self.build_store(config_map) config.add(:idv_available, type: :boolean) config.add(:idv_contact_phone_number, type: :string) config.add(:idv_getting_started_a_b_testing, type: :json, options: { symbolize_names: true }) + config.add(:idv_phone_question_a_b_testing, type: :json, options: {symbolize_names: true}) config.add(:idv_max_attempts, type: :integer) config.add(:idv_min_age_years, type: :integer) config.add(:idv_send_link_attempt_window_in_minutes, type: :integer) From ad4d658e92d14508d380b34ce96120cdacbc5971 Mon Sep 17 00:00:00 2001 From: charleyf Date: Mon, 2 Oct 2023 10:50:38 -0400 Subject: [PATCH 6/6] Lint fixes --- lib/identity_config.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/identity_config.rb b/lib/identity_config.rb index 3ac87ce1817..eab204cbf6f 100644 --- a/lib/identity_config.rb +++ b/lib/identity_config.rb @@ -230,7 +230,7 @@ def self.build_store(config_map) config.add(:idv_available, type: :boolean) config.add(:idv_contact_phone_number, type: :string) config.add(:idv_getting_started_a_b_testing, type: :json, options: { symbolize_names: true }) - config.add(:idv_phone_question_a_b_testing, type: :json, options: {symbolize_names: true}) + config.add(:idv_phone_question_a_b_testing, type: :json, options: { symbolize_names: true }) config.add(:idv_max_attempts, type: :integer) config.add(:idv_min_age_years, type: :integer) config.add(:idv_send_link_attempt_window_in_minutes, type: :integer)