From e0a1ee6466731361053aa28fbf728b5186240d95 Mon Sep 17 00:00:00 2001 From: Zach Margolis Date: Thu, 31 Aug 2023 11:38:11 -0700 Subject: [PATCH 1/2] Update identity verification report to work for older logs (LG-10875) changelog: Internal, Reporting, Update identity verification report query --- lib/reporting/identity_verification_report.rb | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/reporting/identity_verification_report.rb b/lib/reporting/identity_verification_report.rb index bf9684ac159..92b2bf0de8f 100644 --- a/lib/reporting/identity_verification_report.rb +++ b/lib/reporting/identity_verification_report.rb @@ -191,8 +191,13 @@ def query or (name != %{usps_enrollment_status_updated}) | filter (name = %{gpo_verification_submitted} and properties.event_properties.success = 1 and !properties.event_properties.pending_in_person_enrollment and !properties.event_properties.fraud_check_failed) or (name != %{gpo_verification_submitted}) - | fields properties.event_properties.fraud_review_pending as fraud_review_pending, properties.event_properties.gpo_verification_pending as gpo_verification_pending, properties.event_properties.in_person_verification_pending as in_person_verification_pending - | fields !fraud_review_pending and !gpo_verification_pending and !in_person_verification_pending as identity_verified + | fields + coalesce(properties.event_properties.fraud_review_pending, 0) AS fraud_review_pending + , coalesce(properties.event_properties.gpo_verification_pending, 0) AS gpo_verification_pending + , coalesce(properties.event_properties.in_person_verification_pending, 0) AS in_person_verification_pending + , ispresent(properties.event_properties.deactivation_reason) AS has_legacy_deactivation_reason + | fields + !fraud_review_pending and !gpo_verification_pending and !in_person_verification_pending and !has_legacy_deactivation_reason AS identity_verified | limit 10000 QUERY end From 3e338e21359edfeb920991b8828c5ebcafd7172a Mon Sep 17 00:00:00 2001 From: Zach Margolis Date: Thu, 31 Aug 2023 12:22:02 -0700 Subject: [PATCH 2/2] rename property --- lib/reporting/identity_verification_report.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/reporting/identity_verification_report.rb b/lib/reporting/identity_verification_report.rb index 92b2bf0de8f..1c42079b7c7 100644 --- a/lib/reporting/identity_verification_report.rb +++ b/lib/reporting/identity_verification_report.rb @@ -195,9 +195,9 @@ def query coalesce(properties.event_properties.fraud_review_pending, 0) AS fraud_review_pending , coalesce(properties.event_properties.gpo_verification_pending, 0) AS gpo_verification_pending , coalesce(properties.event_properties.in_person_verification_pending, 0) AS in_person_verification_pending - , ispresent(properties.event_properties.deactivation_reason) AS has_legacy_deactivation_reason + , ispresent(properties.event_properties.deactivation_reason) AS has_other_deactivation_reason | fields - !fraud_review_pending and !gpo_verification_pending and !in_person_verification_pending and !has_legacy_deactivation_reason AS identity_verified + !fraud_review_pending and !gpo_verification_pending and !in_person_verification_pending and !has_other_deactivation_reason AS identity_verified | limit 10000 QUERY end