diff --git a/app/controllers/concerns/idv/verify_info_concern.rb b/app/controllers/concerns/idv/verify_info_concern.rb index f257060200e..d3d16d63e3d 100644 --- a/app/controllers/concerns/idv/verify_info_concern.rb +++ b/app/controllers/concerns/idv/verify_info_concern.rb @@ -30,8 +30,7 @@ def shared_update should_proof_state_id: should_use_aamva?(pii), trace_id: amzn_trace_id, user_id: current_user.id, - threatmetrix_session_id: - idv_session.threatmetrix_session_id || flow_session[:threatmetrix_session_id], + threatmetrix_session_id: idv_session.threatmetrix_session_id, request_ip: request.remote_ip, double_address_verification: capture_secondary_id_enabled, ) diff --git a/app/services/idv/steps/threat_metrix_step_helper.rb b/app/services/idv/steps/threat_metrix_step_helper.rb index 24ec29174c9..6817b5cb5d5 100644 --- a/app/services/idv/steps/threat_metrix_step_helper.rb +++ b/app/services/idv/steps/threat_metrix_step_helper.rb @@ -12,12 +12,8 @@ def threatmetrix_view_variables end def generate_threatmetrix_session_id - if !updating_ssn? - idv_session.threatmetrix_session_id = SecureRandom.uuid - # for 50/50 state, to be removed in next deploy - flow_session[:threatmetrix_session_id] = idv_session.threatmetrix_session_id - end - idv_session.threatmetrix_session_id || flow_session[:threatmetrix_session_id] + idv_session.threatmetrix_session_id = SecureRandom.uuid if !updating_ssn? + idv_session.threatmetrix_session_id end # @return [Array] diff --git a/spec/controllers/idv/in_person/ssn_controller_spec.rb b/spec/controllers/idv/in_person/ssn_controller_spec.rb index df614b291e9..ae89bc25a9a 100644 --- a/spec/controllers/idv/in_person/ssn_controller_spec.rb +++ b/spec/controllers/idv/in_person/ssn_controller_spec.rb @@ -79,14 +79,8 @@ ) end - it 'adds a session id to flow session' do - get :show - expect(flow_session[:threatmetrix_session_id]).to_not eq(nil) - end - it 'adds a threatmetrix session id to idv_session' do - get :show - expect(subject.idv_session.threatmetrix_session_id).to_not eq(nil) + expect { get :show }.to change { subject.idv_session.threatmetrix_session_id }.from(nil) end context 'with an ssn in session' do @@ -179,14 +173,6 @@ end it 'does not change threatmetrix_session_id when updating ssn' do - flow_session[:pii_from_user][:ssn] = ssn - put :update, params: params - session_id = flow_session[:threatmetrix_session_id] - subject.threatmetrix_view_variables - expect(flow_session[:threatmetrix_session_id]).to eq(session_id) - end - - it 'does not change idv_session threatmetrix_session_id when updating ssn' do flow_session[:pii_from_user][:ssn] = ssn put :update, params: params session_id = subject.idv_session.threatmetrix_session_id diff --git a/spec/controllers/idv/ssn_controller_spec.rb b/spec/controllers/idv/ssn_controller_spec.rb index ffe86c191ec..4fc35e673fb 100644 --- a/spec/controllers/idv/ssn_controller_spec.rb +++ b/spec/controllers/idv/ssn_controller_spec.rb @@ -88,6 +88,10 @@ ) end + it 'adds a threatmetrix session id to idv_session' do + expect { get :show }.to change { subject.idv_session.threatmetrix_session_id }.from(nil) + end + context 'with an ssn in session' do let(:referer) { idv_document_capture_url } before do @@ -216,27 +220,7 @@ end end - it 'adds a threatmetrix session id to flow session' do - put :update, params: params - subject.threatmetrix_view_variables - expect(flow_session[:threatmetrix_session_id]).to_not eq(nil) - end - - it 'does not change flow_session threatmetrix_session_id when updating ssn' do - flow_session['pii_from_doc'][:ssn] = ssn - put :update, params: params - session_id = flow_session[:threatmetrix_session_id] - subject.threatmetrix_view_variables - expect(flow_session[:threatmetrix_session_id]).to eq(session_id) - end - - it 'adds a threatmetrix session id to idv_session' do - put :update, params: params - subject.threatmetrix_view_variables - expect(subject.idv_session.threatmetrix_session_id).to_not eq(nil) - end - - it 'does not change idv_session threatmetrix_session_id when updating ssn' do + it 'does not change threatmetrix_session_id when updating ssn' do flow_session['pii_from_doc'][:ssn] = ssn put :update, params: params session_id = subject.idv_session.threatmetrix_session_id