From efa5493857f84d9f34cce1f660b54a4396708434 Mon Sep 17 00:00:00 2001 From: Mitchell Henke Date: Thu, 3 Aug 2023 10:08:14 -0500 Subject: [PATCH 1/2] Update phonelib dependencies to add support for newer area codes changelog: Bug Fixes, Phone Number Support, Update dependencies to improve phone number validation --- Gemfile.lock | 2 +- app/javascript/packages/phone-input/package.json | 2 +- yarn.lock | 8 ++++---- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index a88668a7e9c..efeae68cf6e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -447,7 +447,7 @@ GEM pg (1.4.5) pg_query (2.2.0) google-protobuf (>= 3.19.2) - phonelib (0.6.54) + phonelib (0.8.2) pkcs11 (0.3.4) premailer (1.21.0) addressable diff --git a/app/javascript/packages/phone-input/package.json b/app/javascript/packages/phone-input/package.json index 538375d3bd3..c8f0d8a0018 100644 --- a/app/javascript/packages/phone-input/package.json +++ b/app/javascript/packages/phone-input/package.json @@ -4,6 +4,6 @@ "version": "1.0.0", "dependencies": { "intl-tel-input": "^17.0.19", - "libphonenumber-js": "^1.10.11" + "libphonenumber-js": "^1.10.39" } } diff --git a/yarn.lock b/yarn.lock index 1ddefdfbda6..ae4673c323d 100644 --- a/yarn.lock +++ b/yarn.lock @@ -4457,10 +4457,10 @@ levn@^0.4.1: prelude-ls "^1.2.1" type-check "~0.4.0" -libphonenumber-js@^1.10.11: - version "1.10.11" - resolved "https://registry.yarnpkg.com/libphonenumber-js/-/libphonenumber-js-1.10.11.tgz#0078756857bcc5c9dfe097123c6e04ea930e309b" - integrity sha512-ehoihx4HpRXO6FH/uJ0EnaEV4dVU+FDny+jv0S6k9JPyPsAIr0eXDAFvGRMBKE1daCtyHAaFSKCiuCxrOjVAzQ== +libphonenumber-js@^1.10.39: + version "1.10.39" + resolved "https://registry.yarnpkg.com/libphonenumber-js/-/libphonenumber-js-1.10.39.tgz#12dd512621c9ebb13402a694ac81dc78511cd982" + integrity sha512-iPMM/NbSNIrdwbr94rAOos6krB7snhfzEptmk/DJUtTPs+P9gOhZ1YXVPcRgjpp3jJByclfm/Igvz45spfJK7g== lightningcss-darwin-arm64@1.16.1: version "1.16.1" From 89a6f1b75f12d1b0733675a844cde83ea0ff5ead Mon Sep 17 00:00:00 2001 From: Mitchell Henke Date: Thu, 3 Aug 2023 10:35:51 -0500 Subject: [PATCH 2/2] fix specs --- spec/forms/idv/phone_form_spec.rb | 4 ++-- spec/services/phone_formatter_spec.rb | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/spec/forms/idv/phone_form_spec.rb b/spec/forms/idv/phone_form_spec.rb index d168236f981..d07897c019a 100644 --- a/spec/forms/idv/phone_form_spec.rb +++ b/spec/forms/idv/phone_form_spec.rb @@ -69,7 +69,7 @@ let(:optional_params) { { delivery_methods: [:sms] } } it 'uses the user phone number as the initial phone value' do - expect(subject.phone).to eq('+1 787 234 5678') + expect(subject.phone).to eq('+1 787-234-5678') end it 'infers the country code from the user phone number' do expect(subject.international_code).to eq('PR') @@ -125,7 +125,7 @@ } end it 'uses the previously submitted phone + and infers country' do - expect(subject.phone).to eq('+1 787 234 5678') + expect(subject.phone).to eq('+1 787-234-5678') expect(subject.international_code).to eq('PR') end end diff --git a/spec/services/phone_formatter_spec.rb b/spec/services/phone_formatter_spec.rb index bfbb67ed78f..7f607f8f9ab 100644 --- a/spec/services/phone_formatter_spec.rb +++ b/spec/services/phone_formatter_spec.rb @@ -27,7 +27,7 @@ phone = '+13065550100' formatted_phone = PhoneFormatter.format(phone) - expect(formatted_phone).to eq('+1 306 555 0100') + expect(formatted_phone).to eq('+1 306-555-0100') end it 'uses +1 as the default international code' do