LG-10403 End to end spec in person verify by mail#8898
Conversation
Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: Alexander Bradley <alexander.bradley@gsa.gov>
[skip changelog]
soniaconnolly
force-pushed
the
sonia-lg-10403-end-to-end-spec-in-person-verify-by-mail
branch
from
e578504 to
f8c65e6
Compare
| # unsupervised proofing happy path mobile only | ||
| # hybrid mobile end to end (edit hybrid_mobile_spec) | ||
| # verify by mail | ||
| # in person proofing |
There was a problem hiding this comment.
We can take these two comments out now
There was a problem hiding this comment.
Good point. I removed the whole comment and added LG-10495 for the hybrid_mobile spec. Should we add a ticket for a verify by mail spec that doesn't use in_person, or do you think that's covered well enough?
There was a problem hiding this comment.
I feel verify_by_mail is covered well with IPP. The only difference would be the account is active right before the personal key page.
|
|
||
| acknowledge_and_confirm_personal_key | ||
|
|
||
| # click return to sp link |
There was a problem hiding this comment.
should we make this into a method? something like click_return_to_sp_from_ipp?
There was a problem hiding this comment.
Turns out there was a helper. I changed its name to make it more findable.
| user = sign_up | ||
| fill_in t('forms.password'), with: VALID_PASSWORD | ||
| fill_in t('components.password_confirmation.confirm_label'), with: VALID_PASSWORD | ||
| user.password = VALID_PASSWORD |
There was a problem hiding this comment.
Setting this here so that sign_in_live_with_2fa(user) is successful after signing out. This helper is used all over, so wondering if this might hide issues in the future.
soniaconnolly
deleted the
sonia-lg-10403-end-to-end-spec-in-person-verify-by-mail
branch
3 participants
🎫 Ticket
LG-10403
🛠 Summary of changes