From 3db9180284c66838417723799a85f0d2f4a55c10 Mon Sep 17 00:00:00 2001 From: John Maxwell Date: Fri, 17 Feb 2023 14:51:24 -0500 Subject: [PATCH] Removed analytics check from password visibility toggle spec. The test was flaky and the flag is unused, per Andrew Duthie. [skip changelog] --- spec/features/users/sign_in_spec.rb | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/spec/features/users/sign_in_spec.rb b/spec/features/users/sign_in_spec.rb index 68a00743ae8..bda5862e615 100644 --- a/spec/features/users/sign_in_spec.rb +++ b/spec/features/users/sign_in_spec.rb @@ -220,22 +220,10 @@ end scenario 'user can see and use password visibility toggle', js: true do - fake_analytics = FakeAnalytics.new - allow_any_instance_of(ApplicationController).to receive(:analytics).and_return(fake_analytics) - visit new_user_session_path check t('components.password_toggle.toggle_label') - - # Clicking the checkbox triggers a frontend event logging request. Wait for network requests to - # settle before continuing to avoid a race condition. - Capybara.current_session.server.wait_for_pending_requests - expect(page).to have_css('input.password[type="text"]') - expect(fake_analytics).to have_logged_event( - 'Show Password Button Clicked', - path: new_user_session_path, - ) end scenario 'user session expires in amount of time specified by Devise config' do