From 33ebfb1bd723b805419983a23872d1d0f1cec387 Mon Sep 17 00:00:00 2001 From: Mitchell Henke Date: Thu, 29 Dec 2022 10:16:04 -0600 Subject: [PATCH] Avoid double-update to doc_auth_logs table changelog: Internal, Database Optimization, Avoid double-update to doc_auth_logs table --- app/services/funnel/doc_auth/register_submit_step.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/services/funnel/doc_auth/register_submit_step.rb b/app/services/funnel/doc_auth/register_submit_step.rb index 1af964fffc8..f62c85b283a 100644 --- a/app/services/funnel/doc_auth/register_submit_step.rb +++ b/app/services/funnel/doc_auth/register_submit_step.rb @@ -4,6 +4,7 @@ class RegisterSubmitStep def self.call(doc_auth_log, issuer, token, success) update_submit_count(doc_auth_log, issuer, token) update_error_count(doc_auth_log, token, success) + doc_auth_log.save end def self.update_submit_count(doc_auth_log, issuer, token) @@ -13,7 +14,6 @@ def self.update_submit_count(doc_auth_log, issuer, token) method = "#{token}_submit_at".to_sym doc_auth_log[method] = Time.zone.now if doc_auth_log.respond_to?(method) doc_auth_log.issuer = issuer - doc_auth_log.save end private_class_method :update_submit_count @@ -21,7 +21,6 @@ def self.update_error_count(doc_auth_log, token, success) error_count = "#{token}_error_count".to_sym return unless doc_auth_log.respond_to?(error_count) && !success doc_auth_log[error_count] += 1 - doc_auth_log.save end private_class_method :update_error_count end