From d8a8db5050286211735c0666e634479749870152 Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Tue, 1 Nov 2022 13:25:08 -0400 Subject: [PATCH] Remove unreachable liveness content on device choice (upload) step [skip changelog] --- app/javascript/packs/upload-step.js | 10 --------- app/views/idv/doc_auth/upload.html.erb | 27 +++++++++--------------- config/locales/doc_auth/en.yml | 2 -- config/locales/doc_auth/es.yml | 3 --- config/locales/doc_auth/fr.yml | 3 --- spec/support/features/doc_auth_helper.rb | 5 ----- tsconfig.json | 1 - 7 files changed, 10 insertions(+), 41 deletions(-) delete mode 100644 app/javascript/packs/upload-step.js diff --git a/app/javascript/packs/upload-step.js b/app/javascript/packs/upload-step.js deleted file mode 100644 index c2f5bad6a7e..00000000000 --- a/app/javascript/packs/upload-step.js +++ /dev/null @@ -1,10 +0,0 @@ -// app/packs/upload-step.js -import { hasCamera } from '@18f/identity-device'; - -(async () => { - if (await hasCamera()) { - document.getElementById('upload-comp-liveness').classList.add('display-none'); - document.getElementById('upload-comp-liveness-off').classList.remove('display-none'); - document.getElementById('recommended-tag').classList.remove('display-none'); - } -})(); diff --git a/app/views/idv/doc_auth/upload.html.erb b/app/views/idv/doc_auth/upload.html.erb index db0ea979ec4..f8216273df0 100644 --- a/app/views/idv/doc_auth/upload.html.erb +++ b/app/views/idv/doc_auth/upload.html.erb @@ -26,7 +26,7 @@ ) %>
-
+
<%= t('doc_auth.info.tag') %>

@@ -46,21 +46,14 @@
-
- <%= t('doc_auth.info.upload_from_computer') %>  - <%= simple_form_for( - :doc_auth, - url: url_for(type: :desktop), - method: 'PUT', - html: { autocomplete: 'off', class: 'display-inline' }, - ) do |f| %> - <%= f.submit t('doc_auth.info.upload_computer_link'), unstyled: true, big: false, wide: false %> - <% end %> -
- +<%= t('doc_auth.info.upload_from_computer') %>  +<%= simple_form_for( + :doc_auth, + url: url_for(type: :desktop), + method: 'PUT', + html: { class: 'display-inline' }, + ) do |f| %> + <%= f.submit t('doc_auth.info.upload_computer_link'), unstyled: true, big: false %> +<% end %> <%= render 'idv/doc_auth/cancel', step: 'upload' %> -<%= javascript_packs_tag_once 'upload-step' %> diff --git a/config/locales/doc_auth/en.yml b/config/locales/doc_auth/en.yml index 2aa44eb5d77..60d1c8a9cf9 100644 --- a/config/locales/doc_auth/en.yml +++ b/config/locales/doc_auth/en.yml @@ -170,8 +170,6 @@ en: upload: We’ll collect information about you by reading your state-issued ID. upload_computer_link: Upload from your computer upload_from_computer: Don’t have a phone? - upload_from_computer_not_allowed: Sign in to your %{app_name} account on any - device that has a camera, like a tablet or computer with a webcam. upload_from_phone: Upload pictures directly from your phone camera upload_no_image_storage: We do not store images you upload. We only verify your identity. verify_identity: We’ll ask for your personal information to verify your identity diff --git a/config/locales/doc_auth/es.yml b/config/locales/doc_auth/es.yml index cfc913b85d8..a72259a3bd9 100644 --- a/config/locales/doc_auth/es.yml +++ b/config/locales/doc_auth/es.yml @@ -203,9 +203,6 @@ es: expedido por el estado. upload_computer_link: Sube desde tu computadora upload_from_computer: '¿No tiene un teléfono?' - upload_from_computer_not_allowed: Inicie sesión en su cuenta de %{app_name} en - cualquier dispositivo que tenga una cámara, como una tableta o una - computadora con una cámara web. upload_from_phone: Sube imágenes directamente desde la cámara de tu teléfono upload_no_image_storage: No almacenamos imágenes que cargue. Solo verificamos su identidad. verify_identity: Le preguntaremos sus datos personales para verificar su diff --git a/config/locales/doc_auth/fr.yml b/config/locales/doc_auth/fr.yml index 601bb32702c..199c991e56d 100644 --- a/config/locales/doc_auth/fr.yml +++ b/config/locales/doc_auth/fr.yml @@ -213,9 +213,6 @@ fr: d’identité délivrée par l’État. upload_computer_link: Téléchargez depuis votre ordinateur upload_from_computer: Vous n’avez pas de téléphone? - upload_from_computer_not_allowed: Connectez-vous à votre compte %{app_name} sur - tout appareil doté d’une caméra, comme une tablette ou un ordinateur - avec une caméra Web. upload_from_phone: Téléchargez des images directement depuis l’appareil photo de votre téléphone upload_no_image_storage: Nous ne stockons pas les images que vous téléchargez. diff --git a/spec/support/features/doc_auth_helper.rb b/spec/support/features/doc_auth_helper.rb index f81404cf401..aa1867d74af 100644 --- a/spec/support/features/doc_auth_helper.rb +++ b/spec/support/features/doc_auth_helper.rb @@ -98,11 +98,6 @@ def complete_doc_auth_steps_before_upload_step(expect_accessible: false) end def complete_upload_step - if javascript_enabled? - # By default, user would be prevented from continuing on desktop if the proofing flow requires - # liveness and there is no detectable camera. This forces the desktop link to be visible. - page.find('#upload-comp-liveness-off', visible: :all).evaluate_script('this.className = ""') - end click_on t('doc_auth.info.upload_computer_link') end diff --git a/tsconfig.json b/tsconfig.json index c9688298782..93cb39036e6 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -30,7 +30,6 @@ "app/javascript/packs/pw-strength.js", "app/javascript/packs/saml-post.js", "app/javascript/packs/ssn-field.js", - "app/javascript/packs/upload-step.js", "app/javascript/packs/webauthn-authenticate.js", "app/javascript/packs/webauthn-setup.js", "app/javascript/packs/webauthn-unhide.js"