diff --git a/app/forms/idv/inherited_proofing/base_form.rb b/app/forms/idv/inherited_proofing/base_form.rb index 681dd4b1e6f..63559f6575a 100644 --- a/app/forms/idv/inherited_proofing/base_form.rb +++ b/app/forms/idv/inherited_proofing/base_form.rb @@ -48,8 +48,7 @@ def submit FormResponse.new( success: valid?, errors: errors, - extra: { - }, + extra: {}, ) end diff --git a/app/services/idv/inherited_proofing/va/mocks/service.rb b/app/services/idv/inherited_proofing/va/mocks/service.rb index 0a580d60b2d..fc1ed38269f 100644 --- a/app/services/idv/inherited_proofing/va/mocks/service.rb +++ b/app/services/idv/inherited_proofing/va/mocks/service.rb @@ -35,17 +35,22 @@ class Service }, }.freeze + ERROR_HASH = { + errors: 'InheritedProofing::Errors::MHVIdentityDataNotFoundError', + }.freeze + def initialize(service_provider_data) @auth_code = service_provider_data[:auth_code] end def execute - if (@auth_code != VALID_AUTH_CODE) - raise TypeError, - "auth_code is invalid: #{@auth_code}" - end + invalid_auth_code ? ERROR_HASH : PAYLOAD_HASH + end + + private - PAYLOAD_HASH + def invalid_auth_code + @auth_code != VALID_AUTH_CODE end end end diff --git a/lib/session_encryptor.rb b/lib/session_encryptor.rb index 4ef683508b9..c62a1081b17 100644 --- a/lib/session_encryptor.rb +++ b/lib/session_encryptor.rb @@ -99,8 +99,7 @@ def kms_encrypt_pii!(session) # We use #reduce to build the nested empty hash if needed. If Hash#bury # (https://bugs.ruby-lang.org/issues/11747) existed, we could use that instead. def kms_encrypt_sensitive_paths!(session, sensitive_paths) - sensitive_data = { - } + sensitive_data = {} sensitive_paths.each do |path| all_but_last_key = path[0..-2] diff --git a/spec/controllers/users/mfa_selection_controller_spec.rb b/spec/controllers/users/mfa_selection_controller_spec.rb index 0a27aa6c1da..e52e6677e9a 100644 --- a/spec/controllers/users/mfa_selection_controller_spec.rb +++ b/spec/controllers/users/mfa_selection_controller_spec.rb @@ -183,8 +183,7 @@ context 'with no active MFA' do it 'redirects to the index page with a flash error' do patch :update, params: { - two_factor_options_form: { - }, + two_factor_options_form: {}, } expect(response).to redirect_to two_factor_options_path diff --git a/spec/services/idv/inherited_proofing/va/mocks/service_spec.rb b/spec/services/idv/inherited_proofing/va/mocks/service_spec.rb index 8d0fcf5fc05..865383e874b 100644 --- a/spec/services/idv/inherited_proofing/va/mocks/service_spec.rb +++ b/spec/services/idv/inherited_proofing/va/mocks/service_spec.rb @@ -21,7 +21,7 @@ let(:auth_code) { "invalid-#{described_class::VALID_AUTH_CODE}" } it 'returns an error' do - expect { subject.execute }.to raise_error(/auth_code is invalid/) + expect(subject.execute).to eq(described_class::ERROR_HASH) end end end