diff --git a/.rubocop.yml b/.rubocop.yml index fac1220f417..396f4ee21ba 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -928,6 +928,10 @@ Style/BeginBlock: Style/BlockComments: Enabled: true +Style/BlockDelimiters: + Enabled: true + EnforcedStyle: line_count_based + Style/CharacterLiteral: Enabled: true diff --git a/scripts/changelog_check.rb b/scripts/changelog_check.rb index b14d8a45b3e..df7cc6f5f88 100755 --- a/scripts/changelog_check.rb +++ b/scripts/changelog_check.rb @@ -57,11 +57,11 @@ def get_git_log(base_branch, source_branch) # The string is first split on DELIMITER, and then the body is split into # individual lines. def build_structured_git_log(git_log) - git_log.strip.split('DELIMITER').map { |commit| + git_log.strip.split('DELIMITER').map do |commit| commit.split("\nbody:").map do |commit_message_lines| commit_message_lines.split(%r{[\r\n]}).filter { |line| line != '' } end - }.map do |title_and_commit_messages| + end.map do |title_and_commit_messages| title = title_and_commit_messages.first.first.delete_prefix('title: ') messages = title_and_commit_messages[1] SquashedCommit.new( diff --git a/spec/controllers/api/verify/document_capture_controller_spec.rb b/spec/controllers/api/verify/document_capture_controller_spec.rb index 573fae40621..70b41b30026 100644 --- a/spec/controllers/api/verify/document_capture_controller_spec.rb +++ b/spec/controllers/api/verify/document_capture_controller_spec.rb @@ -24,7 +24,7 @@ let(:user) { create(:user, :signed_up) } let(:flow_path) { 'standard' } let(:liveness_checking_enabled) { false } - let(:analytics_data) { + let(:analytics_data) do { browser_attributes: { browser_bot: false, browser_device_name: 'Unknown', @@ -34,7 +34,7 @@ browser_platform_version: '0', browser_version: '0.0', user_agent: 'Rails Testing' } } - } + end before do stub_sign_in(user) if user diff --git a/spec/controllers/api/verify/password_confirm_controller_spec.rb b/spec/controllers/api/verify/password_confirm_controller_spec.rb index bc2e1735f0c..9bdaf30786c 100644 --- a/spec/controllers/api/verify/password_confirm_controller_spec.rb +++ b/spec/controllers/api/verify/password_confirm_controller_spec.rb @@ -63,9 +63,9 @@ def stub_idv_session end context 'with in-person profile' do - let(:applicant) { + let(:applicant) do Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE.merge(same_address_as_id: true) - } + end let(:stub_idv_session) do stub_user_with_applicant_data(user, applicant) end @@ -268,9 +268,9 @@ def stub_idv_session end context 'with threatmetrix required but review status did not pass' do - let(:applicant) { + let(:applicant) do Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE.merge(same_address_as_id: true) - } + end let(:stub_idv_session) do stub_user_with_applicant_data(user, applicant) end @@ -326,9 +326,9 @@ def stub_idv_session end context 'with in person profile' do - let(:applicant) { + let(:applicant) do Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE.merge(same_address_as_id: true) - } + end let(:stub_idv_session) do stub_user_with_applicant_data(user, applicant) end diff --git a/spec/controllers/idv/gpo_verify_controller_spec.rb b/spec/controllers/idv/gpo_verify_controller_spec.rb index e3b41bf776c..5a320954df7 100644 --- a/spec/controllers/idv/gpo_verify_controller_spec.rb +++ b/spec/controllers/idv/gpo_verify_controller_spec.rb @@ -5,14 +5,14 @@ let(:success) { true } let(:otp) { 'ABC123' } let(:submitted_otp) { otp } - let(:pending_profile) { + let(:pending_profile) do create( :profile, :with_pii, user: user, proofing_components: proofing_components, ) - } + end let(:proofing_components) { nil } let(:user) { create(:user) } @@ -124,9 +124,9 @@ end context 'with establishing in person enrollment' do - let(:proofing_components) { + let(:proofing_components) do ProofingComponent.create(user: user, document_check: Idp::Constants::Vendors::USPS) - } + end before do allow(IdentityConfig.store).to receive(:in_person_proofing_enabled).and_return(true) diff --git a/spec/controllers/idv/in_person/usps_locations_controller_spec.rb b/spec/controllers/idv/in_person/usps_locations_controller_spec.rb index 7d1da608bf2..6ce4b26e7d6 100644 --- a/spec/controllers/idv/in_person/usps_locations_controller_spec.rb +++ b/spec/controllers/idv/in_person/usps_locations_controller_spec.rb @@ -30,14 +30,14 @@ describe '#index' do let(:proofer) { double('Proofer') } - let(:locations) { + let(:locations) do [ { name: 'Location 1' }, { name: 'Location 2' }, { name: 'Location 3' }, { name: 'Location 4' }, ] - } + end subject(:response) { get :index } before do diff --git a/spec/controllers/idv/review_controller_spec.rb b/spec/controllers/idv/review_controller_spec.rb index 7f8e1d22d21..d6f18a029c8 100644 --- a/spec/controllers/idv/review_controller_spec.rb +++ b/spec/controllers/idv/review_controller_spec.rb @@ -130,9 +130,9 @@ def show end describe '#confirm_current_password' do - let(:applicant) { + let(:applicant) do Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE.merge(phone_confirmed_at: Time.zone.now) - } + end controller do before_action :confirm_current_password @@ -284,9 +284,9 @@ def show end context 'user fails to supply correct password' do - let(:applicant) { + let(:applicant) do Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE.merge(phone_confirmed_at: Time.zone.now) - } + end before do idv_session @@ -378,17 +378,17 @@ def show end context 'with in person profile' do - let!(:enrollment) { + let!(:enrollment) do create(:in_person_enrollment, :establishing, user: user, profile: nil) - } + end let(:stub_usps_response) do stub_request_enroll end - let(:applicant) { + let(:applicant) do Idp::Constants::MOCK_IDV_APPLICANT_WITH_PHONE.merge( same_address_as_id: true, ) - } + end before do stub_request_token diff --git a/spec/controllers/users/verify_personal_key_controller_spec.rb b/spec/controllers/users/verify_personal_key_controller_spec.rb index 521a226d97e..5425f57a323 100644 --- a/spec/controllers/users/verify_personal_key_controller_spec.rb +++ b/spec/controllers/users/verify_personal_key_controller_spec.rb @@ -70,7 +70,7 @@ end describe '#create' do - let!(:profiles) { + let!(:profiles) do [ create( :profile, @@ -79,7 +79,7 @@ pii: { ssn: '123456789' }, ), ] - } + end let(:error_text) { 'Incorrect personal key' } let(:personal_key_error) { { personal_key: [error_text] } } let(:response_ok) { FormResponse.new(success: true, errors: {}) } diff --git a/spec/features/saml/ial1/account_creation_spec.rb b/spec/features/saml/ial1/account_creation_spec.rb index 984ab91d3ef..098c4a0e541 100644 --- a/spec/features/saml/ial1/account_creation_spec.rb +++ b/spec/features/saml/ial1/account_creation_spec.rb @@ -24,9 +24,9 @@ expect(current_url).to eq sign_up_cancel_url - expect { + expect do click_button t('forms.buttons.cancel') - }.to change(User, :count).by(-1) + end.to change(User, :count).by(-1) expect(current_url).to eq \ new_user_session_url(request_id: ServiceProviderRequestProxy.last.uuid) end @@ -40,9 +40,9 @@ click_link t('links.cancel_account_creation') expect(current_url).to eq sign_up_cancel_url - expect { + expect do click_link t('links.go_back') - }.to change(User, :count).by(0) + end.to change(User, :count).by(0) expect(current_url).to eq previous_url end diff --git a/spec/forms/gpo_verify_form_spec.rb b/spec/forms/gpo_verify_form_spec.rb index a47bb6b8c78..3a0835e5794 100644 --- a/spec/forms/gpo_verify_form_spec.rb +++ b/spec/forms/gpo_verify_form_spec.rb @@ -10,14 +10,14 @@ let(:entered_otp) { otp } let(:otp) { 'ABC123' } let(:code_sent_at) { Time.zone.now } - let(:pending_profile) { + let(:pending_profile) do create( :profile, user: user, deactivation_reason: :gpo_verification_pending, proofing_components: proofing_components, ) - } + end let(:proofing_components) { nil } before do @@ -122,9 +122,9 @@ let!(:enrollment) do create(:in_person_enrollment, :establishing, profile: pending_profile, user: user) end - let(:proofing_components) { + let(:proofing_components) do ProofingComponent.create(user: user, document_check: Idp::Constants::Vendors::USPS) - } + end before do allow(IdentityConfig.store).to receive(:in_person_proofing_enabled).and_return(true) end diff --git a/spec/forms/two_factor_options_form_spec.rb b/spec/forms/two_factor_options_form_spec.rb index 5e345d10627..5ef7eda5e18 100644 --- a/spec/forms/two_factor_options_form_spec.rb +++ b/spec/forms/two_factor_options_form_spec.rb @@ -4,13 +4,13 @@ let(:user) { build(:user) } let(:aal3_required) { false } let(:piv_cac_required) { false } - subject { + subject do described_class.new( user: user, aal3_required: aal3_required, piv_cac_required: piv_cac_required, ) - } + end describe '#submit' do let(:submit_phone) { subject.submit(selection: 'phone') } diff --git a/spec/lib/identity_job_log_subscriber_spec.rb b/spec/lib/identity_job_log_subscriber_spec.rb index bb176b6f1e1..aa0122d3bd9 100644 --- a/spec/lib/identity_job_log_subscriber_spec.rb +++ b/spec/lib/identity_job_log_subscriber_spec.rb @@ -48,7 +48,7 @@ expect(json['exception_message']).to eq 'invalid base64' end - expect { + expect do AddressProofingJob.perform_later( result_id: nil, encrypted_arguments: 'abc', @@ -56,7 +56,7 @@ user_id: SecureRandom.random_number(1000), issuer: build(:service_provider).issuer, ) - }.to raise_error(ArgumentError) + end.to raise_error(ArgumentError) end describe '#enqueue_retry' do diff --git a/spec/lib/session_encryptor_spec.rb b/spec/lib/session_encryptor_spec.rb index cd1c6742393..0bb522dc94c 100644 --- a/spec/lib/session_encryptor_spec.rb +++ b/spec/lib/session_encryptor_spec.rb @@ -122,9 +122,9 @@ }, } - expect { + expect do subject.dump(session) - }.to raise_error( + end.to raise_error( RuntimeError, "invalid session, 'sensitive_data' is reserved key" ) end @@ -138,15 +138,15 @@ 'idv_new' => [{ 'nested' => { 'ssn' => '666-66-6666' } }], } } - expect { + expect do subject.dump(nested_session) - }.to raise_error( + end.to raise_error( SessionEncryptor::SensitiveKeyError, 'ssn unexpectedly appeared in session' ) - expect { + expect do subject.dump(nested_array_session) - }.to raise_error( + end.to raise_error( SessionEncryptor::SensitiveKeyError, 'ssn unexpectedly appeared in session' ) end @@ -174,9 +174,9 @@ 'new_key' => Idp::Constants::MOCK_IDV_APPLICANT[:last_name], } - expect { + expect do subject.dump(session) - }.to raise_error( + end.to raise_error( SessionEncryptor::SensitiveValueError, ) end diff --git a/spec/mailers/user_mailer_spec.rb b/spec/mailers/user_mailer_spec.rb index feb9d2188fe..4d4d69c3341 100644 --- a/spec/mailers/user_mailer_spec.rb +++ b/spec/mailers/user_mailer_spec.rb @@ -522,14 +522,14 @@ def expect_email_body_to_have_help_and_contact_links describe '#in_person_ready_to_verify' do let(:first_name) { 'Michael' } - let!(:enrollment) { + let!(:enrollment) do create( :in_person_enrollment, :pending, selected_location_details: { name: 'FRIENDSHIP' }, status_updated_at: Time.zone.now - 2.hours, ) - } + end let(:mail) do UserMailer.in_person_ready_to_verify( @@ -545,13 +545,13 @@ def expect_email_body_to_have_help_and_contact_links end describe '#in_person_verified' do - let(:enrollment) { + let(:enrollment) do create( :in_person_enrollment, selected_location_details: { name: 'FRIENDSHIP' }, status_updated_at: Time.zone.now - 2.hours, ) - } + end let(:mail) do UserMailer.in_person_verified( @@ -566,13 +566,13 @@ def expect_email_body_to_have_help_and_contact_links end describe '#in_person_failed' do - let(:enrollment) { + let(:enrollment) do create( :in_person_enrollment, selected_location_details: { name: 'FRIENDSHIP' }, status_updated_at: Time.zone.now - 2.hours, ) - } + end let(:mail) do UserMailer.in_person_failed( diff --git a/spec/models/in_person_enrollment_spec.rb b/spec/models/in_person_enrollment_spec.rb index df0298f09f9..6afa3dfe4e4 100644 --- a/spec/models/in_person_enrollment_spec.rb +++ b/spec/models/in_person_enrollment_spec.rb @@ -46,7 +46,7 @@ it 'does not constrain enrollments for non-pending status' do user = create(:user) - expect { + expect do InPersonEnrollment.statuses.each do |key,| status = InPersonEnrollment.statuses[key] profile = create(:profile, :gpo_verification_pending, user: user) @@ -59,7 +59,7 @@ create(:in_person_enrollment, user: user, profile: profile, status: status) end end - }.not_to raise_error + end.not_to raise_error expect(InPersonEnrollment.pending.count).to eq 1 expect(InPersonEnrollment.count).to eq(InPersonEnrollment.statuses.length * 2 - 1) expect(InPersonEnrollment.pending.first.status_updated_at).to_not be_nil @@ -71,9 +71,9 @@ let!(:passed_enrollment) { create(:in_person_enrollment, :passed) } let!(:failing_enrollment) { create(:in_person_enrollment, :failed) } let!(:expired_enrollment) { create(:in_person_enrollment, :expired) } - let!(:checked_pending_enrollment) { + let!(:checked_pending_enrollment) do create(:in_person_enrollment, :pending, status_check_attempted_at: Time.zone.now) - } + end let!(:needy_enrollments) do [ create(:in_person_enrollment, :pending), diff --git a/spec/presenters/piv_cac_error_presenter_spec.rb b/spec/presenters/piv_cac_error_presenter_spec.rb index 2a3fdf18950..eeb7aec4259 100644 --- a/spec/presenters/piv_cac_error_presenter_spec.rb +++ b/spec/presenters/piv_cac_error_presenter_spec.rb @@ -24,12 +24,12 @@ end describe '#description' do - let(:expected_description) { + let(:expected_description) do t( 'instructions.mfa.piv_cac.no_certificate_html', try_again: view.link_to(t('instructions.mfa.piv_cac.try_again'), ''), ) - } + end it { expect(presenter.description).to eq expected_description } end diff --git a/spec/presenters/two_factor_authentication/piv_cac_selection_presenter_spec.rb b/spec/presenters/two_factor_authentication/piv_cac_selection_presenter_spec.rb index 25cd75edb8f..71016917eb5 100644 --- a/spec/presenters/two_factor_authentication/piv_cac_selection_presenter_spec.rb +++ b/spec/presenters/two_factor_authentication/piv_cac_selection_presenter_spec.rb @@ -4,12 +4,12 @@ let(:user_without_mfa) { create(:user) } let(:user_with_mfa) { create(:user, :with_piv_or_cac) } let(:configuration) {} - let(:presenter_without_mfa) { + let(:presenter_without_mfa) do described_class.new(configuration: configuration, user: user_without_mfa) - } - let(:presenter_with_mfa) { + end + let(:presenter_with_mfa) do described_class.new(configuration: configuration, user: user_with_mfa) - } + end describe '#type' do it 'returns piv_cac' do diff --git a/spec/services/doc_auth/error_generator_spec.rb b/spec/services/doc_auth/error_generator_spec.rb index dcfb02e47ba..405d9c8f76c 100644 --- a/spec/services/doc_auth/error_generator_spec.rb +++ b/spec/services/doc_auth/error_generator_spec.rb @@ -265,7 +265,7 @@ def build_error_info( end context 'The correct errors are delivered for image metrics when' do - let(:metrics) { + let(:metrics) do { front: { 'HorizontalResolution' => 300, @@ -280,7 +280,7 @@ def build_error_info( 'GlareMetric' => 50, }, } - } + end it 'front image HDPI is too low' do metrics[:front]['HorizontalResolution'] = 250 diff --git a/spec/services/doc_auth/mock/result_response_spec.rb b/spec/services/doc_auth/mock/result_response_spec.rb index 721ab88dbe9..8f17a60ee1c 100644 --- a/spec/services/doc_auth/mock/result_response_spec.rb +++ b/spec/services/doc_auth/mock/result_response_spec.rb @@ -3,7 +3,7 @@ RSpec.describe DocAuth::Mock::ResultResponse do let(:warn_notifier) { instance_double('Proc') } - subject(:response) { + subject(:response) do config = DocAuth::Mock::Config.new( dpi_threshold: 290, sharpness_threshold: 40, @@ -11,7 +11,7 @@ warn_notifier: warn_notifier, ) described_class.new(input, config, false) - } + end context 'with an image file' do let(:input) { DocAuthImageFixtures.document_front_image } @@ -246,7 +246,7 @@ end context 'with a yaml file containing a passing result' do - subject(:response) { + subject(:response) do config = DocAuth::Mock::Config.new( { dpi_threshold: 290, @@ -255,7 +255,7 @@ }, ) described_class.new(input, config, true) - } + end let(:input) do <<~YAML diff --git a/spec/services/doc_auth/processed_alert_to_log_alert_formatter_spec.rb b/spec/services/doc_auth/processed_alert_to_log_alert_formatter_spec.rb index ce00c1fe573..ea292aabbd8 100644 --- a/spec/services/doc_auth/processed_alert_to_log_alert_formatter_spec.rb +++ b/spec/services/doc_auth/processed_alert_to_log_alert_formatter_spec.rb @@ -17,9 +17,9 @@ end context('when ProcessedAlertToLogAlertFormatter is called') do - subject { + subject do DocAuth::ProcessedAlertToLogAlertFormatter.new.log_alerts(alerts) - } + end it('returns failed if both passed and failed are returned by the alert') do expect(subject).to match(a_hash_including(visible_pattern: { no_side: 'Failed' })) diff --git a/spec/services/doc_auth_router_spec.rb b/spec/services/doc_auth_router_spec.rb index f4fcddca243..0fef16853ee 100644 --- a/spec/services/doc_auth_router_spec.rb +++ b/spec/services/doc_auth_router_spec.rb @@ -174,9 +174,9 @@ ), ) - response = I18n.with_locale(:es) { + response = I18n.with_locale(:es) do proxy.get_results(instance_id: 'abcdef', liveness_enabled: false) - } + end expect(response.errors[:some_other_key]).to eq(['will not be translated']) expect(response.errors[:general]).to match_array( diff --git a/spec/services/idv/phone_step_spec.rb b/spec/services/idv/phone_step_spec.rb index 403b8ac3ac3..7a06442e9cb 100644 --- a/spec/services/idv/phone_step_spec.rb +++ b/spec/services/idv/phone_step_spec.rb @@ -38,12 +38,12 @@ end let(:trace_id) { SecureRandom.uuid } - subject { + subject do described_class.new( idv_session: idv_session, trace_id: trace_id, ) - } + end describe '#submit' do let(:throttle) { Throttle.new(throttle_type: :proof_address, user: user) } diff --git a/spec/services/idv/send_phone_confirmation_otp_spec.rb b/spec/services/idv/send_phone_confirmation_otp_spec.rb index 7d531792969..ecad25a6c7a 100644 --- a/spec/services/idv/send_phone_confirmation_otp_spec.rb +++ b/spec/services/idv/send_phone_confirmation_otp_spec.rb @@ -12,9 +12,9 @@ delivery_method: delivery_preference, ) end - let(:idv_session) { + let(:idv_session) do Idv::Session.new(user_session: {}, current_user: user, service_provider: nil) - } + end let(:user) { create(:user, :signed_up) } diff --git a/spec/services/idv/session_spec.rb b/spec/services/idv/session_spec.rb index 50810895c3d..e425dcd6a46 100644 --- a/spec/services/idv/session_spec.rb +++ b/spec/services/idv/session_spec.rb @@ -4,9 +4,9 @@ let(:user) { create(:user) } let(:user_session) { {} } - subject { + subject do Idv::Session.new(user_session: user_session, current_user: user, service_provider: nil) - } + end describe '#initialize' do context 'without idv user session' do diff --git a/spec/services/idv/steps/ipp/verify_wait_step_show_spec.rb b/spec/services/idv/steps/ipp/verify_wait_step_show_spec.rb index 22244740f3b..ca76b141fe6 100644 --- a/spec/services/idv/steps/ipp/verify_wait_step_show_spec.rb +++ b/spec/services/idv/steps/ipp/verify_wait_step_show_spec.rb @@ -31,12 +31,12 @@ } end - let(:document_capture_session) { + let(:document_capture_session) do document_capture_session = DocumentCaptureSession.create!(user: user) document_capture_session.create_proofing_session document_capture_session.store_proofing_result(idv_result) document_capture_session - } + end let(:dcs_uuid) { document_capture_session.uuid } diff --git a/spec/services/idv/steps/verify_wait_step_show_spec.rb b/spec/services/idv/steps/verify_wait_step_show_spec.rb index 1372a9497a5..3c53a241809 100644 --- a/spec/services/idv/steps/verify_wait_step_show_spec.rb +++ b/spec/services/idv/steps/verify_wait_step_show_spec.rb @@ -31,12 +31,12 @@ } end - let(:document_capture_session) { + let(:document_capture_session) do document_capture_session = DocumentCaptureSession.create!(user: user) document_capture_session.create_proofing_session document_capture_session.store_proofing_result(idv_result) document_capture_session - } + end let(:dcs_uuid) { document_capture_session.uuid } diff --git a/spec/services/request_password_reset_spec.rb b/spec/services/request_password_reset_spec.rb index 6f48f6f993b..6bf0ded0f38 100644 --- a/spec/services/request_password_reset_spec.rb +++ b/spec/services/request_password_reset_spec.rb @@ -94,12 +94,12 @@ impl.call(user, email, **options) end - expect { + expect do RequestPasswordReset.new( email: email, irs_attempts_api_tracker: irs_attempts_api_tracker, ).perform - }. + end. to(change { user.reload.reset_password_token }) end end @@ -167,24 +167,24 @@ max_attempts = IdentityConfig.store.reset_password_email_max_attempts max_attempts.times do - expect { + expect do RequestPasswordReset.new( email: email, analytics: analytics, irs_attempts_api_tracker: irs_attempts_api_tracker, ).perform - }. + end. to(change { user.reload.reset_password_token }) end # extra time, throttled - expect { + expect do RequestPasswordReset.new( email: email, analytics: analytics, irs_attempts_api_tracker: irs_attempts_api_tracker, ).perform - }. + end. to_not(change { user.reload.reset_password_token }) expect(analytics).to have_logged_event( @@ -204,24 +204,24 @@ exactly(max_attempts).times max_attempts.times do - expect { + expect do RequestPasswordReset.new( email: email, analytics: analytics, irs_attempts_api_tracker: irs_attempts_api_tracker, ).perform - }. + end. to(change { user.reload.reset_password_token }) end # extra time, throttled - expect { + expect do RequestPasswordReset.new( email: email, analytics: analytics, irs_attempts_api_tracker: irs_attempts_api_tracker, ).perform - }. + end. to_not(change { user.reload.reset_password_token }) end end diff --git a/spec/support/shared_contexts/inherited_proofing/va_api_context.rb b/spec/support/shared_contexts/inherited_proofing/va_api_context.rb index ae5a049b6d3..bec50c6a17c 100644 --- a/spec/support/shared_contexts/inherited_proofing/va_api_context.rb +++ b/spec/support/shared_contexts/inherited_proofing/va_api_context.rb @@ -8,8 +8,8 @@ let(:private_key) { private_key_from_store_or(file_name: 'empty.key') } let(:payload) { { inherited_proofing_auth: auth_code, exp: 1.day.from_now.to_i } } let(:jwt_token) { JWT.encode(payload, private_key, 'RS256') } - let(:request_uri) { + let(:request_uri) do "#{Idv::InheritedProofing::Va::Service::BASE_URI}/inherited_proofing/user_attributes" - } + end let(:request_headers) { { Authorization: "Bearer #{jwt_token}" } } end diff --git a/spec/support/shared_contexts/inherited_proofing/va_user_context.rb b/spec/support/shared_contexts/inherited_proofing/va_user_context.rb index 4510ccb1fa5..81ac0b82545 100644 --- a/spec/support/shared_contexts/inherited_proofing/va_user_context.rb +++ b/spec/support/shared_contexts/inherited_proofing/va_user_context.rb @@ -1,6 +1,6 @@ RSpec.shared_context 'va_user_context' do # As given to us from VA - let(:user_attributes) { + let(:user_attributes) do { first_name: 'Fakey', last_name: 'Fakerson', address: { street: '123 Fake St', @@ -12,7 +12,7 @@ phone: '2063119187', birth_date: '2022-1-31', ssn: '123456789' } - } + end # Encrypted with AppArtifacts.store.oidc_private_key for testing let(:encrypted_user_attributes) { File.read("#{__dir__}/encrypted_user_attributes.json") } end diff --git a/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb b/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb index 61cd2dbab44..6796f9afd2b 100644 --- a/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb +++ b/spec/views/idv/in_person/ready_to_verify/show.html.erb_spec.rb @@ -7,9 +7,9 @@ let(:profile) { build(:profile, user: user) } let(:enrollment_code) { '2048702198804358' } let(:current_address_matches_id) { true } - let(:selected_location_details) { + let(:selected_location_details) do JSON.parse(UspsInPersonProofing::Mock::Fixtures.enrollment_selected_location_details) - } + end let(:created_at) { Time.zone.parse('2022-07-13') } let(:enrollment) do InPersonEnrollment.new( diff --git a/spec/views/idv/shared/_ssn.html.erb_spec.rb b/spec/views/idv/shared/_ssn.html.erb_spec.rb index c57ae368127..b79af8c70b6 100644 --- a/spec/views/idv/shared/_ssn.html.erb_spec.rb +++ b/spec/views/idv/shared/_ssn.html.erb_spec.rb @@ -9,13 +9,13 @@ let(:updating_ssn) { false } let(:js_domain) { 'h.online-metrix.net' } - let(:tags_js_url) { + let(:tags_js_url) do "https://#{js_domain}/fp/tags.js?org_id=#{lexisnexis_threatmetrix_org_id}&session_id=#{session_id}" - } + end - let(:tags_iframe_url) { + let(:tags_iframe_url) do "https://#{js_domain}/fp/tags?org_id=#{lexisnexis_threatmetrix_org_id}&session_id=#{session_id}" - } + end before :each do allow(view).to receive(:url_for).and_return('https://example.com/')