diff --git a/app/jobs/resolution_proofing_job.rb b/app/jobs/resolution_proofing_job.rb index b763f3de590..eb01c062a27 100644 --- a/app/jobs/resolution_proofing_job.rb +++ b/app/jobs/resolution_proofing_job.rb @@ -171,9 +171,7 @@ def proof_lexisnexis_then_aamva(timer:, applicant_pii:, should_proof_state_id:) def proof_state_id(applicant_pii:, result:) proofer_result = state_id_proofer.proof(applicant_pii) - result.merge!(proofer_result.to_h) do |key, orig, current| - key == :messages ? orig + current : current - end + result.merge!(proofer_result.to_h) exception = proofer_result.exception.inspect if proofer_result.exception result[:timed_out] = proofer_result.timed_out? diff --git a/app/services/proofing/result.rb b/app/services/proofing/result.rb index 644083c5e4b..a058deffb6b 100644 --- a/app/services/proofing/result.rb +++ b/app/services/proofing/result.rb @@ -5,14 +5,12 @@ class Result def initialize( errors: {}, - messages: Set.new, context: {}, exception: nil, transaction_id: nil, reference: nil ) @errors = errors - @messages = messages @context = context @exception = exception @transaction_id = transaction_id @@ -26,19 +24,10 @@ def add_error(key = :base, error) end # rubocop:enable Style/OptionalArguments - def add_message(message) - @messages.add(message) - self - end - def errors @errors.transform_values(&:to_a) end - def messages - @messages.to_a - end - def errors? @errors.any? end @@ -62,7 +51,6 @@ def timed_out? def to_h { errors: errors, - messages: messages, exception: exception, success: success?, } diff --git a/spec/controllers/idv/phone_controller_spec.rb b/spec/controllers/idv/phone_controller_spec.rb index c1861488b57..53d0d1e0e6f 100644 --- a/spec/controllers/idv/phone_controller_spec.rb +++ b/spec/controllers/idv/phone_controller_spec.rb @@ -304,7 +304,6 @@ errors: {}, pii_like_keypaths: [[:errors, :phone], [:context, :stages, :address]], vendor: { - messages: [], context: context, exception: nil, timed_out: false, @@ -356,7 +355,6 @@ }, pii_like_keypaths: [[:errors, :phone], [:context, :stages, :address]], vendor: { - messages: [], context: context, exception: nil, timed_out: false, diff --git a/spec/features/idv/analytics_spec.rb b/spec/features/idv/analytics_spec.rb index 24c31ffb2ff..755b332bf2e 100644 --- a/spec/features/idv/analytics_spec.rb +++ b/spec/features/idv/analytics_spec.rb @@ -29,10 +29,10 @@ 'IdV: doc auth verify visited' => { flow_path: 'standard', step: 'verify', step_count: 1 }, 'IdV: doc auth verify submitted' => { success: true, errors: {}, flow_path: 'standard', step: 'verify', step_count: 1 }, 'IdV: doc auth verify_wait visited' => { flow_path: 'standard', step: 'verify_wait', step_count: 1 }, - 'IdV: doc auth optional verify_wait submitted' => { success: true, errors: {}, address_edited: false, proofing_results: { messages: [], exception: nil, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc', timed_out: false, context: { should_proof_state_id: true, stages: { resolution: { client: 'ResolutionMock', errors: {}, exception: nil, success: true, timed_out: false, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc' }, state_id: { client: 'StateIdMock', errors: {}, success: true, timed_out: false, exception: nil, transaction_id: 'state-id-mock-transaction-id-456', state: 'MT', state_id_jurisdiction: 'ND' } } } }, ssn_is_unique: true, step: 'verify_wait_step_show' }, + 'IdV: doc auth optional verify_wait submitted' => { success: true, errors: {}, address_edited: false, proofing_results: { exception: nil, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc', timed_out: false, context: { should_proof_state_id: true, stages: { resolution: { client: 'ResolutionMock', errors: {}, exception: nil, success: true, timed_out: false, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc' }, state_id: { client: 'StateIdMock', errors: {}, success: true, timed_out: false, exception: nil, transaction_id: 'state-id-mock-transaction-id-456', state: 'MT', state_id_jurisdiction: 'ND' } } } }, ssn_is_unique: true, step: 'verify_wait_step_show' }, 'IdV: phone of record visited' => {}, 'IdV: phone confirmation form' => { success: true, errors: {}, phone_type: :mobile, types: [:fixed_or_mobile], carrier: 'Test Mobile Carrier', country_code: 'US', area_code: '202' }, - 'IdV: phone confirmation vendor' => { success: true, errors: {}, vendor: { messages: [], exception: nil, context: { stages: [{ address: 'AddressMock' }] }, transaction_id: 'address-mock-transaction-id-123', timed_out: false }, new_phone_added: false }, + 'IdV: phone confirmation vendor' => { success: true, errors: {}, vendor: { exception: nil, context: { stages: [{ address: 'AddressMock' }] }, transaction_id: 'address-mock-transaction-id-123', timed_out: false }, new_phone_added: false }, 'IdV: final resolution' => { success: true }, 'IdV: personal key visited' => {}, 'IdV: personal key submitted' => {}, @@ -70,7 +70,7 @@ 'IdV: doc auth verify visited' => { flow_path: 'standard', step: 'verify', step_count: 1 }, 'IdV: doc auth verify submitted' => { success: true, errors: {}, flow_path: 'standard', step: 'verify', step_count: 1 }, 'IdV: doc auth verify_wait visited' => { flow_path: 'standard', step: 'verify_wait', step_count: 1 }, - 'IdV: doc auth optional verify_wait submitted' => { success: true, errors: {}, address_edited: false, proofing_results: { messages: [], exception: nil, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc', timed_out: false, context: { should_proof_state_id: true, stages: { resolution: { client: 'ResolutionMock', errors: {}, exception: nil, success: true, timed_out: false, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc' }, state_id: { client: 'StateIdMock', errors: {}, success: true, timed_out: false, exception: nil, transaction_id: 'state-id-mock-transaction-id-456', state: 'MT', state_id_jurisdiction: 'ND' } } } }, ssn_is_unique: true, step: 'verify_wait_step_show' }, + 'IdV: doc auth optional verify_wait submitted' => { success: true, errors: {}, address_edited: false, proofing_results: { exception: nil, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc', timed_out: false, context: { should_proof_state_id: true, stages: { resolution: { client: 'ResolutionMock', errors: {}, exception: nil, success: true, timed_out: false, transaction_id: 'resolution-mock-transaction-id-123', reference: 'aaa-bbb-ccc' }, state_id: { client: 'StateIdMock', errors: {}, success: true, timed_out: false, exception: nil, transaction_id: 'state-id-mock-transaction-id-456', state: 'MT', state_id_jurisdiction: 'ND' } } } }, ssn_is_unique: true, step: 'verify_wait_step_show' }, 'IdV: phone of record visited' => {}, 'IdV: USPS address letter requested' => { enqueued_at: Time.zone.now }, } diff --git a/spec/features/idv/doc_capture/document_capture_step_spec.rb b/spec/features/idv/doc_capture/document_capture_step_spec.rb index b2503a1c683..7f49520b1e7 100644 --- a/spec/features/idv/doc_capture/document_capture_step_spec.rb +++ b/spec/features/idv/doc_capture/document_capture_step_spec.rb @@ -103,7 +103,6 @@ idv_result: { success: true, errors: {}, - messages: [], pii_from_doc: {}, }, ) diff --git a/spec/jobs/address_proofing_job_spec.rb b/spec/jobs/address_proofing_job_spec.rb index 90941b4673b..9bc65c29636 100644 --- a/spec/jobs/address_proofing_job_spec.rb +++ b/spec/jobs/address_proofing_job_spec.rb @@ -81,7 +81,6 @@ expect(result).to eq( exception: nil, errors: {}, - messages: [], success: true, timed_out: false, transaction_id: conversation_id, diff --git a/spec/jobs/resolution_proofing_job_spec.rb b/spec/jobs/resolution_proofing_job_spec.rb index 2ff8246c433..6538f31f7bb 100644 --- a/spec/jobs/resolution_proofing_job_spec.rb +++ b/spec/jobs/resolution_proofing_job_spec.rb @@ -123,7 +123,6 @@ expect(result).to eq( exception: nil, errors: {}, - messages: [], success: true, timed_out: false, context: { @@ -202,7 +201,6 @@ ), ], }, - messages: [], success: false, timed_out: false, context: { diff --git a/spec/services/document_capture_session_async_result_spec.rb b/spec/services/document_capture_session_async_result_spec.rb index 79f4c1f7dc0..6e82fc0d57e 100644 --- a/spec/services/document_capture_session_async_result_spec.rb +++ b/spec/services/document_capture_session_async_result_spec.rb @@ -22,7 +22,7 @@ let(:status) { DocumentCaptureSessionAsyncResult::DONE } context 'with unsuccessful result' do - let(:idv_result) { { success: false, errors: {}, messages: ['some message'] } } + let(:idv_result) { { success: false, errors: {} } } it 'is false' do expect(subject.success?).to eq false @@ -30,7 +30,7 @@ end context 'with successful result' do - let(:idv_result) { { success: true, errors: {}, messages: [] } } + let(:idv_result) { { success: true, errors: {} } } it 'is true' do expect(subject.success?).to eq true diff --git a/spec/services/idv/phone_step_spec.rb b/spec/services/idv/phone_step_spec.rb index 6de286f6346..403b8ac3ac3 100644 --- a/spec/services/idv/phone_step_spec.rb +++ b/spec/services/idv/phone_step_spec.rb @@ -52,7 +52,6 @@ context = { stages: [{ address: 'AddressMock' }] } extra = { vendor: { - messages: [], context: context, exception: nil, timed_out: false, @@ -83,7 +82,6 @@ context = { stages: [{ address: 'AddressMock' }] } extra = { vendor: { - messages: [], context: context, exception: nil, timed_out: false, diff --git a/spec/services/proofing/base_spec.rb b/spec/services/proofing/base_spec.rb index 4b5f9e8715f..8397d45d363 100644 --- a/spec/services/proofing/base_spec.rb +++ b/spec/services/proofing/base_spec.rb @@ -159,7 +159,6 @@ def hello(applicant, results) expect(subject.failed?).to eq(false) expect(subject.success?).to eq(false) expect(subject.errors).to be_empty - expect(subject.messages).to be_empty expect(subject.exception).not_to be_nil expect(subject.exception.message). to eq('Required attributes first_name, last_name, ssn are not present') @@ -176,7 +175,6 @@ def hello(applicant, results) expect(subject.failed?).to eq(false) expect(subject.success?).to eq(true) expect(subject.errors).to be_empty - expect(subject.messages).to be_empty expect(subject.exception).to be_nil end end @@ -191,7 +189,6 @@ def hello(applicant, results) expect(subject.failed?).to eq(true) expect(subject.success?).to eq(false) expect(subject.errors).not_to be_empty - expect(subject.messages).to be_empty expect(subject.exception).to be_nil end end @@ -206,7 +203,6 @@ def hello(applicant, results) expect(subject.success?).to eq(false) expect(subject.failed?).to eq(false) expect(subject.errors).to be_empty - expect(subject.messages).to be_empty expect(subject.exception).not_to be_nil end @@ -239,7 +235,6 @@ def hello(applicant, results) expect(subject.failed?).to eq(false) expect(subject.success?).to eq(true) expect(subject.errors).to be_empty - expect(subject.messages).to be_empty expect(subject.exception).to be_nil end end @@ -262,7 +257,6 @@ def hello(applicant, results) expect(subject.failed?).to eq(false) expect(subject.success?).to eq(true) expect(subject.errors).to be_empty - expect(subject.messages).to be_empty expect(subject.exception).to be_nil end end @@ -281,7 +275,6 @@ def hello(applicant, results) expect(subject.failed?).to eq(false) expect(subject.success?).to eq(true) expect(subject.errors).to be_empty - expect(subject.messages).to be_empty expect(subject.exception).to be_nil end end diff --git a/spec/services/proofing/result_spec.rb b/spec/services/proofing/result_spec.rb index 3ba4f4fb1ad..cddcf1b681b 100644 --- a/spec/services/proofing/result_spec.rb +++ b/spec/services/proofing/result_spec.rb @@ -29,23 +29,6 @@ end end - describe '#add_message' do - let(:message) { 'FOOBAR' } - let(:result) { Proofing::Result.new.add_message(message) } - - it 'returns itself' do - expect(result).to be_an_instance_of(Proofing::Result) - end - - it 'adds a message' do - expect(result.messages).to eq([message]) - end - - it 'does not add duplicate message' do - expect(result.add_message(message).messages).to eq([message]) - end - end - describe '#exception?' do subject { result.exception? }