From 28099c75de3ac703e7e1783889eb8997982dade7 Mon Sep 17 00:00:00 2001 From: Jonathan Hooper Date: Mon, 8 Aug 2022 11:57:45 -0400 Subject: [PATCH 1/3] Log the enqueued_at date when a user enters a code This will allow us to bin letter sent and code entered events based on when the letter was sent --- app/forms/gpo_verify_form.rb | 1 + spec/forms/gpo_verify_form_spec.rb | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/app/forms/gpo_verify_form.rb b/app/forms/gpo_verify_form.rb index 62b42cdbb02..b75ee89ac84 100644 --- a/app/forms/gpo_verify_form.rb +++ b/app/forms/gpo_verify_form.rb @@ -31,6 +31,7 @@ def submit success: result, errors: errors, extra: { + enqueued_at: gpo_confirmation_code&.code_sent_at, pii_like_keypaths: [[:errors, :otp], [:error_details, :otp]], pending_in_person_enrollment: pending_in_person_enrollment?, }, diff --git a/spec/forms/gpo_verify_form_spec.rb b/spec/forms/gpo_verify_form_spec.rb index 4881c8d1627..a47bb6b8c78 100644 --- a/spec/forms/gpo_verify_form_spec.rb +++ b/spec/forms/gpo_verify_form_spec.rb @@ -111,6 +111,13 @@ expect(pending_profile.reload).to be_active end + it 'logs the date the code was sent at' do + result = subject.submit + + confirmation_code = pending_profile.gpo_confirmation_codes.last + expect(result.to_h[:enqueued_at]).to eq(confirmation_code.code_sent_at) + end + context 'pending in person enrollment' do let!(:enrollment) do create(:in_person_enrollment, :establishing, profile: pending_profile, user: user) From 19fc35476ef9a4329a39b270bdfd105d2ee7c0f3 Mon Sep 17 00:00:00 2001 From: Jonathan Hooper Date: Mon, 8 Aug 2022 12:02:01 -0400 Subject: [PATCH 2/3] changelog: Improvements, Identity Verification, Internal logging for tracking letter confirmations was added. From ddb42209ae9406c8369a094cbd7b2b7672607ae7 Mon Sep 17 00:00:00 2001 From: Jonathan Hooper Date: Mon, 8 Aug 2022 12:35:46 -0400 Subject: [PATCH 3/3] fix tests --- spec/controllers/idv/gpo_verify_controller_spec.rb | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/spec/controllers/idv/gpo_verify_controller_spec.rb b/spec/controllers/idv/gpo_verify_controller_spec.rb index fa192bff695..e3b41bf776c 100644 --- a/spec/controllers/idv/gpo_verify_controller_spec.rb +++ b/spec/controllers/idv/gpo_verify_controller_spec.rb @@ -105,6 +105,7 @@ success: true, errors: {}, pending_in_person_enrollment: false, + enqueued_at: user.pending_profile.gpo_confirmation_codes.last.code_sent_at, pii_like_keypaths: [[:errors, :otp], [:error_details, :otp]], ) @@ -139,6 +140,7 @@ success: true, errors: {}, pending_in_person_enrollment: true, + enqueued_at: user.pending_profile.gpo_confirmation_codes.last.code_sent_at, pii_like_keypaths: [[:errors, :otp], [:error_details, :otp]], ) @@ -164,6 +166,7 @@ success: false, errors: { otp: [t('errors.messages.confirmation_code_incorrect')] }, pending_in_person_enrollment: false, + enqueued_at: nil, error_details: { otp: [:confirmation_code_incorrect] }, pii_like_keypaths: [[:errors, :otp], [:error_details, :otp]], ) @@ -191,6 +194,7 @@ success: false, errors: { otp: [t('errors.messages.confirmation_code_incorrect')] }, pending_in_person_enrollment: false, + enqueued_at: nil, error_details: { otp: [:confirmation_code_incorrect] }, pii_like_keypaths: [[:errors, :otp], [:error_details, :otp]], ).exactly(max_attempts).times