diff --git a/app/controllers/idv/otp_delivery_method_controller.rb b/app/controllers/idv/otp_delivery_method_controller.rb index 108d87d1416..005b35153a2 100644 --- a/app/controllers/idv/otp_delivery_method_controller.rb +++ b/app/controllers/idv/otp_delivery_method_controller.rb @@ -10,7 +10,7 @@ class OtpDeliveryMethodController < ApplicationController before_action :set_idv_phone def new - analytics.track_event(Analytics::IDV_PHONE_OTP_DELIVERY_SELECTION_VISIT) + analytics.idv_phone_otp_delivery_selection_visit render :new, locals: { gpo_letter_available: gpo_letter_available } end diff --git a/app/controllers/idv/phone_controller.rb b/app/controllers/idv/phone_controller.rb index af0e5131b00..efb1dcede4a 100644 --- a/app/controllers/idv/phone_controller.rb +++ b/app/controllers/idv/phone_controller.rb @@ -8,15 +8,13 @@ class PhoneController < ApplicationController before_action :set_idv_form def new - if params[:step] - analytics.track_event(Analytics::IDV_PHONE_USE_DIFFERENT, step: params[:step]) - end + analytics.idv_phone_use_different(step: params[:step]) if params[:step] redirect_to failure_url(:fail) and return if throttle.throttled? async_state = step.async_state if async_state.none? - analytics.track_event(Analytics::IDV_PHONE_RECORD_VISIT) + analytics.idv_phone_of_record_visited render :new, locals: { gpo_letter_available: gpo_letter_available } elsif async_state.in_progress? render :wait diff --git a/app/controllers/idv/review_controller.rb b/app/controllers/idv/review_controller.rb index eb304dde471..18329ffee2c 100644 --- a/app/controllers/idv/review_controller.rb +++ b/app/controllers/idv/review_controller.rb @@ -30,7 +30,7 @@ def confirm_current_password def new @applicant = idv_session.applicant @step_indicator_steps = step_indicator_steps - analytics.track_event(Analytics::IDV_REVIEW_VISIT) + analytics.idv_review_info_visited gpo_mail_service = Idv::GpoMail.new(current_user) flash_now = flash.now @@ -45,7 +45,7 @@ def create init_profile user_session[:need_personal_key_confirmation] = true redirect_to next_step - analytics.track_event(Analytics::IDV_REVIEW_COMPLETE) + analytics.idv_review_complete analytics.idv_final(success: true) return unless FeatureManagement.reveal_gpo_code? diff --git a/app/services/analytics.rb b/app/services/analytics.rb index fc65bba6b40..e48d086c0de 100644 --- a/app/services/analytics.rb +++ b/app/services/analytics.rb @@ -143,11 +143,6 @@ def session_started_at IDV_INTRO_VISIT = 'IdV: intro visited' IDV_JURISDICTION_VISIT = 'IdV: jurisdiction visited' IDV_JURISDICTION_FORM = 'IdV: jurisdiction form submitted' - IDV_PHONE_OTP_DELIVERY_SELECTION_VISIT = 'IdV: Phone OTP delivery Selection Visited' - IDV_PHONE_USE_DIFFERENT = 'IdV: use different phone number' - IDV_PHONE_RECORD_VISIT = 'IdV: phone of record visited' - IDV_REVIEW_COMPLETE = 'IdV: review complete' - IDV_REVIEW_VISIT = 'IdV: review info visited' IDV_START_OVER = 'IdV: start over' IDV_GPO_ADDRESS_LETTER_REQUESTED = 'IdV: USPS address letter requested' IDV_GPO_ADDRESS_SUBMITTED = 'IdV: USPS address submitted' diff --git a/app/services/analytics_events.rb b/app/services/analytics_events.rb index e739bae42b6..e7f223516ee 100644 --- a/app/services/analytics_events.rb +++ b/app/services/analytics_events.rb @@ -807,6 +807,36 @@ def idv_phone_otp_delivery_selection_submitted( ) end + # User visited idv phone of record + def idv_phone_of_record_visited + track_event('IdV: phone of record visited') + end + + # User visited idv phone OTP delivery selection + def idv_phone_otp_delivery_selection_visit + track_event('IdV: Phone OTP delivery Selection Visited') + end + + # @param [String] step the step the user was on when they clicked use a different phone number + # User decided to use a different phone number in idv + def idv_phone_use_different(step:, **extra) + track_event( + 'IdV: use different phone number', + step: step, + **extra, + ) + end + + # User completed idv + def idv_review_complete + track_event('IdV: review complete') + end + + # User visited idv phone of record + def idv_review_info_visited + track_event('IdV: review info visited') + end + # User has visited the page that lets them confirm if they want a new personal key def profile_personal_key_visit track_event('Profile: Visited new personal key') diff --git a/app/services/funnel/doc_auth/register_step_from_analytics_view_event.rb b/app/services/funnel/doc_auth/register_step_from_analytics_view_event.rb index f873533b01e..4ba65687317 100644 --- a/app/services/funnel/doc_auth/register_step_from_analytics_view_event.rb +++ b/app/services/funnel/doc_auth/register_step_from_analytics_view_event.rb @@ -2,8 +2,8 @@ module Funnel module DocAuth class RegisterStepFromAnalyticsViewEvent ANALYTICS_EVENT_TO_DOC_AUTH_LOG_TOKEN = { - Analytics::IDV_PHONE_RECORD_VISIT => :verify_phone, - Analytics::IDV_REVIEW_VISIT => :encrypt, + 'IdV: phone of record visited' => :verify_phone, + 'IdV: review info visited' => :encrypt, 'IdV: final resolution' => :verified, Analytics::IDV_GPO_ADDRESS_VISITED => :usps_address, }.freeze diff --git a/spec/controllers/idv/otp_delivery_method_controller_spec.rb b/spec/controllers/idv/otp_delivery_method_controller_spec.rb index 51253c2ed35..b3f444e6abc 100644 --- a/spec/controllers/idv/otp_delivery_method_controller_spec.rb +++ b/spec/controllers/idv/otp_delivery_method_controller_spec.rb @@ -69,7 +69,7 @@ get :new expect(@analytics).to have_received(:track_event). - with(Analytics::IDV_PHONE_OTP_DELIVERY_SELECTION_VISIT) + with('IdV: Phone OTP delivery Selection Visited') end end diff --git a/spec/controllers/idv/phone_controller_spec.rb b/spec/controllers/idv/phone_controller_spec.rb index c27e6121573..8eaa95152fb 100644 --- a/spec/controllers/idv/phone_controller_spec.rb +++ b/spec/controllers/idv/phone_controller_spec.rb @@ -91,7 +91,7 @@ get :new, params: params expect(@analytics).to have_received(:track_event). - with(Analytics::IDV_PHONE_USE_DIFFERENT, step: step) + with('IdV: use different phone number', step: step) end end diff --git a/spec/controllers/idv/review_controller_spec.rb b/spec/controllers/idv/review_controller_spec.rb index cd866e877b7..5c2068fa26c 100644 --- a/spec/controllers/idv/review_controller_spec.rb +++ b/spec/controllers/idv/review_controller_spec.rb @@ -296,7 +296,7 @@ def show it 'redirects to personal key path' do put :create, params: { user: { password: ControllerHelper::VALID_PASSWORD } } - expect(@analytics).to have_received(:track_event).with(Analytics::IDV_REVIEW_COMPLETE) + expect(@analytics).to have_received(:track_event).with('IdV: review complete') expect(@analytics).to have_received(:track_event).with( 'IdV: final resolution', success: true,