diff --git a/app/views/users/shared/_otp_delivery_preference_selection.html.erb b/app/views/users/shared/_otp_delivery_preference_selection.html.erb index 018ddefd050..74603902862 100644 --- a/app/views/users/shared/_otp_delivery_preference_selection.html.erb +++ b/app/views/users/shared/_otp_delivery_preference_selection.html.erb @@ -19,6 +19,7 @@ form_name_label, :sms, form_obj.delivery_preference_sms?, + disabled: VendorStatus.new.vendor_outage?(:sms), class: 'js-otp-delivery-preference usa-radio__input usa-radio__input--bordered', ) %> @@ -30,6 +31,7 @@ form_name_label, :voice, form_obj.delivery_preference_voice?, + disabled: VendorStatus.new.vendor_outage?(:voice), class: 'js-otp-delivery-preference usa-radio__input usa-radio__input--bordered', ) %> diff --git a/app/views/users/two_factor_authentication_setup/index.html.erb b/app/views/users/two_factor_authentication_setup/index.html.erb index c70c1d9fba1..9b5f5961cfe 100644 --- a/app/views/users/two_factor_authentication_setup/index.html.erb +++ b/app/views/users/two_factor_authentication_setup/index.html.erb @@ -1,5 +1,7 @@ <% title t('titles.two_factor_setup') %> +<%= render(VendorOutageAlertComponent.new(vendors: [:sms, :voice], context: :voice, only_if_all: true)) %> + <% if @presenter.icon %> <%= image_tag( asset_url(@presenter.icon), @@ -27,6 +29,7 @@ 'two_factor_options_form[selection]', option.type, false, + disabled: option.disabled?, class: 'usa-radio__input usa-radio__input--tile', ) %> <%= label_tag( @@ -37,7 +40,7 @@ <%= option.info %> <% if option.security_level && @presenter.show_security_level? %> - + <%= option.security_level %> <% end %> diff --git a/app/views/vendor_outage/show.html.erb b/app/views/vendor_outage/show.html.erb index abd63da811c..99317898f20 100644 --- a/app/views/vendor_outage/show.html.erb +++ b/app/views/vendor_outage/show.html.erb @@ -2,6 +2,10 @@ 'idv/shared/error', heading: t('vendor_outage.working'), options: [ + @show_gpo_option && { + text: t('idv.troubleshooting.options.verify_by_mail'), + url: idv_gpo_path, + }, { text: t('vendor_outage.get_updates_on_status_page'), url: StatusPage.base_url, @@ -12,11 +16,9 @@ url: MarketingSite.contact_url, new_tab: true, }, - ], + ].select(&:present?), ) do %> <%= @specific_message %> <% end %> -<%= render( - 'idv/doc_auth/back', - ) %> +<%= render('idv/doc_auth/back') %> diff --git a/config/locales/vendor_outage/en.yml b/config/locales/vendor_outage/en.yml index dbac4794573..4fa7ff9debc 100644 --- a/config/locales/vendor_outage/en.yml +++ b/config/locales/vendor_outage/en.yml @@ -1,16 +1,39 @@ --- en: vendor_outage: + alerts: + phone: + default: We cannot verify phones at this time. Please use another authentication + method if you have one, or try again later. + idv: We cannot verify phones at this time. Please try again later or verify your + address by mail instead. + sms: + default: We cannot send text messages (SMS) at this time. You can get a code by + phone call, or choose another authentication method if you have one. + idv: We cannot send text messages (SMS) at this time. You can get a code by + phone call, or verify your address by mail instead. + voice: + default: We cannot send phone calls at this time. You can get a code by text + message (SMS), or choose another authentication method if you have + one. + idv: We cannot send phone calls at this time. You can get a code by text message + (SMS), or verify your address by mail instead. + blocked: + idv: + generic: We are having technical difficulties on our end and cannot verify your + identity at this time. Please try again later. + with_sp: '%{service_provider} needs to make sure you are you — not someone + pretending to be you. Unfortunately, we are having technical + difficulties and cannot verify your identity at this time. Please try + again later.' + without_sp: The agency that you are trying to access needs to make sure you are + you — not someone pretending to be you. Unfortunately, we are having + technical difficulties and cannot verify your identity at this time. + Please try again later. + phone: + default: We cannot verify phones at this time. Please try again later. + idv: We cannot verify phones at this time. Please try again later or verify your + address by mail instead. + get_updates: Get updates get_updates_on_status_page: Get updates on our status page - idv_blocked: - generic: We are having technical difficulties on our end and cannot verify your - identity at this time. Please try again later. - with_sp: '%{service_provider} needs to make sure you are you — not someone - pretending to be you. Unfortunately, we are having technical - difficulties and cannot verify your identity at this time. Please try - again later.' - without_sp: The agency that you are trying to access needs to make sure you are - you — not someone pretending to be you. Unfortunately, we are having - technical difficulties and cannot verify your identity at this time. - Please try again later. working: We are working to resolve an error diff --git a/config/locales/vendor_outage/es.yml b/config/locales/vendor_outage/es.yml index afd5172d68a..094859a4cd5 100644 --- a/config/locales/vendor_outage/es.yml +++ b/config/locales/vendor_outage/es.yml @@ -1,17 +1,49 @@ --- es: vendor_outage: + alerts: + phone: + default: No podemos verificar teléfonos en estos momentos. Por favor, utilice + otro método de auntentificación, si cuenta con uno, o inténtelo + nuevamente más tarde. + idv: No podemos verificar teléfonos en estos momentos. Por favor, inténtelo + nuevamente más tarde o, en lugar de ello, verifique su dirección por + correo. + sms: + default: No podemos enviar mensajes de texto (SMS) en estos momentos. Puede + recibir un código por medio de una llamada telefónica o elegir otro + método de auntentificación, si cuenta con uno. + idv: No podemos enviar mensajes de texto (SMS) en estos momentos. Puede recibir + un código por medio de una llamada telefónica o, en su lugar, + verificar su dirección por correo. + voice: + default: No podemos enviar llamadas telefónicas en estos momentos. Puede recibir + un código por medio de un mensaje de texto (SMS) o elegir otro método + de auntentificación, si cuenta con uno. + idv: No podemos enviar llamadas telefónicas en estos momentos. Puede recibir un + código por medio de un mensaje de texto (SMS) o, en su lugar, + verificar su dirección por correo. + blocked: + idv: + generic: Debido a problemas técnicos por nuestra parte, no podemos verificar su + identidad en estos momentos. Por favor, inténtelo nuevamente más + tarde. + with_sp: '%{service_provider} necesita asegurarse de que es usted realmente y no + alguien que se hace pasar por usted. Lamentablemente, debido a + problemas técnicos por nuestra parte, tal vez no podamos verificar su + identidad en estos momentos. Por favor, inténtelo nuevamente más + tarde.' + without_sp: La agencia a la que está intentando acceder debe asegurarse de que + usted sea quien dice ser, y no alguien que se hace pasar por usted. + Lamentablemente, debido a problemas técnicos por nuestra parte, tal + vez no podamos verificar su identidad en estos momentos. Por favor, + inténtelo nuevamente más tarde. + phone: + default: No podemos verificar teléfonos en estos momentos. Por favor, inténtelo + nuevamente más tarde. + idv: No podemos verificar teléfonos en estos momentos. Por favor, inténtelo + nuevamente más tarde o, en lugar de ello, verifique su dirección por + correo. + get_updates: Obtenga actualizaciones get_updates_on_status_page: Reciba actualizaciones en nuestra página de estado - idv_blocked: - generic: Debido a problemas técnicos por nuestra parte, no podemos verificar su - identidad en estos momentos. Por favor, inténtelo nuevamente más tarde. - with_sp: '%{service_provider} necesita asegurarse de que es usted realmente y no - alguien que se hace pasar por usted. Lamentablemente, debido a problemas - técnicos por nuestra parte, tal vez no podamos verificar su identidad en - estos momentos. Por favor, inténtelo nuevamente más tarde.' - without_sp: La agencia a la que está intentando acceder debe asegurarse de que - usted sea quien dice ser, y no alguien que se hace pasar por usted. - Lamentablemente, debido a problemas técnicos por nuestra parte, tal vez - no podamos verificar su identidad en estos momentos. Por favor, - inténtelo nuevamente más tarde. working: Estamos trabajando para corregir un error diff --git a/config/locales/vendor_outage/fr.yml b/config/locales/vendor_outage/fr.yml index c7a8414a366..1c31082b146 100644 --- a/config/locales/vendor_outage/fr.yml +++ b/config/locales/vendor_outage/fr.yml @@ -1,17 +1,45 @@ --- fr: vendor_outage: + alerts: + phone: + default: Nous ne pouvons pas vérifier les téléphones pour le moment. Veuillez + utiliser une autre méthode d'authentification si vous en avez une, ou + réessayez plus tard. + idv: Nous ne pouvons pas vérifier les téléphones pour le moment. Veuillez + réessayer plus tard ou vérifier votre adresse par la poste. + sms: + default: Nous ne pouvons pas envoyer de messages texte (SMS) pour le moment. + Vous pouvez obtenir un code par appel téléphonique ou choisir une + autre méthode d'authentification si vous en avez un. + idv: Nous ne pouvons pas envoyer de messages texte (SMS) pour le moment. Vous + pouvez obtenir un code par téléphone ou vérifier votre adresse par la + poste. + voice: + default: Nous ne pouvons pas envoyer d'appels téléphoniques pour le moment. Vous + pouvez obtenir un code par message texte (SMS) ou choisir une autre + méthode d'authentification si vous en avez une. + idv: Nous ne pouvons pas envoyer d'appels téléphoniques pour le moment. Vous + pouvez obtenir un code par message texte (SMS), ou vérifier votre + adresse par la poste. + blocked: + idv: + generic: Nous rencontrons des difficultés techniques et ne pouvons pas vérifier + votre identité pour le moment. Veuillez réessayer plus tard. + with_sp: "%{service_provider} doit s'assurer que c'est bien vous — et non + quelqu'un qui se fait passer pour vous. Malheureusement, nous + rencontrons des difficultés techniques et ne pouvons pas vérifier + votre identité pour le moment. Veuillez réessayer plus tard." + without_sp: L’agence à laquelle vous essayez d’accéder doit s’assurer qu’il + s’agit bien de vous, et non de quelqu’un qui se fait passer pour vous. + Malheureusement, nous rencontrons des difficultés techniques et ne + pouvons pas vérifier votre identité pour le moment. Veuillez réessayer + plus tard. + phone: + default: Nous ne pouvons pas vérifier les téléphones pour le moment. Veuillez + réessayer plus tard. + idv: Nous ne pouvons pas vérifier les téléphones pour le moment. Veuillez + réessayer plus tard ou vérifier votre adresse par la poste. + get_updates: Obtenir des mises à jour get_updates_on_status_page: Obtenez des mises à jour sur notre page de statut - idv_blocked: - generic: Nous rencontrons des difficultés techniques et ne pouvons pas vérifier - votre identité pour le moment. Veuillez réessayer plus tard. - with_sp: "%{service_provider} doit s'assurer que c'est bien vous — et non - quelqu'un qui se fait passer pour vous. Malheureusement, nous - rencontrons des difficultés techniques et ne pouvons pas vérifier votre - identité pour le moment. Veuillez réessayer plus tard." - without_sp: L’agence à laquelle vous essayez d’accéder doit s’assurer qu’il - s’agit bien de vous, et non de quelqu’un qui se fait passer pour vous. - Malheureusement, nous rencontrons des difficultés techniques et ne - pouvons pas vérifier votre identité pour le moment. Veuillez réessayer - plus tard. working: "Nous travaillons à la résolution d'une erreur" diff --git a/spec/components/vendor_outage_alert_component_spec.rb b/spec/components/vendor_outage_alert_component_spec.rb new file mode 100644 index 00000000000..cc808b32bf1 --- /dev/null +++ b/spec/components/vendor_outage_alert_component_spec.rb @@ -0,0 +1,74 @@ +require 'rails_helper' + +RSpec.describe VendorOutageAlertComponent, type: :component do + let(:vendors) { [:sms, :voice] } + let(:context) { 'default' } + let(:only_if_all) { false } + + subject(:rendered) do + render_inline VendorOutageAlertComponent.new( + vendors: vendors, + context: context, + only_if_all: only_if_all, + ) + end + + context 'with no outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + end + + it 'renders nothing' do + expect(rendered.to_s).to be_empty + end + end + + context 'with outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:voice).and_return(false) + end + + it 'renders error alert with status page url' do + expect(rendered).to have_content(t('vendor_outage.alerts.sms.default')) + expect(rendered).to have_link(t('vendor_outage.get_updates'), href: StatusPage.base_url) + end + + context 'with contextual message' do + subject(:context) { :idv } + + it 'renders error alert with contextualized message' do + expect(rendered).to have_content(t('vendor_outage.alerts.sms.idv')) + end + + context 'with unknown contextual message' do + subject(:context) { :unknown } + + it 'renders error alert with default message' do + expect(rendered).to have_content(t('vendor_outage.alerts.sms.default')) + end + end + end + + context 'constrained to only_if_all' do + let(:only_if_all) { true } + let(:all_outage) { false } + + before do + allow_any_instance_of(VendorStatus).to receive(:all_vendor_outage?).and_return(all_outage) + end + + it 'renders nothing' do + expect(rendered.to_s).to be_empty + end + + context 'with all outage' do + let(:all_outage) { true } + + it 'renders error alert' do + expect(rendered).to have_content(t('vendor_outage.alerts.phone.default')) + end + end + end + end +end diff --git a/spec/controllers/idv/phone_controller_spec.rb b/spec/controllers/idv/phone_controller_spec.rb index 832b8d88f97..782030ff682 100644 --- a/spec/controllers/idv/phone_controller_spec.rb +++ b/spec/controllers/idv/phone_controller_spec.rb @@ -186,14 +186,16 @@ end context 'when same as user phone' do - it 'redirects to review page and sets phone_confirmed_at' do + before do user = build( :user, :with_phone, with: { phone: good_phone, confirmed_at: Time.zone.now } ) stub_verify_steps_one_and_two(user) + end + it 'redirects to review page and sets phone_confirmed_at' do put :create, params: { idv_phone_form: { phone: good_phone } } expect(response).to redirect_to idv_phone_path @@ -211,17 +213,34 @@ expect(subject.idv_session.vendor_phone_confirmation).to eq true expect(subject.idv_session.user_phone_confirmation).to eq true end + + context 'with full vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:all_phone_vendor_outage?). + and_return(true) + end + + it 'redirects to review page' do + put :create, params: { idv_phone_form: { phone: good_phone } } + + expect(response).to redirect_to idv_phone_path + get :new + expect(response).to redirect_to idv_review_path + end + end end context 'when different phone from user phone' do - it 'redirects to otp page and does not set phone_confirmed_at' do + before do user = build( :user, :with_phone, with: { phone: '+1 (415) 555-0130', confirmed_at: Time.zone.now } ) stub_verify_steps_one_and_two(user) + end + it 'redirects to otp page and does not set phone_confirmed_at' do put :create, params: { idv_phone_form: { phone: good_phone } } expect(response).to redirect_to idv_phone_path @@ -231,6 +250,21 @@ expect(subject.idv_session.vendor_phone_confirmation).to eq true expect(subject.idv_session.user_phone_confirmation).to eq false end + + context 'with full vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:all_phone_vendor_outage?). + and_return(true) + end + + it 'redirects to vendor outage page' do + put :create, params: { idv_phone_form: { phone: good_phone } } + + expect(response).to redirect_to idv_phone_path + get :new + expect(response).to redirect_to vendor_outage_path(from: :idv_phone) + end + end end it 'tracks event with valid phone' do diff --git a/spec/controllers/users/phones_controller_spec.rb b/spec/controllers/users/phones_controller_spec.rb index 4f5457d911c..d673a85f5e4 100644 --- a/spec/controllers/users/phones_controller_spec.rb +++ b/spec/controllers/users/phones_controller_spec.rb @@ -3,19 +3,31 @@ describe Users::PhonesController do include Features::MailerHelper - context 'user adds phone' do - let(:user) { create(:user, :signed_up, with: { phone: '+1 (202) 555-1234' }) } - let(:new_phone) { '202-555-4321' } - before do - stub_sign_in(user) + let(:user) { create(:user, :signed_up, with: { phone: '+1 (202) 555-1234' }) } + before do + stub_sign_in(user) - stub_analytics - allow(@analytics).to receive(:track_event) - end + stub_analytics + allow(@analytics).to receive(:track_event) + end + context 'user adds phone' do it 'gives the user a form to enter a new phone number' do get :add + expect(response).to render_template(:add) end end + + context 'phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:all_phone_vendor_outage?).and_return(true) + end + + it 'redirects to outage page' do + get :add + + expect(response).to redirect_to vendor_outage_path(from: :users_phones) + end + end end diff --git a/spec/controllers/users/two_factor_authentication_controller_spec.rb b/spec/controllers/users/two_factor_authentication_controller_spec.rb index 77900d32631..3439a53b020 100644 --- a/spec/controllers/users/two_factor_authentication_controller_spec.rb +++ b/spec/controllers/users/two_factor_authentication_controller_spec.rb @@ -206,6 +206,20 @@ def index expect(response). to redirect_to login_two_factor_path(otp_delivery_preference: 'sms', reauthn: false) end + + context 'when no options are enabled and available for use' do + before do + allow_any_instance_of(VendorStatus).to receive(:any_phone_vendor_outage?).and_return(true) + end + + it 'redirects to mfa options page' do + stub_sign_in_before_2fa(create(:user, :with_phone, with: { phone: '+1 (703) 555-1212' })) + + get :show + + expect(response).to redirect_to login_two_factor_options_path + end + end end context 'when the user has not already set up 2FA' do @@ -217,6 +231,20 @@ def index end end + context 'when phone is sole configured mfa and full phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:all_phone_vendor_outage?).and_return(true) + end + + it 'redirects to vendor outage page' do + stub_sign_in_before_2fa(create(:user, :with_phone, with: { phone: '+1 (703) 555-1212' })) + + get :show + + expect(response).to redirect_to vendor_outage_path(from: :two_factor_authentication) + end + end + context 'when SP requires PIV/CAC' do let(:user) { create(:user, :signed_up) } diff --git a/spec/controllers/vendor_outage_controller_spec.rb b/spec/controllers/vendor_outage_controller_spec.rb index 1be584d7ae2..088b7b97af1 100644 --- a/spec/controllers/vendor_outage_controller_spec.rb +++ b/spec/controllers/vendor_outage_controller_spec.rb @@ -26,4 +26,24 @@ tracking_data, ) end + + it 'sets show_gpo_option view variable' do + get :show + + expect(assigns(:show_gpo_option)).to eq(false) + end + + context 'from idv phone' do + before { allow(controller).to receive(:from_idv_phone?).and_return(true) } + + context 'gpo letter available' do + before { allow(controller).to receive(:gpo_letter_available?).and_return(true) } + + it 'sets show_gpo_option as true' do + get :show + + expect(assigns(:show_gpo_option)).to eq(true) + end + end + end end diff --git a/spec/features/idv/vendor_outage_spec.rb b/spec/features/idv/vendor_outage_spec.rb index 189b693c1f3..853fc247011 100644 --- a/spec/features/idv/vendor_outage_spec.rb +++ b/spec/features/idv/vendor_outage_spec.rb @@ -22,7 +22,7 @@ click_submit_default expect(current_path).to eq vendor_outage_path expect(page).to have_content( - t('vendor_outage.idv_blocked.with_sp', service_provider: 'Test SP'), + t('vendor_outage.blocked.idv.with_sp', service_provider: 'Test SP'), ) end @@ -42,14 +42,14 @@ click_on t('forms.buttons.continue') expect(current_path).to eq vendor_outage_path - expect(page).to have_content(t('vendor_outage.idv_blocked.without_sp')) + expect(page).to have_content(t('vendor_outage.blocked.idv.without_sp')) end it 'prevents a user from creating an account' do visit_idp_from_sp_with_ial2(:oidc) click_link t('links.create_account') expect(current_path).to eq vendor_outage_path - expect(page).to have_content(t('vendor_outage.idv_blocked.generic')) + expect(page).to have_content(t('vendor_outage.blocked.idv.generic')) end end end diff --git a/spec/forms/new_phone_form_spec.rb b/spec/forms/new_phone_form_spec.rb index 2be9828bbb0..2f2d0b02c9f 100644 --- a/spec/forms/new_phone_form_spec.rb +++ b/spec/forms/new_phone_form_spec.rb @@ -319,6 +319,38 @@ end end + describe '#delivery_preference_sms?' do + it 'is true' do + expect(form.delivery_preference_sms?).to eq(true) + end + + context 'sms outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'is false' do + expect(form.delivery_preference_sms?).to eq(false) + end + end + end + + describe '#delivery_preference_voice?' do + it 'is false' do + expect(form.delivery_preference_voice?).to eq(false) + end + + context 'sms outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'is true' do + expect(form.delivery_preference_voice?).to eq(true) + end + end + end + describe '#redact' do it 'leaves in punctuation and spaces, but removes letters and numbers' do expect(form.send(:redact, '+11 (555) DEF-1234')).to eq('+## (###) XXX-####') diff --git a/spec/javascripts/packs/form-steps-wait-spec.js b/spec/javascripts/packs/form-steps-wait-spec.js index 3008fad1d1c..e495438ddc6 100644 --- a/spec/javascripts/packs/form-steps-wait-spec.js +++ b/spec/javascripts/packs/form-steps-wait-spec.js @@ -328,7 +328,15 @@ describe('FormStepsWait', () => { status: 200, redirected: true, url: redirect, - text: () => Promise.resolve(NON_POLL_PAGE_MARKUP), + text: () => + Promise.resolve( + `${NON_POLL_PAGE_MARKUP} + + + Error on redirected page is fine. + + `, + ), }); defineProperty(window, 'location', { value: { diff --git a/spec/presenters/two_factor_authentication/phone_selection_presenter_spec.rb b/spec/presenters/two_factor_authentication/phone_selection_presenter_spec.rb index f7f3579345c..39e97652dd2 100644 --- a/spec/presenters/two_factor_authentication/phone_selection_presenter_spec.rb +++ b/spec/presenters/two_factor_authentication/phone_selection_presenter_spec.rb @@ -36,4 +36,18 @@ end end end + + describe '#disabled?' do + let(:phone) { build(:phone_configuration, phone: '+1 888 867-5309') } + + it { expect(presenter.disabled?).to eq(false) } + + context 'all phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:all_phone_vendor_outage?).and_return(true) + end + + it { expect(presenter.disabled?).to eq(true) } + end + end end diff --git a/spec/presenters/two_factor_authentication/selection_presenter_spec.rb b/spec/presenters/two_factor_authentication/selection_presenter_spec.rb new file mode 100644 index 00000000000..076586a942d --- /dev/null +++ b/spec/presenters/two_factor_authentication/selection_presenter_spec.rb @@ -0,0 +1,9 @@ +require 'rails_helper' + +RSpec.describe TwoFactorAuthentication::SelectionPresenter do + subject(:presenter) { described_class.new } + + describe '#disabled?' do + it { expect(presenter.disabled?).to eq(false) } + end +end diff --git a/spec/presenters/two_factor_authentication/sms_selection_presenter_spec.rb b/spec/presenters/two_factor_authentication/sms_selection_presenter_spec.rb index 6fa41ca8b0d..da605f2da91 100644 --- a/spec/presenters/two_factor_authentication/sms_selection_presenter_spec.rb +++ b/spec/presenters/two_factor_authentication/sms_selection_presenter_spec.rb @@ -26,4 +26,18 @@ end end end + + describe '#disabled?' do + let(:phone) { build(:phone_configuration, phone: '+1 888 867-5309') } + + it { expect(subject.disabled?).to eq(false) } + + context 'sms vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it { expect(subject.disabled?).to eq(true) } + end + end end diff --git a/spec/presenters/two_factor_authentication/voice_selection_presenter_spec.rb b/spec/presenters/two_factor_authentication/voice_selection_presenter_spec.rb index 08328ccfc7a..2d484d95635 100644 --- a/spec/presenters/two_factor_authentication/voice_selection_presenter_spec.rb +++ b/spec/presenters/two_factor_authentication/voice_selection_presenter_spec.rb @@ -26,4 +26,19 @@ end end end + + describe '#disabled?' do + let(:phone) { build(:phone_configuration, phone: '+1 888 867-5309') } + + it { expect(subject.disabled?).to eq(false) } + + context 'voice vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:voice). + and_return(true) + end + + it { expect(subject.disabled?).to eq(true) } + end + end end diff --git a/spec/presenters/two_factor_login_options_presenter_spec.rb b/spec/presenters/two_factor_login_options_presenter_spec.rb index def9891e515..4e664fb878f 100644 --- a/spec/presenters/two_factor_login_options_presenter_spec.rb +++ b/spec/presenters/two_factor_login_options_presenter_spec.rb @@ -91,4 +91,34 @@ it { should eq account_path } end end + + describe '#first_enabled_option_index' do + subject(:index) { presenter.first_enabled_option_index } + + it 'returns first index' do + expect(index).to eq(0) + end + + context 'enabled options' do + before do + create(:phone_configuration, user: user, phone: '(202) 555-1111') + end + + it 'returns first enabled index' do + expect(index).to eq(0) + end + end + + context 'disabled options' do + before do + create(:phone_configuration, user: user, phone: '(202) 555-1111') + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'returns first enabled index' do + expect(index).to eq(1) + end + end + end end diff --git a/spec/services/vendor_status_spec.rb b/spec/services/vendor_status_spec.rb index d8ae19a2d4f..c11799cd425 100644 --- a/spec/services/vendor_status_spec.rb +++ b/spec/services/vendor_status_spec.rb @@ -56,7 +56,7 @@ let(:from) { SignUp::RegistrationsController::CREATE_ACCOUNT } it 'returns the correct message' do - expect(subject.outage_message).to eq I18n.t('vendor_outage.idv_blocked.generic') + expect(subject.outage_message).to eq I18n.t('vendor_outage.blocked.idv.generic') end end @@ -67,7 +67,7 @@ context 'no service_provider in session' do it 'returns the correct message' do expect(subject.outage_message).to eq( - I18n.t('vendor_outage.idv_blocked.without_sp'), + I18n.t('vendor_outage.blocked.idv.without_sp'), ) end end @@ -78,7 +78,7 @@ it 'returns the correct message tailored to the service provider' do expect(subject.outage_message).to eq( I18n.t( - 'vendor_outage.idv_blocked.with_sp', + 'vendor_outage.blocked.idv.with_sp', service_provider: sp.friendly_name, ), ) @@ -97,4 +97,88 @@ expect(subject.any_ial2_vendor_outage?).not_to be end end + + describe '#all_vendor_outage?' do + it { expect(subject.all_vendor_outage?).to eq(false) } + + context 'with outage on all vendors' do + before do + allow(vendor_status).to receive(:vendor_outage?).and_return(true) + end + + it { expect(subject.all_vendor_outage?).to eq(true) } + end + + context 'with parameters' do + let(:vendor) { :sms } + + it { expect(subject.all_vendor_outage?([vendor])).to eq(false) } + + context 'with outage on all vendors' do + before do + allow(vendor_status).to receive(:vendor_outage?).with(vendor).and_return(true) + end + + it { expect(subject.all_vendor_outage?([vendor])).to eq(true) } + end + end + end + + describe '#any_phone_vendor_outage?' do + it { expect(subject.any_phone_vendor_outage?).to eq(false) } + + context 'with outage on a phone vendor' do + before do + allow(vendor_status).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it { expect(subject.any_phone_vendor_outage?).to eq(true) } + end + end + + describe '#all_phone_vendor_outage?' do + it { expect(subject.all_phone_vendor_outage?).to eq(false) } + + context 'with outage on a phone vendor' do + before do + allow(vendor_status).to receive(:vendor_outage?).and_return(false) + allow(vendor_status).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it { expect(subject.all_phone_vendor_outage?).to eq(false) } + end + + context 'with outage on all phone vendors' do + before do + allow(vendor_status).to receive(:vendor_outage?).and_return(true) + end + + it { expect(subject.all_phone_vendor_outage?).to eq(true) } + end + end + + describe '#outage_message' do + subject(:outage_message) { vendor_status.outage_message } + + context 'phone vendor outage' do + before do + allow(vendor_status).to receive(:vendor_outage?).and_return(false) + VendorStatus::PHONE_VENDORS.each do |vendor| + allow(vendor_status).to receive(:vendor_outage?).with(vendor).and_return(true) + end + end + + it 'returns default phone outage message' do + expect(outage_message).to eq(t('vendor_outage.blocked.phone.default')) + end + + context 'from idv' do + let(:from_idv) { true } + + it 'returns idv phone outage message' do + expect(outage_message).to eq(t('vendor_outage.blocked.phone.idv')) + end + end + end + end end diff --git a/spec/views/idv/doc_auth/welcome.html.erb_spec.rb b/spec/views/idv/doc_auth/welcome.html.erb_spec.rb index 25093f8d471..1e01a9010c4 100644 --- a/spec/views/idv/doc_auth/welcome.html.erb_spec.rb +++ b/spec/views/idv/doc_auth/welcome.html.erb_spec.rb @@ -106,4 +106,16 @@ ) end end + + context 'phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:all_vendor_outage?).and_return(true) + end + + it 'renders alert banner' do + render template: 'idv/doc_auth/welcome' + + expect(rendered).to have_selector('.usa-alert.usa-alert--error') + end + end end diff --git a/spec/views/idv/otp_delivery_method/new.html.erb_spec.rb b/spec/views/idv/otp_delivery_method/new.html.erb_spec.rb index 17d376bba99..de831c6ec3d 100644 --- a/spec/views/idv/otp_delivery_method/new.html.erb_spec.rb +++ b/spec/views/idv/otp_delivery_method/new.html.erb_spec.rb @@ -28,4 +28,20 @@ expect(rendered).not_to have_link(t('idv.troubleshooting.options.verify_by_mail')) end end + + context 'phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'renders alert banner' do + expect(rendered).to have_selector('.usa-alert.usa-alert--error') + end + + it 'disables problematic vendor option' do + expect(rendered).to have_field('otp_delivery_preference', with: :voice, disabled: false) + expect(rendered).to have_field('otp_delivery_preference', with: :sms, disabled: true) + end + end end diff --git a/spec/views/phone_setup/index.html.erb_spec.rb b/spec/views/phone_setup/index.html.erb_spec.rb index 670727232c2..c8fd92fc000 100644 --- a/spec/views/phone_setup/index.html.erb_spec.rb +++ b/spec/views/phone_setup/index.html.erb_spec.rb @@ -52,4 +52,15 @@ end end end + + context 'phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'renders alert banner' do + expect(render).to have_selector('.usa-alert.usa-alert--error') + end + end end diff --git a/spec/views/two_factor_authentication/options/index.html.erb_spec.rb b/spec/views/two_factor_authentication/options/index.html.erb_spec.rb index 1fd851310b9..3a879654108 100644 --- a/spec/views/two_factor_authentication/options/index.html.erb_spec.rb +++ b/spec/views/two_factor_authentication/options/index.html.erb_spec.rb @@ -37,4 +37,31 @@ expect(rendered).to have_link(t('links.cancel_account_creation'), href: sign_up_cancel_path) end + + context 'phone vendor outage' do + before do + create(:phone_configuration, user: user, phone: '(202) 555-1111') + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + + render + end + + it 'renders alert banner' do + expect(rendered).to have_selector('.usa-alert.usa-alert--error') + end + + it 'disables problematic vendor option' do + expect(rendered).to have_checked_field( + 'two_factor_options_form[selection]', + with: :voice, + disabled: false, + ) + expect(rendered).to have_field( + 'two_factor_options_form[selection]', + with: :sms, + disabled: true, + ) + end + end end diff --git a/spec/views/users/phones/add.html.erb_spec.rb b/spec/views/users/phones/add.html.erb_spec.rb new file mode 100644 index 00000000000..aead0b19307 --- /dev/null +++ b/spec/views/users/phones/add.html.erb_spec.rb @@ -0,0 +1,23 @@ +require 'rails_helper' + +describe 'users/phones/add.html.erb' do + include Devise::Test::ControllerHelpers + + subject(:rendered) { render } + + before do + user = build_stubbed(:user) + @new_phone_form = NewPhoneForm.new(user) + end + + context 'phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'renders alert banner' do + expect(rendered).to have_selector('.usa-alert.usa-alert--error') + end + end +end diff --git a/spec/views/users/shared/_otp_delivery_preference_selection.html.erb_spec.rb b/spec/views/users/shared/_otp_delivery_preference_selection.html.erb_spec.rb new file mode 100644 index 00000000000..8bc86936219 --- /dev/null +++ b/spec/views/users/shared/_otp_delivery_preference_selection.html.erb_spec.rb @@ -0,0 +1,39 @@ +require 'rails_helper' + +describe 'users/shared/_otp_delivery_preference_selection.html.erb' do + let(:user) { build_stubbed(:user) } + + subject(:rendered) do + render 'users/shared/otp_delivery_preference_selection', form_obj: NewPhoneForm.new(user) + end + + it 'renders enabled sms option' do + expect(rendered).to have_field('new_phone_form_otp_delivery_preference_sms', disabled: false) + end + + context 'sms vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'renders disabled sms option' do + expect(rendered).to have_field('new_phone_form_otp_delivery_preference_sms', disabled: true) + end + end + + it 'renders enabled voice option' do + expect(rendered).to have_field('new_phone_form_otp_delivery_preference_voice', disabled: false) + end + + context 'voice vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:voice).and_return(true) + end + + it 'renders disabled voice option' do + expect(rendered).to have_field('new_phone_form_otp_delivery_preference_voice', disabled: true) + end + end +end diff --git a/spec/views/users/two_factor_authentication_setup/index.html.erb_spec.rb b/spec/views/users/two_factor_authentication_setup/index.html.erb_spec.rb new file mode 100644 index 00000000000..74c3d19477d --- /dev/null +++ b/spec/views/users/two_factor_authentication_setup/index.html.erb_spec.rb @@ -0,0 +1,51 @@ +require 'rails_helper' + +describe 'users/two_factor_authentication_setup/index.html.erb' do + include Devise::Test::ControllerHelpers + + subject(:rendered) { render } + + before do + user = build_stubbed(:user) + @presenter = TwoFactorOptionsPresenter.new(user_agent: '') + @two_factor_options_form = TwoFactorLoginOptionsForm.new(user) + end + + context 'all phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:all_vendor_outage?). + with(VendorStatus::PHONE_VENDORS).and_return(true) + end + + it 'renders alert banner' do + expect(rendered).to have_selector('.usa-alert.usa-alert--error') + end + + it 'disables phone option' do + expect(rendered).to have_field( + 'two_factor_options_form[selection]', + with: :phone, + disabled: true, + ) + end + end + + context 'single phone vendor outage' do + before do + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).and_return(false) + allow_any_instance_of(VendorStatus).to receive(:vendor_outage?).with(:sms).and_return(true) + end + + it 'does not render alert banner' do + expect(rendered).to_not have_selector('.usa-alert.usa-alert--error') + end + + it 'does not disable phone option' do + expect(rendered).to have_field( + 'two_factor_options_form[selection]', + with: :phone, + disabled: false, + ) + end + end +end diff --git a/spec/views/vendor_outage/show.html.erb_spec.rb b/spec/views/vendor_outage/show.html.erb_spec.rb new file mode 100644 index 00000000000..1a479a63f7e --- /dev/null +++ b/spec/views/vendor_outage/show.html.erb_spec.rb @@ -0,0 +1,23 @@ +require 'rails_helper' + +describe 'vendor_outage/show.html.erb' do + let(:show_gpo_option) { false } + + subject(:rendered) { render } + + before do + @show_gpo_option = show_gpo_option + end + + it 'does not render gpo option' do + expect(rendered).not_to have_link(t('idv.troubleshooting.options.verify_by_mail')) + end + + context 'gpo option shown' do + let(:show_gpo_option) { true } + + it 'renders gpo option' do + expect(rendered).to have_link(t('idv.troubleshooting.options.verify_by_mail')) + end + end +end
<%= @specific_message %>
Error on redirected page is fine.