From 1472ff41c29e76415514b4227b9164e175a4f82c Mon Sep 17 00:00:00 2001 From: Steve Urciuoli Date: Thu, 17 Oct 2019 22:30:56 -0500 Subject: [PATCH 1/7] LG-1957 Remove decorative image alt tags --- app/views/account_reset/confirm_request/show.html.erb | 2 +- app/views/accounts/show.html.erb | 10 +++++----- app/views/forgot_password/show.html.erb | 2 +- app/views/idv/usps/index.html.erb | 2 +- app/views/users/emails/verify.html.erb | 2 +- app/views/users/phone_setup/index.html.erb | 2 +- 6 files changed, 10 insertions(+), 10 deletions(-) diff --git a/app/views/account_reset/confirm_request/show.html.erb b/app/views/account_reset/confirm_request/show.html.erb index 325c335500c..fcc4f99ea58 100644 --- a/app/views/account_reset/confirm_request/show.html.erb +++ b/app/views/account_reset/confirm_request/show.html.erb @@ -1,7 +1,7 @@ <% title t('account_reset.confirm_request.check_your_email') %>
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %>

<%= t('headings.verify_email') %>

diff --git a/app/views/accounts/show.html.erb b/app/views/accounts/show.html.erb index 402aea2397b..449c4c508ff 100644 --- a/app/views/accounts/show.html.erb +++ b/app/views/accounts/show.html.erb @@ -15,7 +15,7 @@
<%= t('account.index.login') %> - <%= image_tag asset_url('sign-in.svg'), width: 12, class: 'ml1' %> + <%= image_tag asset_url('sign-in.svg'), width: 12, class: 'ml1', alt: '' %>
<%= render 'emails' %> <%= render 'account_item', @@ -28,7 +28,7 @@
<%= t('headings.account.two_factor') %> - <%= image_tag asset_url('2fa-account.svg'), width: 8, class: 'ml1' %> + <%= image_tag asset_url('2fa-account.svg'), width: 8, class: 'ml1', alt: '' %>
<% if TwoFactorAuthentication::PhonePolicy.new(current_user).visible? %> @@ -62,7 +62,7 @@
<%= t('headings.account.connected_apps') %> - <%= image_tag asset_url('connected_apps.png'), width: 12, class: 'ml1' %> + <%= image_tag asset_url('connected_apps.png'), width: 12, class: 'ml1', alt: '' %>
<% @view_model.connected_apps.each do |identity| %> <%= render identity.connected_app_partial, identity: identity %> @@ -71,7 +71,7 @@
<%= t('headings.account.devices') %> - <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1' %> + <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1', alt: '' %>
<% @view_model.recent_devices.each do |device| %> <%= render device.device_partial, device: device %> @@ -80,7 +80,7 @@
<%= t('headings.account.account_history') %> - <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1' %> + <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1', alt: '' %>
<% @view_model.recent_events.each do |event| %> <%= render event.event_partial, event: event %> diff --git a/app/views/forgot_password/show.html.erb b/app/views/forgot_password/show.html.erb index 22bf97edcb8..6214c7f6b0b 100644 --- a/app/views/forgot_password/show.html.erb +++ b/app/views/forgot_password/show.html.erb @@ -8,7 +8,7 @@ <% end %>
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %>

<%= t('headings.verify_email') %>

diff --git a/app/views/idv/usps/index.html.erb b/app/views/idv/usps/index.html.erb index 9d6a8c18146..b768ec5068a 100644 --- a/app/views/idv/usps/index.html.erb +++ b/app/views/idv/usps/index.html.erb @@ -1,5 +1,5 @@
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %>

<%= @presenter.title %>

diff --git a/app/views/users/emails/verify.html.erb b/app/views/users/emails/verify.html.erb index 73b0b1fe781..9fb85d552e3 100644 --- a/app/views/users/emails/verify.html.erb +++ b/app/views/users/emails/verify.html.erb @@ -5,7 +5,7 @@ <% end %>
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %>

<%= t('headings.verify_email') %>

diff --git a/app/views/users/phone_setup/index.html.erb b/app/views/users/phone_setup/index.html.erb index e05a3510acf..a2fcf05cec1 100644 --- a/app/views/users/phone_setup/index.html.erb +++ b/app/views/users/phone_setup/index.html.erb @@ -1,5 +1,5 @@ <% title t('titles.phone_setup') %> -<%= image_tag asset_url('2FA-voice.svg'), width: 200, class: 'mb2' %> +<%= image_tag asset_url('2FA-voice.svg'), width: 200, class: 'mb2', alt: '' %>
<%= t('sign_up.current_step', step: @presenter.step) %>

From ece580d5fdf00f23a258a60c411db662b209e287 Mon Sep 17 00:00:00 2001 From: Steve Urciuoli Date: Thu, 17 Oct 2019 22:56:27 -0500 Subject: [PATCH 2/7] Patch --- app/views/account_reset/confirm_request/show.html.erb | 2 +- app/views/accounts/show.html.erb | 10 +++++----- app/views/forgot_password/show.html.erb | 2 +- app/views/idv/usps/index.html.erb | 2 +- app/views/users/emails/verify.html.erb | 2 +- app/views/users/phone_setup/index.html.erb | 2 +- config/initializers/asset_tag_helper_patch.rb | 5 +++++ 7 files changed, 15 insertions(+), 10 deletions(-) create mode 100644 config/initializers/asset_tag_helper_patch.rb diff --git a/app/views/account_reset/confirm_request/show.html.erb b/app/views/account_reset/confirm_request/show.html.erb index fcc4f99ea58..325c335500c 100644 --- a/app/views/account_reset/confirm_request/show.html.erb +++ b/app/views/account_reset/confirm_request/show.html.erb @@ -1,7 +1,7 @@ <% title t('account_reset.confirm_request.check_your_email') %>
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %>

<%= t('headings.verify_email') %>

diff --git a/app/views/accounts/show.html.erb b/app/views/accounts/show.html.erb index 449c4c508ff..402aea2397b 100644 --- a/app/views/accounts/show.html.erb +++ b/app/views/accounts/show.html.erb @@ -15,7 +15,7 @@
<%= t('account.index.login') %> - <%= image_tag asset_url('sign-in.svg'), width: 12, class: 'ml1', alt: '' %> + <%= image_tag asset_url('sign-in.svg'), width: 12, class: 'ml1' %>
<%= render 'emails' %> <%= render 'account_item', @@ -28,7 +28,7 @@
<%= t('headings.account.two_factor') %> - <%= image_tag asset_url('2fa-account.svg'), width: 8, class: 'ml1', alt: '' %> + <%= image_tag asset_url('2fa-account.svg'), width: 8, class: 'ml1' %>
<% if TwoFactorAuthentication::PhonePolicy.new(current_user).visible? %> @@ -62,7 +62,7 @@
<%= t('headings.account.connected_apps') %> - <%= image_tag asset_url('connected_apps.png'), width: 12, class: 'ml1', alt: '' %> + <%= image_tag asset_url('connected_apps.png'), width: 12, class: 'ml1' %>
<% @view_model.connected_apps.each do |identity| %> <%= render identity.connected_app_partial, identity: identity %> @@ -71,7 +71,7 @@
<%= t('headings.account.devices') %> - <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1', alt: '' %> + <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1' %>
<% @view_model.recent_devices.each do |device| %> <%= render device.device_partial, device: device %> @@ -80,7 +80,7 @@
<%= t('headings.account.account_history') %> - <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1', alt: '' %> + <%= image_tag asset_url('history.svg'), width: 12, class: 'ml1' %>
<% @view_model.recent_events.each do |event| %> <%= render event.event_partial, event: event %> diff --git a/app/views/forgot_password/show.html.erb b/app/views/forgot_password/show.html.erb index 6214c7f6b0b..22bf97edcb8 100644 --- a/app/views/forgot_password/show.html.erb +++ b/app/views/forgot_password/show.html.erb @@ -8,7 +8,7 @@ <% end %>
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %>

<%= t('headings.verify_email') %>

diff --git a/app/views/idv/usps/index.html.erb b/app/views/idv/usps/index.html.erb index b768ec5068a..9d6a8c18146 100644 --- a/app/views/idv/usps/index.html.erb +++ b/app/views/idv/usps/index.html.erb @@ -1,5 +1,5 @@
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %>

<%= @presenter.title %>

diff --git a/app/views/users/emails/verify.html.erb b/app/views/users/emails/verify.html.erb index 9fb85d552e3..73b0b1fe781 100644 --- a/app/views/users/emails/verify.html.erb +++ b/app/views/users/emails/verify.html.erb @@ -5,7 +5,7 @@ <% end %>
- <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading', alt: '' %> + <%= image_tag asset_url('check-email.svg'), width: 24, class: 'left-0 right-0 ico-heading' %>

<%= t('headings.verify_email') %>

diff --git a/app/views/users/phone_setup/index.html.erb b/app/views/users/phone_setup/index.html.erb index a2fcf05cec1..e05a3510acf 100644 --- a/app/views/users/phone_setup/index.html.erb +++ b/app/views/users/phone_setup/index.html.erb @@ -1,5 +1,5 @@ <% title t('titles.phone_setup') %> -<%= image_tag asset_url('2FA-voice.svg'), width: 200, class: 'mb2', alt: '' %> +<%= image_tag asset_url('2FA-voice.svg'), width: 200, class: 'mb2' %>
<%= t('sign_up.current_step', step: @presenter.step) %>

diff --git a/config/initializers/asset_tag_helper_patch.rb b/config/initializers/asset_tag_helper_patch.rb new file mode 100644 index 00000000000..c6c955ce187 --- /dev/null +++ b/config/initializers/asset_tag_helper_patch.rb @@ -0,0 +1,5 @@ +module ActionView::Helpers::AssetTagHelper + def image_alt(src) + '' + end +end From 2ef8ee1b09d3ff15d46b9e0f70920f366ec15c36 Mon Sep 17 00:00:00 2001 From: Steve Urciuoli Date: Thu, 17 Oct 2019 23:05:23 -0500 Subject: [PATCH 3/7] Fix --- config/initializers/asset_tag_helper_patch.rb | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/config/initializers/asset_tag_helper_patch.rb b/config/initializers/asset_tag_helper_patch.rb index c6c955ce187..bc125d1ed61 100644 --- a/config/initializers/asset_tag_helper_patch.rb +++ b/config/initializers/asset_tag_helper_patch.rb @@ -1,5 +1,9 @@ -module ActionView::Helpers::AssetTagHelper - def image_alt(src) - '' +module ActionView + module Helpers + module AssetTagHelper + def image_alt(_src) + '' + end + end end end From 0586e7789da3a74b22a09a1a471c907337c51140 Mon Sep 17 00:00:00 2001 From: Steve Urciuoli Date: Fri, 18 Oct 2019 12:40:10 -0500 Subject: [PATCH 4/7] The rest --- app/views/account_reset/recover/email_sent.html.slim | 3 +-- app/views/idv/cac/success.html.slim | 3 +-- app/views/idv/capture_doc/capture_complete.html.slim | 6 ++---- app/views/idv/come_back_later/show.html.slim | 2 +- app/views/idv/doc_auth/_back_of_state_id_image.slim | 3 +-- app/views/idv/doc_auth/_front_of_state_id_image.slim | 3 +-- app/views/idv/doc_auth/doc_success.html.slim | 3 +-- app/views/idv/doc_auth/email_sent.html.slim | 3 +-- app/views/idv/doc_auth/recover.html.slim | 3 +-- app/views/idv/doc_auth/recover_fail.html.slim | 3 +-- app/views/idv/in_person/bar_code.html.slim | 3 +-- app/views/idv/jurisdiction/new.html.erb | 4 +--- app/views/idv/sessions/success.html.slim | 3 +-- app/views/layouts/user_mailer.html.slim | 1 - app/views/users/backup_code_setup/edit.html.slim | 3 +-- app/views/users/totp_setup/new.html.slim | 2 +- .../users/two_factor_authentication_setup/success.html.erb | 2 +- app/views/users/webauthn_setup/delete.html.slim | 3 +-- 18 files changed, 18 insertions(+), 35 deletions(-) diff --git a/app/views/account_reset/recover/email_sent.html.slim b/app/views/account_reset/recover/email_sent.html.slim index 0a772b4ff52..1729774812c 100644 --- a/app/views/account_reset/recover/email_sent.html.slim +++ b/app/views/account_reset/recover/email_sent.html.slim @@ -1,6 +1,5 @@ - title t('doc_auth.titles.doc_auth') -= image_tag(asset_url('check-email.svg'), - alt: t('idv.titles.session.success'), width: 96) += image_tag(asset_url('check-email.svg'), width: 96) h1.h3.mb2.mt3.my0 = t('recover.request.email_sent', email: current_user.email) diff --git a/app/views/idv/cac/success.html.slim b/app/views/idv/cac/success.html.slim index 6fd9c345ad3..8eb83846969 100644 --- a/app/views/idv/cac/success.html.slim +++ b/app/views/idv/cac/success.html.slim @@ -2,8 +2,7 @@ h5.my1.caps.bold.accent-blue = t('cac_proofing.step', step: 2) -= image_tag(asset_url('state-id-confirm@3x.png'), - alt: t('idv.titles.session.success'), width: 210) += image_tag(asset_url('state-id-confirm@3x.png'), width: 210) h1.h3.mb2.mt3.my0 = t('cac_proofing.headings.success') diff --git a/app/views/idv/capture_doc/capture_complete.html.slim b/app/views/idv/capture_doc/capture_complete.html.slim index 6fe72c0faf0..43245e4a9c4 100644 --- a/app/views/idv/capture_doc/capture_complete.html.slim +++ b/app/views/idv/capture_doc/capture_complete.html.slim @@ -1,10 +1,8 @@ - title t('doc_auth.titles.doc_auth') -= image_tag(asset_url('alert/success.svg'), - alt: t('forms.webauthn_setup.success_title'), width: 60) += image_tag(asset_url('alert/success.svg'), width: 60) h1.h2.mb2.mt3.my0 = t('doc_auth.headings.capture_complete') hr h1.h2.mb2.mt3.my0 = t('doc_auth.instructions.switch_back') -= image_tag(asset_url('idv/switch.png'), - alt: t('forms.webauthn_setup.success_title'), width: 193) += image_tag(asset_url('idv/switch.png'), width: 193) diff --git a/app/views/idv/come_back_later/show.html.slim b/app/views/idv/come_back_later/show.html.slim index b4f1bbdf407..d1574173e93 100644 --- a/app/views/idv/come_back_later/show.html.slim +++ b/app/views/idv/come_back_later/show.html.slim @@ -1,5 +1,5 @@ = image_tag(asset_url('come-back.svg'), - size: '140', alt: t('idv.titles.come_back_later'), class: 'block mx-auto') + size: '140', class: 'block mx-auto') h2.center = t('idv.titles.come_back_later') .mt2.p3.col-12.center.border-box.border.border-teal.rounded-xl p diff --git a/app/views/idv/doc_auth/_back_of_state_id_image.slim b/app/views/idv/doc_auth/_back_of_state_id_image.slim index 47e080aaf75..2ec8f120c48 100644 --- a/app/views/idv/doc_auth/_back_of_state_id_image.slim +++ b/app/views/idv/doc_auth/_back_of_state_id_image.slim @@ -1,4 +1,3 @@ -= image_tag(asset_url('state-id-back.svg'), - alt: t('doc_auth.headings.upload_back'), height: 140) += image_tag(asset_url('state-id-back.svg'), height: 140) br br diff --git a/app/views/idv/doc_auth/_front_of_state_id_image.slim b/app/views/idv/doc_auth/_front_of_state_id_image.slim index 7d819fd2c57..ac11e1895c5 100644 --- a/app/views/idv/doc_auth/_front_of_state_id_image.slim +++ b/app/views/idv/doc_auth/_front_of_state_id_image.slim @@ -1,4 +1,3 @@ -= image_tag(asset_url('state-id-front.svg'), - alt: t('doc_auth.headings.upload_front'), height: 140) += image_tag(asset_url('state-id-front.svg'), height: 140) br br diff --git a/app/views/idv/doc_auth/doc_success.html.slim b/app/views/idv/doc_auth/doc_success.html.slim index da7a8110343..2f75c2a402d 100644 --- a/app/views/idv/doc_auth/doc_success.html.slim +++ b/app/views/idv/doc_auth/doc_success.html.slim @@ -1,7 +1,6 @@ - title t('doc_auth.titles.doc_auth') -= image_tag(asset_url('state-id-confirm@3x.png'), - alt: t('idv.titles.session.success'), width: 210) += image_tag(asset_url('state-id-confirm@3x.png'), width: 210) h1.h3.mb2.mt3.my0 = t('doc_auth.forms.doc_success') diff --git a/app/views/idv/doc_auth/email_sent.html.slim b/app/views/idv/doc_auth/email_sent.html.slim index dc420130457..baaee31caa6 100644 --- a/app/views/idv/doc_auth/email_sent.html.slim +++ b/app/views/idv/doc_auth/email_sent.html.slim @@ -1,7 +1,6 @@ - title t('doc_auth.titles.doc_auth') -= image_tag(asset_url('state-id-confirm@3x.png'), - alt: t('idv.titles.session.success'), width: 210) += image_tag(asset_url('state-id-confirm@3x.png'), width: 210) h1.h3.mb2.mt3.my0 = t('doc_auth.instructions.email_sent', email: current_user.email) diff --git a/app/views/idv/doc_auth/recover.html.slim b/app/views/idv/doc_auth/recover.html.slim index b8ade3ccbd5..10689a9cfdb 100644 --- a/app/views/idv/doc_auth/recover.html.slim +++ b/app/views/idv/doc_auth/recover.html.slim @@ -1,7 +1,6 @@ - title t('doc_auth.titles.doc_auth') -= image_tag(asset_url('alert/success.svg'), - alt: t('forms.webauthn_setup.success_title'), width: 60) += image_tag(asset_url('alert/success.svg'), width: 60) h1.h1.mb2.mt3.my0 = t('recover.reverify.email_confirmed') hr diff --git a/app/views/idv/doc_auth/recover_fail.html.slim b/app/views/idv/doc_auth/recover_fail.html.slim index 2f15975ad0c..ca1fe1cfc1e 100644 --- a/app/views/idv/doc_auth/recover_fail.html.slim +++ b/app/views/idv/doc_auth/recover_fail.html.slim @@ -1,7 +1,6 @@ - title t('doc_auth.titles.doc_auth') -= image_tag(asset_url('alert/success.svg'), - alt: t('forms.webauthn_setup.success_title'), width: 60) += image_tag(asset_url('alert/success.svg'), width: 60) h1.h2.mb2.mt3.my0 = t('recover.reverify.fail') diff --git a/app/views/idv/in_person/bar_code.html.slim b/app/views/idv/in_person/bar_code.html.slim index 183cc25d389..c0f4cf1608c 100644 --- a/app/views/idv/in_person/bar_code.html.slim +++ b/app/views/idv/in_person/bar_code.html.slim @@ -24,8 +24,7 @@ p.mt-tiny.mb3 == t('in_person_proofing.info.enrollment_form') table.pl4.pr3.monospace tr td.center - = image_tag(asset_url('idv/bar_code.png'), - alt: t('doc_auth.headings.upload_back'), height: 140) + = image_tag(asset_url('idv/bar_code.png'), height: 140) br br .center.mt1 diff --git a/app/views/idv/jurisdiction/new.html.erb b/app/views/idv/jurisdiction/new.html.erb index 1bc15a72ee3..4166472a3e4 100644 --- a/app/views/idv/jurisdiction/new.html.erb +++ b/app/views/idv/jurisdiction/new.html.erb @@ -1,7 +1,5 @@ <% title t('idv.titles.jurisdiction') %> -<%= image_tag(asset_url('state-id-none@3x.png'), - alt: t('idv.titles.jurisdiction'), - width: 210) %> +<%= image_tag(asset_url('state-id-none@3x.png'), width: 210) %>

<%= t('idv.messages.jurisdiction.why') %>

diff --git a/app/views/idv/sessions/success.html.slim b/app/views/idv/sessions/success.html.slim index f3235ae166e..af45c59e4a7 100644 --- a/app/views/idv/sessions/success.html.slim +++ b/app/views/idv/sessions/success.html.slim @@ -1,7 +1,6 @@ - title t('idv.titles.session.success') -= image_tag(asset_url('state-id-confirm@3x.png'), - alt: t('idv.titles.session.success'), width: 210) += image_tag(asset_url('state-id-confirm@3x.png'), width: 210) h1.h3.mb2.mt3.my0 = t('idv.titles.session.success') diff --git a/app/views/layouts/user_mailer.html.slim b/app/views/layouts/user_mailer.html.slim index ad3ada9fdda..69a70c5fb03 100644 --- a/app/views/layouts/user_mailer.html.slim +++ b/app/views/layouts/user_mailer.html.slim @@ -34,7 +34,6 @@ html xmlns="http://www.w3.org/1999/xhtml" tr th = image_tag(attachments['logo.png'].url, - alt: t('mailer.sent_from', app: APP_NAME), size: '142x19', style: 'width: 142px; height: 19px;') th.expander diff --git a/app/views/users/backup_code_setup/edit.html.slim b/app/views/users/backup_code_setup/edit.html.slim index 68a8926bd2c..52aedff21af 100644 --- a/app/views/users/backup_code_setup/edit.html.slim +++ b/app/views/users/backup_code_setup/edit.html.slim @@ -1,7 +1,6 @@ - title t('forms.backup_code_regenerate.confirm') -= image_tag(asset_url('alert/warning-lg.svg'), - alt: t('forms.backup_code_regenerate.confirm'), width: 54) += image_tag(asset_url('alert/warning-lg.svg'), width: 54) h1.h3.mb1.mt3.my0 = t('forms.backup_code_regenerate.confirm') diff --git a/app/views/users/totp_setup/new.html.slim b/app/views/users/totp_setup/new.html.slim index 4fc2051105c..3a1ca2a2e75 100644 --- a/app/views/users/totp_setup/new.html.slim +++ b/app/views/users/totp_setup/new.html.slim @@ -27,7 +27,7 @@ ul.list-reset = accordion('totp-info', t('instructions.mfa.authenticator.accordion_header'), wrapper_css: 'mb2 col-12 fs-16p') do .center - = image_tag @qrcode, alt: t('users.totp_setup.new.qr_img_alt'), skip_pipeline: true + = image_tag @qrcode, skip_pipeline: true li.py2.border-top .mb2 .mr1.inline-block.circle.circle-number.bg-blue.white diff --git a/app/views/users/two_factor_authentication_setup/success.html.erb b/app/views/users/two_factor_authentication_setup/success.html.erb index 400e130c2c8..590565a5451 100644 --- a/app/views/users/two_factor_authentication_setup/success.html.erb +++ b/app/views/users/two_factor_authentication_setup/success.html.erb @@ -1,6 +1,6 @@ <% title t('titles.two_factor_setup_success') %> -<%= image_tag asset_url('alert/success.svg'), alt: t('headings.mfa_success'), width: 90 %> +<%= image_tag asset_url('alert/success.svg'), width: 90 %>

<%= t('headings.mfa_success', method: @presenter.first_mfa_enabled) %>

diff --git a/app/views/users/webauthn_setup/delete.html.slim b/app/views/users/webauthn_setup/delete.html.slim index 4706f92e2d6..9d28c0e3a27 100644 --- a/app/views/users/webauthn_setup/delete.html.slim +++ b/app/views/users/webauthn_setup/delete.html.slim @@ -1,7 +1,6 @@ - title t('forms.webauthn_delete.confirm') -= image_tag(asset_url('alert/warning-lg.svg'), - alt: t('forms.webauthn_delete.confirm'), width: 54) += image_tag(asset_url('alert/warning-lg.svg'), width: 54) h1.h3.mb1.mt3.my0 = t('forms.webauthn_delete.confirm') From 3a3ebf2a83116f94c190bf322282656542027b71 Mon Sep 17 00:00:00 2001 From: Steve Urciuoli Date: Fri, 18 Oct 2019 12:42:52 -0500 Subject: [PATCH 5/7] Last one --- app/views/shared/_failure.html.erb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/views/shared/_failure.html.erb b/app/views/shared/_failure.html.erb index f8df78f3ca6..d7e1b1badd4 100644 --- a/app/views/shared/_failure.html.erb +++ b/app/views/shared/_failure.html.erb @@ -1,7 +1,6 @@ <% title presenter.title %> -<%= image_tag(asset_url(presenter.state_icon), - alt: presenter.state_alt_text, width: 54) %> +<%= image_tag(asset_url(presenter.state_icon), width: 54) %>

<%= presenter.header %> From 193758d467614f1e1cc08f94f8f6eec2532908a0 Mon Sep 17 00:00:00 2001 From: Steve Urciuoli Date: Fri, 18 Oct 2019 13:09:29 -0500 Subject: [PATCH 6/7] Fix unused --- config/locales/forms/en.yml | 1 - config/locales/forms/es.yml | 1 - config/locales/forms/fr.yml | 1 - config/locales/mailer/en.yml | 1 - config/locales/mailer/es.yml | 2 +- config/locales/mailer/fr.yml | 1 - config/locales/users/en.yml | 3 --- config/locales/users/es.yml | 3 --- config/locales/users/fr.yml | 3 --- 9 files changed, 1 insertion(+), 15 deletions(-) diff --git a/config/locales/forms/en.yml b/config/locales/forms/en.yml index 48e03fda8b4..f6d9056bd56 100644 --- a/config/locales/forms/en.yml +++ b/config/locales/forms/en.yml @@ -142,4 +142,3 @@ en: keys as you want, and we recommend at least two for easier account recovery. login_text: Press the button on your security key to sign in with login.gov nickname: Security key nickname - success_title: You have added a security key as your authentication method diff --git a/config/locales/forms/es.yml b/config/locales/forms/es.yml index 60d6cc2d636..4fa16300e50 100644 --- a/config/locales/forms/es.yml +++ b/config/locales/forms/es.yml @@ -152,4 +152,3 @@ es: login_text: Presione el botón en su clave de seguridad para iniciar sesión con login.gov nickname: Apodo clave de seguridad - success_title: Has añadido una clave de seguridad como tu método de autenticación. diff --git a/config/locales/forms/fr.yml b/config/locales/forms/fr.yml index 34b54b3a432..ff2d73b29d0 100644 --- a/config/locales/forms/fr.yml +++ b/config/locales/forms/fr.yml @@ -158,4 +158,3 @@ fr: login_text: Appuyez sur le bouton de votre clé de sécurité pour vous connecter avec login.gov nickname: Pseudo clé de sécurité - success_title: Vous avez ajouté une clé de sécurité comme méthode d'authentification. diff --git a/config/locales/mailer/en.yml b/config/locales/mailer/en.yml index d7d44321123..0747af144cf 100644 --- a/config/locales/mailer/en.yml +++ b/config/locales/mailer/en.yml @@ -7,4 +7,3 @@ en: help: If you need help, visit %{link} no_reply: Please do not reply to this message. privacy_policy: Privacy policy - sent_from: Sent from %{app} diff --git a/config/locales/mailer/es.yml b/config/locales/mailer/es.yml index 5fd7d981fb5..26115439454 100644 --- a/config/locales/mailer/es.yml +++ b/config/locales/mailer/es.yml @@ -7,4 +7,4 @@ es: help: Si necesita ayuda, visite %{link} no_reply: Por favor, no responda a este mensaje. privacy_policy: Póliza de privacidad - sent_from: Enviado desde %{app} + diff --git a/config/locales/mailer/fr.yml b/config/locales/mailer/fr.yml index bba51228504..fec9b6ac8e3 100644 --- a/config/locales/mailer/fr.yml +++ b/config/locales/mailer/fr.yml @@ -7,4 +7,3 @@ fr: help: Si vous avez besoin d’aide, visitez le site %{link} no_reply: Veuillez ne pas répondre à ce message. privacy_policy: Politique de confidentialité - sent_from: Envoyé à partir de %{app} diff --git a/config/locales/users/en.yml b/config/locales/users/en.yml index ce721b876f5..08572476428 100644 --- a/config/locales/users/en.yml +++ b/config/locales/users/en.yml @@ -20,6 +20,3 @@ en: generated_on_html: Generated on %{date} header: Your personal key print: Print this page - totp_setup: - new: - qr_img_alt: QR Code for Authenticator App diff --git a/config/locales/users/es.yml b/config/locales/users/es.yml index 738debcccc2..680a520e8df 100644 --- a/config/locales/users/es.yml +++ b/config/locales/users/es.yml @@ -21,6 +21,3 @@ es: generated_on_html: Generado el %{date} header: Su clave personal print: Imprima esta página - totp_setup: - new: - qr_img_alt: Código de QR para la app de autenticación diff --git a/config/locales/users/fr.yml b/config/locales/users/fr.yml index 367651e96b3..42dc3968c74 100644 --- a/config/locales/users/fr.yml +++ b/config/locales/users/fr.yml @@ -23,6 +23,3 @@ fr: generated_on_html: Générée le %{date} header: Votre clé personnelle print: Imprimer cette page - totp_setup: - new: - qr_img_alt: Code QR pour l'application d'authentification From b6a43c8b47629e3801a86bece40ac2b0911706c8 Mon Sep 17 00:00:00 2001 From: Steve Urciuoli Date: Fri, 18 Oct 2019 13:51:51 -0500 Subject: [PATCH 7/7] Last one --- config/locales/mailer/es.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/config/locales/mailer/es.yml b/config/locales/mailer/es.yml index 26115439454..b826776df18 100644 --- a/config/locales/mailer/es.yml +++ b/config/locales/mailer/es.yml @@ -7,4 +7,3 @@ es: help: Si necesita ayuda, visite %{link} no_reply: Por favor, no responda a este mensaje. privacy_policy: Póliza de privacidad -