From e532dd5fff80d5e2c5c0e1aafd0fa3ad18996842 Mon Sep 17 00:00:00 2001 From: James Smith Date: Thu, 13 Sep 2018 13:26:59 -0400 Subject: [PATCH] Return blank for nil phone numbers **Why**: We are getting an error raised if no phone configuration exists. **How**: Check for nil and return a blank string. --- app/decorators/user_decorator.rb | 1 + spec/decorators/user_decorator_spec.rb | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/app/decorators/user_decorator.rb b/app/decorators/user_decorator.rb index 9e44ee157db..14f26073fa5 100644 --- a/app/decorators/user_decorator.rb +++ b/app/decorators/user_decorator.rb @@ -130,6 +130,7 @@ def delete_account_bullet_key attr_reader :user def masked_number(number) + return '' if number.blank? "***-***-#{number[-4..-1]}" end diff --git a/spec/decorators/user_decorator_spec.rb b/spec/decorators/user_decorator_spec.rb index 72252376dd3..7b6d450012f 100644 --- a/spec/decorators/user_decorator_spec.rb +++ b/spec/decorators/user_decorator_spec.rb @@ -47,6 +47,14 @@ end end + describe '#masked_number' do + it 'returns blank for a nil number' do + user = build_stubbed(:user) + user_decorator = UserDecorator.new(user) + expect(user_decorator.send(:masked_number, nil)).to eq '' + end + end + describe '#active_identity_for' do it 'returns Identity matching ServiceProvider' do sp = create(:service_provider, issuer: 'http://sp.example.com')