From 030210c6b912f90d048a736fcec9daef0e1713cd Mon Sep 17 00:00:00 2001 From: James Smith Date: Mon, 27 Aug 2018 11:20:54 -0400 Subject: [PATCH] Make user_access_key_overrides fasterer **Why**: Fasterer is one of our linters to make sure we are writing efficient code. **How**: Rather than make a method that returns the value of an instance attribute, we use an attribute reader. --- app/models/concerns/user_access_key_overrides.rb | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/app/models/concerns/user_access_key_overrides.rb b/app/models/concerns/user_access_key_overrides.rb index cb604ad68e6..167939a8adc 100644 --- a/app/models/concerns/user_access_key_overrides.rb +++ b/app/models/concerns/user_access_key_overrides.rb @@ -5,6 +5,8 @@ module UserAccessKeyOverrides extend ActiveSupport::Concern + attr_reader :personal_key + def valid_password?(password) result = Encryption::PasswordVerifier.verify( password: password, @@ -27,10 +29,6 @@ def valid_personal_key?(normalized_personal_key) ) end - def personal_key - @personal_key - end - def personal_key=(new_personal_key) @personal_key = new_personal_key return if @personal_key.blank?