diff --git a/config/application.yml.default b/config/application.yml.default
index 4321f7bdc85..26e2f01bd38 100644
--- a/config/application.yml.default
+++ b/config/application.yml.default
@@ -107,8 +107,6 @@ doc_auth_client_sharpness_threshold: 50
doc_auth_error_dpi_threshold: 290
doc_auth_error_glare_threshold: 40
doc_auth_error_sharpness_threshold: 40
-doc_auth_manual_upload_disabled_a_b_testing_enabled: false
-doc_auth_manual_upload_disabled_a_b_testing_percent: 0
doc_auth_max_attempts: 5
doc_auth_max_capture_attempts_before_native_camera: 3
doc_auth_max_submission_attempts_before_native_camera: 3
diff --git a/config/initializers/ab_tests.rb b/config/initializers/ab_tests.rb
index dc88ef9bd62..3a3d52302b4 100644
--- a/config/initializers/ab_tests.rb
+++ b/config/initializers/ab_tests.rb
@@ -168,18 +168,6 @@ def self.all
user&.uuid
end.freeze
- DOC_AUTH_MANUAL_UPLOAD_DISABLED = AbTest.new(
- experiment_name: 'Doc Auth Manual Upload Disabled',
- should_log: /^idv/i,
- buckets: {
- manual_upload_disabled:
- IdentityConfig.store.doc_auth_manual_upload_disabled_a_b_testing_enabled ?
- IdentityConfig.store.doc_auth_manual_upload_disabled_a_b_testing_percent : 0,
- },
- ) do |service_provider:, session:, user:, user_session:, **|
- user&.uuid
- end.freeze
-
PROOFING_VENDOR = AbTest.new(
experiment_name: 'Proofing Vendor',
should_log: /^idv/i,
diff --git a/lib/identity_config.rb b/lib/identity_config.rb
index 86ce3f187c5..f08e2c92807 100644
--- a/lib/identity_config.rb
+++ b/lib/identity_config.rb
@@ -127,8 +127,6 @@ def self.store
config.add(:doc_auth_error_glare_threshold, type: :integer)
config.add(:doc_auth_error_sharpness_threshold, type: :integer)
config.add(:doc_auth_max_attempts, type: :integer)
- config.add(:doc_auth_manual_upload_disabled_a_b_testing_enabled, type: :boolean)
- config.add(:doc_auth_manual_upload_disabled_a_b_testing_percent, type: :integer)
config.add(:doc_auth_max_capture_attempts_before_native_camera, type: :integer)
config.add(:doc_auth_max_submission_attempts_before_native_camera, type: :integer)
config.add(:doc_auth_passports_enabled, type: :boolean)
diff --git a/spec/config/initializers/ab_tests_spec.rb b/spec/config/initializers/ab_tests_spec.rb
index 94a034ecd66..30663395f92 100644
--- a/spec/config/initializers/ab_tests_spec.rb
+++ b/spec/config/initializers/ab_tests_spec.rb
@@ -536,30 +536,6 @@
it_behaves_like 'an A/B test that uses user_uuid as a discriminator'
end
- describe 'DOC_AUTH_MANUAL_UPLOAD_DISABLED' do
- let(:ab_test) { :DOC_AUTH_MANUAL_UPLOAD_DISABLED }
-
- let(:enable_ab_test) do
- -> {
- allow(IdentityConfig.store)
- .to receive(:doc_auth_manual_upload_disabled_a_b_testing_enabled)
- .and_return(true)
- allow(IdentityConfig.store)
- .to receive(:doc_auth_manual_upload_disabled_a_b_testing_percent)
- .and_return(50)
- }
- end
-
- let(:disable_ab_test) do
- -> {
- allow(IdentityConfig.store).to receive(:doc_auth_manual_upload_disabled_a_b_testing_enabled)
- .and_return(false)
- }
- end
-
- it_behaves_like 'an A/B test that uses user_uuid as a discriminator'
- end
-
describe 'PROOFING_VENDOR' do
let(:ab_test) { :PROOFING_VENDOR }
diff --git a/spec/controllers/idv/document_capture_controller_spec.rb b/spec/controllers/idv/document_capture_controller_spec.rb
index 218af4a42b3..67666f60f09 100644
--- a/spec/controllers/idv/document_capture_controller_spec.rb
+++ b/spec/controllers/idv/document_capture_controller_spec.rb
@@ -12,7 +12,6 @@
let(:facial_match_required) { false }
let(:flow_path) { 'standard' }
let(:doc_auth_selfie_desktop_test_mode) { false }
- let(:upload_disabled) { :default }
# document capture setup
let(:doc_auth_success) { true }
@@ -55,9 +54,6 @@
resolved_authn_context = Vot::Parser.new(vector_of_trust: vot).parse
allow(controller).to receive(:resolved_authn_context_result)
.and_return(resolved_authn_context)
- allow(subject).to receive(:ab_test_bucket).and_call_original
- allow(subject).to receive(:ab_test_bucket).with(:DOC_AUTH_MANUAL_UPLOAD_DISABLED)
- .and_return(upload_disabled)
allow(subject).to receive(:ab_test_analytics_buckets).and_return(ab_test_args)
allow(IdentityConfig.store).to receive(:doc_auth_vendor).and_return(idv_vendor)
@@ -156,7 +152,7 @@
locals: hash_including(
document_capture_session_uuid: document_capture_session_uuid,
doc_auth_selfie_capture: false,
- doc_auth_upload_enabled: true,
+ doc_auth_upload_enabled: false,
),
).and_call_original
@@ -255,24 +251,6 @@
end
end
- context 'when manual upload is disabled' do
- let(:upload_disabled) { :manual_upload_disabled }
-
- it 'does not allow manual upload' do
- expect(subject).to receive(:render).with(
- :show,
- locals: hash_including(
- document_capture_session_uuid: document_capture_session_uuid,
- doc_auth_selfie_capture: false,
- doc_auth_upload_enabled: false,
- ),
- ).and_call_original
-
- get :show
- expect(response).to render_template :show
- end
- end
-
context 'redo_document_capture' do
it 'adds redo_document_capture to analytics' do
subject.idv_session.redo_document_capture = true
diff --git a/spec/controllers/idv/hybrid_handoff_controller_spec.rb b/spec/controllers/idv/hybrid_handoff_controller_spec.rb
index dd621ac176e..9e16f062145 100644
--- a/spec/controllers/idv/hybrid_handoff_controller_spec.rb
+++ b/spec/controllers/idv/hybrid_handoff_controller_spec.rb
@@ -11,6 +11,7 @@
let(:in_person_proofing) { false }
let(:ipp_opt_in_enabled) { false }
let(:sp_selfie_enabled) { false }
+ let(:desktop_test_mode_enabled) { false }
let(:document_capture_session) { create(:document_capture_session) }
let(:document_capture_session_uuid) { document_capture_session.uuid }
@@ -29,6 +30,8 @@
allow(subject).to receive(:resolved_authn_context_result)
.and_return(resolved_authn_context_result)
+ allow(IdentityConfig.store).to receive(:doc_auth_selfie_desktop_test_mode)
+ .and_return(desktop_test_mode_enabled)
allow(IdentityConfig.store).to receive(:in_person_proofing_enabled) { in_person_proofing }
allow(IdentityConfig.store).to receive(:in_person_proofing_opt_in_enabled) {
ipp_opt_in_enabled
@@ -75,10 +78,10 @@
expect(response).to render_template :show
end
- it 'defaults to upload disabled being false' do
+ it 'defaults to upload enabled being false' do
get :show
- expect(assigns(:upload_disabled)).to be false
+ expect(assigns(:upload_enabled)).to be false
end
it 'sends analytics_visited event' do
@@ -107,29 +110,23 @@
end
end
- context '@upload_disabled is true' do
- before do
- allow(IdentityConfig.store).to receive(:doc_auth_selfie_desktop_test_mode).and_return(false)
- allow(subject).to receive(:ab_test_bucket).and_call_original
- allow(subject).to receive(:ab_test_bucket).with(:DOC_AUTH_MANUAL_UPLOAD_DISABLED)
- .and_return(:manual_upload_disabled)
- end
+ context '@upload_enabled is false' do
+ let(:desktop_test_mode_enabled) { false }
- context 'selfie check required is true' do
- let(:sp_selfie_enabled) { true }
- it 'returns true' do
- get :show
+ it 'returns false' do
+ get :show
- expect(assigns(:upload_disabled)).to be true
- end
+ expect(assigns(:upload_enabled)).to be false
end
+ end
- context 'doc_auth_upload_disabled? is true' do
- it 'returns true' do
- get :show
+ context '@upload_enabled is true' do
+ let(:desktop_test_mode_enabled) { true }
- expect(assigns(:upload_disabled)).to be true
- end
+ it 'returns true' do
+ get :show
+
+ expect(assigns(:upload_enabled)).to be true
end
end
diff --git a/spec/controllers/idv/hybrid_mobile/document_capture_controller_spec.rb b/spec/controllers/idv/hybrid_mobile/document_capture_controller_spec.rb
index 371ce6c7079..bd2680837df 100644
--- a/spec/controllers/idv/hybrid_mobile/document_capture_controller_spec.rb
+++ b/spec/controllers/idv/hybrid_mobile/document_capture_controller_spec.rb
@@ -13,7 +13,6 @@
)
end
- let(:upload_disabled) { :default }
let(:document_capture_session_uuid) { document_capture_session&.uuid }
let(:document_capture_session_requested_at) { Time.zone.now }
@@ -26,10 +25,6 @@
session[:doc_capture_user_id] = user&.id
session[:document_capture_session_uuid] = document_capture_session_uuid
- allow(subject).to receive(:ab_test_bucket).and_call_original
- allow(subject).to receive(:ab_test_bucket).with(:DOC_AUTH_MANUAL_UPLOAD_DISABLED, user: user)
- .and_return(upload_disabled)
-
allow(IdentityConfig.store).to receive(:doc_auth_vendor).and_return(idv_vendor)
allow(IdentityConfig.store).to receive(:doc_auth_vendor_default).and_return(idv_vendor)
end
@@ -94,7 +89,7 @@
:show,
locals: hash_including(
document_capture_session_uuid: document_capture_session_uuid,
- doc_auth_upload_enabled: true,
+ doc_auth_upload_enabled: false,
),
).and_call_original
@@ -124,24 +119,6 @@
end
end
- context 'when manual upload is disabled' do
- let(:upload_disabled) { :manual_upload_disabled }
-
- it 'does not allow manual upload' do
- expect(subject).to receive(:render).with(
- :show,
- locals: hash_including(
- document_capture_session_uuid: document_capture_session_uuid,
- doc_auth_upload_enabled: false,
- ),
- ).and_call_original
-
- get :show
-
- expect(response).to render_template :show
- end
- end
-
it 'sends analytics_visited event' do
get :show
diff --git a/spec/features/idv/doc_auth/hybrid_handoff_spec.rb b/spec/features/idv/doc_auth/hybrid_handoff_spec.rb
index 747cca3386e..46433236e22 100644
--- a/spec/features/idv/doc_auth/hybrid_handoff_spec.rb
+++ b/spec/features/idv/doc_auth/hybrid_handoff_spec.rb
@@ -377,7 +377,6 @@ def verify_no_upload_photos_section_and_link(page)
it 'shows non selfie version of top content and upload section,
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
- verify_upload_photos_section_and_link(page)
end
end
end
@@ -396,7 +395,6 @@ def verify_no_upload_photos_section_and_link(page)
it 'shows non selfie version of top content and upload section,
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
- verify_upload_photos_section_and_link(page)
end
end
end
@@ -422,7 +420,6 @@ def verify_no_upload_photos_section_and_link(page)
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
verify_handoff_page_no_ipp_option_shown(page)
- verify_upload_photos_section_and_link(page)
end
end
end
@@ -435,7 +432,6 @@ def verify_no_upload_photos_section_and_link(page)
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
verify_handoff_page_no_ipp_option_shown(page)
- verify_upload_photos_section_and_link(page)
end
end
end
@@ -464,7 +460,6 @@ def verify_no_upload_photos_section_and_link(page)
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
verify_handoff_page_no_ipp_option_shown(page)
- verify_upload_photos_section_and_link(page)
end
end
end
@@ -485,7 +480,6 @@ def verify_no_upload_photos_section_and_link(page)
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
verify_handoff_page_no_ipp_option_shown(page)
- verify_upload_photos_section_and_link(page)
end
end
end
@@ -510,7 +504,6 @@ def verify_no_upload_photos_section_and_link(page)
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
verify_handoff_page_no_ipp_option_shown(page)
- verify_upload_photos_section_and_link(page)
end
end
end
@@ -531,7 +524,6 @@ def verify_no_upload_photos_section_and_link(page)
no ipp option section' do
verify_handoff_page_non_selfie_version_content(page)
verify_handoff_page_no_ipp_option_shown(page)
- verify_upload_photos_section_and_link(page)
end
end
end
diff --git a/spec/views/idv/hybrid_handoff/show.html.erb_spec.rb b/spec/views/idv/hybrid_handoff/show.html.erb_spec.rb
index f26e17afaf7..42e30ace50f 100644
--- a/spec/views/idv/hybrid_handoff/show.html.erb_spec.rb
+++ b/spec/views/idv/hybrid_handoff/show.html.erb_spec.rb
@@ -33,13 +33,6 @@
)
end
- it 'has a form for starting desktop doc auth with an aria label tag' do
- expect(rendered).to have_selector(
- :xpath,
- "//form[@aria-label=\"#{t('forms.buttons.upload_photos')}\"]",
- )
- end
-
it 'displays the expected headings from the "a" case' do
expect(rendered).to have_selector('h1', text: t('doc_auth.headings.how_to_verify'))
expect(rendered).to have_selector('h2', text: t('doc_auth.headings.upload_from_phone'))
diff --git a/spec/views/idv/shared/_document_capture.html.erb_spec.rb b/spec/views/idv/shared/_document_capture.html.erb_spec.rb
index 617eb0025da..20a06504670 100644
--- a/spec/views/idv/shared/_document_capture.html.erb_spec.rb
+++ b/spec/views/idv/shared/_document_capture.html.erb_spec.rb
@@ -15,7 +15,7 @@
let(:acuant_sdk_upgrade_a_b_testing_enabled) { false }
let(:use_alternate_sdk) { false }
let(:selfie_capture_enabled) { true }
- let(:upload_enabled) { true }
+ let(:upload_enabled) { false }
let(:acuant_version) { '1.3.3.7' }
let(:skip_doc_auth_from_how_to_verify) { false }
@@ -154,7 +154,6 @@
end
context 'when doc_auth_upload_enabled is false' do
- let(:upload_enabled) { false }
it 'does not send doc_auth_upload_enabled to the FE' do
render_partial
expect(rendered).to have_css(