From 6a742df4e8ca65909d8bb87b99e4e05cf46b09a8 Mon Sep 17 00:00:00 2001 From: Zach Margolis Date: Thu, 23 Jan 2025 09:19:12 -0800 Subject: [PATCH] Remove Faker use in UserMailerPreview - Mailer previews occasionally load in production environments (sandbox) but in #11757, we moved the Faker gem to the test group (which breaks these previews in sandbox) - Removing the usage of Faker in the previews helps keep the previews working, and keeps the production dependencies smaller changelog: Internal, Source code, Remove gem dependency from mailer previews --- spec/mailers/previews/user_mailer_preview.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/spec/mailers/previews/user_mailer_preview.rb b/spec/mailers/previews/user_mailer_preview.rb index 66edf8f05ee..f4ab34cf2af 100644 --- a/spec/mailers/previews/user_mailer_preview.rb +++ b/spec/mailers/previews/user_mailer_preview.rb @@ -295,8 +295,8 @@ def user devices: [ unsaveable( Device.new( - user_agent: Faker::Internet.user_agent, - last_ip: Faker::Internet.ip_v4_address, + user_agent: 'Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/51.0.2704.103 Safari/537.36', # rubocop:disable Layout/LineLength + last_ip: '8.8.8.8', ), ), ],