From 737fb6fe2f548c2f5ed3d5c2cdcd8dd75e5e7066 Mon Sep 17 00:00:00 2001 From: Eileen Date: Wed, 22 Jan 2025 16:12:00 -0500 Subject: [PATCH 1/4] fix user mailer by adding faker to gemfile development, test group --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index 75507ed7336..265fa996778 100644 --- a/Gemfile +++ b/Gemfile @@ -123,12 +123,12 @@ group :development, :test do gem 'rubocop-rspec', '~> 3.2.0', require: false gem 'rubocop-capybara', require: false gem 'sqlite3', require: false + gem 'faker' end group :test do gem 'axe-core-rspec', '~> 4.2' gem 'bundler-audit', require: false - gem 'faker' gem 'simplecov', '~> 0.22.0', require: false gem 'simplecov-cobertura' gem 'simplecov_json_formatter' From 647e7dd015ad2aa8b04cfad69beb2b47abc4947d Mon Sep 17 00:00:00 2001 From: Eileen Date: Wed, 22 Jan 2025 16:14:13 -0500 Subject: [PATCH 2/4] Changelog: Internal, In-person Proofing, restore user mailer functionality by including faker in development/test gemfile group From bb3db5c7271edf0673939ba51c355cd7e7584590 Mon Sep 17 00:00:00 2001 From: Eileen Date: Wed, 22 Jan 2025 16:37:38 -0500 Subject: [PATCH 3/4] alphabetize gemfile development/test group --- Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index 265fa996778..8bd4acf5e3c 100644 --- a/Gemfile +++ b/Gemfile @@ -105,6 +105,7 @@ group :development, :test do gem 'bullet', '~> 7.0' gem 'capybara-webmock', git: 'https://github.com/hashrocket/capybara-webmock.git', ref: 'd3f3b7c' gem 'erb_lint', '~> 0.7.0', require: false + gem 'faker' gem 'i18n-tasks', '~> 1.0' gem 'knapsack' gem 'listen' @@ -123,7 +124,6 @@ group :development, :test do gem 'rubocop-rspec', '~> 3.2.0', require: false gem 'rubocop-capybara', require: false gem 'sqlite3', require: false - gem 'faker' end group :test do From db431dff817daab49c7100fdaad0c8a6349bd61c Mon Sep 17 00:00:00 2001 From: Eileen McFarland <80347702+eileen-nava@users.noreply.github.com> Date: Thu, 23 Jan 2025 11:49:55 -0500 Subject: [PATCH 4/4] ensure faker isn't default required when running idp locally --- Gemfile | 2 +- spec/mailers/previews/user_mailer_preview.rb | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/Gemfile b/Gemfile index 8bd4acf5e3c..94706b228ba 100644 --- a/Gemfile +++ b/Gemfile @@ -105,7 +105,7 @@ group :development, :test do gem 'bullet', '~> 7.0' gem 'capybara-webmock', git: 'https://github.com/hashrocket/capybara-webmock.git', ref: 'd3f3b7c' gem 'erb_lint', '~> 0.7.0', require: false - gem 'faker' + gem 'faker', require: false # used in mailer previews gem 'i18n-tasks', '~> 1.0' gem 'knapsack' gem 'listen' diff --git a/spec/mailers/previews/user_mailer_preview.rb b/spec/mailers/previews/user_mailer_preview.rb index 66edf8f05ee..9c58ecfef3f 100644 --- a/spec/mailers/previews/user_mailer_preview.rb +++ b/spec/mailers/previews/user_mailer_preview.rb @@ -1,3 +1,5 @@ +require 'faker' + class UserMailerPreview < ActionMailer::Preview def email_confirmation_instructions UserMailer.with(user: user, email_address: email_address_record)