diff --git a/config/pinpoint_overrides.yml b/config/pinpoint_overrides.yml index 735d1e384c9..eaff6030f81 100644 --- a/config/pinpoint_overrides.yml +++ b/config/pinpoint_overrides.yml @@ -1,4 +1,5 @@ AE: + supports_sms: false supports_voice: true supports_voice_unconfirmed: false AF: @@ -53,6 +54,7 @@ BO: BR: supports_voice: false BY: + supports_sms: true supports_sms_unconfirmed: false supports_voice: true supports_voice_unconfirmed: false @@ -126,6 +128,7 @@ IT: JM: supports_voice: false JO: + supports_sms: true supports_sms_unconfirmed: false supports_voice: true supports_voice_unconfirmed: false @@ -144,6 +147,7 @@ KI: supports_sms: true supports_voice: false KW: + supports_sms: false supports_voice: true supports_voice_unconfirmed: false KY: @@ -151,6 +155,8 @@ KY: KZ: supports_sms_unconfirmed: false supports_voice: false +LK: + supports_sms: false LT: supports_voice: false LU: @@ -199,6 +205,7 @@ PA: PE: supports_voice: false PH: + supports_sms: true supports_voice_unconfirmed: false PK: supports_sms_unconfirmed: false @@ -215,17 +222,20 @@ PW: supports_sms: true supports_voice: false QA: + supports_sms: false supports_voice: true supports_voice_unconfirmed: false RO: supports_sms_unconfirmed: false supports_voice: false RU: + supports_sms: false supports_voice: true supports_voice_unconfirmed: false RW: supports_sms_unconfirmed: false SA: + supports_sms: false supports_voice: true supports_voice_unconfirmed: false SI: @@ -243,6 +253,7 @@ TD: supports_sms_unconfirmed: false supports_voice: false TH: + supports_sms: true supports_voice_unconfirmed: false TJ: supports_sms_unconfirmed: false @@ -253,6 +264,8 @@ TM: supports_sms_unconfirmed: false TN: supports_sms_unconfirmed: false +TR: + supports_sms: false TT: supports_voice: false TW: @@ -273,6 +286,7 @@ VC: VE: supports_voice: false VN: + supports_sms: false supports_voice_unconfirmed: false YE: supports_sms_unconfirmed: false diff --git a/config/pinpoint_supported_countries.yml b/config/pinpoint_supported_countries.yml index 48c3b943000..3d581c05e0b 100644 --- a/config/pinpoint_supported_countries.yml +++ b/config/pinpoint_supported_countries.yml @@ -7,7 +7,7 @@ AD: AE: country_code: '971' name: United Arab Emirates (UAE) - supports_sms: false + supports_sms: true supports_voice: false AF: country_code: '93' @@ -147,7 +147,7 @@ BW: BY: country_code: '375' name: Belarus - supports_sms: true + supports_sms: false supports_voice: false BZ: country_code: '501' @@ -272,7 +272,7 @@ EE: EG: country_code: '20' name: Egypt - supports_sms: true + supports_sms: false supports_voice: false ER: country_code: '291' @@ -428,7 +428,7 @@ HU: country_code: '36' name: Hungary supports_sms: true - supports_voice: true + supports_voice: false ID: country_code: '62' name: Indonesia @@ -482,7 +482,7 @@ JM: JO: country_code: '962' name: Jordan - supports_sms: true + supports_sms: false supports_voice: false JP: country_code: '81' @@ -522,7 +522,7 @@ KR: KW: country_code: '965' name: Kuwait - supports_sms: false + supports_sms: true supports_voice: false KY: country_code: '1345' @@ -557,7 +557,7 @@ LI: LK: country_code: '94' name: Sri Lanka - supports_sms: false + supports_sms: true supports_voice: false LR: country_code: '231' @@ -728,7 +728,7 @@ NL: country_code: '47' name: Norway supports_sms: true - supports_voice: true + supports_voice: false NP: country_code: '977' name: Nepal @@ -772,7 +772,7 @@ PG: PH: country_code: '63' name: Philippines - supports_sms: true + supports_sms: false supports_voice: true PK: country_code: '92' @@ -807,7 +807,7 @@ PY: QA: country_code: '974' name: Qatar - supports_sms: false + supports_sms: true supports_voice: false RE: country_code: '262' @@ -827,7 +827,7 @@ RS: RU: country_code: '7' name: Russia - supports_sms: false + supports_sms: true supports_voice: false RW: country_code: '250' @@ -837,7 +837,7 @@ RW: SA: country_code: '966' name: Saudi Arabia - supports_sms: false + supports_sms: true supports_voice: false SB: country_code: '677' @@ -932,7 +932,7 @@ TG: TH: country_code: '66' name: Thailand - supports_sms: true + supports_sms: false supports_voice: true TJ: country_code: '992' @@ -962,7 +962,7 @@ TO: TR: country_code: '90' name: Turkey - supports_sms: false + supports_sms: true supports_voice: false TT: country_code: '1868' @@ -1027,7 +1027,7 @@ VI: VN: country_code: '84' name: Vietnam - supports_sms: false + supports_sms: true supports_voice: true VU: country_code: '678' diff --git a/lib/pinpoint_supported_countries.rb b/lib/pinpoint_supported_countries.rb index 35201f1267e..620f697cc41 100644 --- a/lib/pinpoint_supported_countries.rb +++ b/lib/pinpoint_supported_countries.rb @@ -81,6 +81,8 @@ def sms_support SENDER_ID_COUNTRIES.include?(iso_code) || SENDER_ID_EXCEPTION_COUNTRIES.include?(iso_code) when 'Registration required3' # basically only India, has special rules true + when 'Registration required9' # if a sender ID is sent, it must be registered + !SENDER_ID_COUNTRIES.include?(iso_code) else true end diff --git a/spec/lib/pinpoint_supported_countries_spec.rb b/spec/lib/pinpoint_supported_countries_spec.rb index 55f39294e9a..cd6637c2c7c 100644 --- a/spec/lib/pinpoint_supported_countries_spec.rb +++ b/spec/lib/pinpoint_supported_countries_spec.rb @@ -63,10 +63,15 @@ India IN - Registration required3 - + Registration required3 Yes + + Zambia + ZM + Registration required9 + No + HTML end @@ -128,6 +133,11 @@ name: India supports_sms: true supports_voice: false + ZM: + country_code: '260' + name: Zambia + supports_sms: true + supports_voice: false STR end end @@ -141,6 +151,7 @@ PinpointSupportedCountries::CountrySupport.new(iso_code: 'BY', name: 'Belarus', supports_sms: true), PinpointSupportedCountries::CountrySupport.new(iso_code: 'KY', name: 'Cayman Islands', supports_sms: true), PinpointSupportedCountries::CountrySupport.new(iso_code: 'IN', name: 'India', supports_sms: true), + PinpointSupportedCountries::CountrySupport.new(iso_code: 'ZM', name: 'Zambia', supports_sms: true), ] end # rubocop:enable Layout/LineLength @@ -189,6 +200,7 @@ PinpointSupportedCountries::CountryDialingCode.new(country_code: '375', iso_code: 'BY', name: 'Belarus', supports_sms: true, supports_voice: false), PinpointSupportedCountries::CountryDialingCode.new(country_code: '1345', iso_code: 'KY', name: 'Cayman Islands', supports_sms: true, supports_voice: true), PinpointSupportedCountries::CountryDialingCode.new(country_code: '91', iso_code: 'IN', name: 'India', supports_sms: true, supports_voice: false), + PinpointSupportedCountries::CountryDialingCode.new(country_code: '260', iso_code: 'ZM', name: 'Zambia', supports_sms: true, supports_voice: false), ] end # rubocop:enable Layout/LineLength