From 9b5d25544b4d7408172843d46b4bb9cf5fee1f5f Mon Sep 17 00:00:00 2001 From: Matt Hinz Date: Mon, 30 Dec 2024 15:02:02 -0800 Subject: [PATCH] Aggressively reload A/B tests during spec runs Tests can get stuck with mocked configs, leading to flakiness. [skip changelog] --- spec/config/initializers/ab_tests_spec.rb | 6 ------ spec/rails_helper.rb | 5 +++++ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/spec/config/initializers/ab_tests_spec.rb b/spec/config/initializers/ab_tests_spec.rb index 2865e06cec3..b6b47801ade 100644 --- a/spec/config/initializers/ab_tests_spec.rb +++ b/spec/config/initializers/ab_tests_spec.rb @@ -1,12 +1,6 @@ require 'rails_helper' RSpec.describe AbTests do - include AbTestsHelper - - after :suite do - reload_ab_tests - end - describe '#all' do it 'returns all registered A/B tests' do expect(AbTests.all.values).to all(be_kind_of(AbTest)) diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb index 4dc85032e9f..0beffa39153 100644 --- a/spec/rails_helper.rb +++ b/spec/rails_helper.rb @@ -32,6 +32,7 @@ config.infer_spec_type_from_file_location! config.include ActiveSupport::Testing::TimeHelpers + config.include AbTestsHelper config.include EmailSpec::Helpers config.include EmailSpec::Matchers config.include AbstractController::Translation @@ -165,4 +166,8 @@ class Analytics ], ) end + + config.after(:context) do + reload_ab_tests + end end