From 1001a06e461d7572bf2a3ba8aa3968c55849ae4c Mon Sep 17 00:00:00 2001 From: Vraj Mohan Date: Mon, 22 Jul 2024 11:51:10 -0700 Subject: [PATCH] Call the report with a proper "Time" changelog: Internal, Reporting, Ensure parameter correctness --- config/initializers/job_configurations.rb | 2 +- spec/jobs/reports/protocols_report_spec.rb | 14 +++++++++++++- 2 files changed, 14 insertions(+), 2 deletions(-) diff --git a/config/initializers/job_configurations.rb b/config/initializers/job_configurations.rb index cba2f104c9a..3b5a81fc33b 100644 --- a/config/initializers/job_configurations.rb +++ b/config/initializers/job_configurations.rb @@ -233,7 +233,7 @@ weekly_protocols_report: { class: 'Reports::ProtocolsReport', cron: cron_every_monday, - args: -> { [Time.zone.yesterday] }, + args: -> { [Time.zone.yesterday.end_of_day] }, }, }.compact end diff --git a/spec/jobs/reports/protocols_report_spec.rb b/spec/jobs/reports/protocols_report_spec.rb index 2e117ca682b..5d524f6981b 100644 --- a/spec/jobs/reports/protocols_report_spec.rb +++ b/spec/jobs/reports/protocols_report_spec.rb @@ -1,7 +1,7 @@ require 'rails_helper' RSpec.describe Reports::ProtocolsReport do - let(:report_date) { Date.new(2024, 7, 5) } + let(:report_date) { Date.new(2024, 7, 5).in_time_zone('UTC') } let(:email) { 'team@example.com' } let(:report_configs) do @@ -40,4 +40,16 @@ subject.perform(report_date) end end + + describe 'with empty logs' do + before do + stub_cloudwatch_logs([]) + end + + it 'sends an email with at least 1 attachment' do + subject.perform(report_date) + sent_mail = ActionMailer::Base.deliveries.last + expect(sent_mail.parts.attachments.count).to be >= 1 + end + end end