diff --git a/app/forms/idv/api_image_upload_form.rb b/app/forms/idv/api_image_upload_form.rb index 9dbf7778a09..cb97b7314da 100644 --- a/app/forms/idv/api_image_upload_form.rb +++ b/app/forms/idv/api_image_upload_form.rb @@ -342,6 +342,7 @@ def update_analytics(client_response:, vendor_request_time_in_ms:) add_costs(client_response) update_funnel(client_response) birth_year = client_response.pii_from_doc&.dob&.to_date&.year + zip_code = client_response.pii_from_doc&.zipcode&.to_s&.strip&.slice(0, 5) analytics.idv_doc_auth_submitted_image_upload_vendor( **client_response.to_h.merge( birth_year: birth_year, @@ -349,6 +350,7 @@ def update_analytics(client_response:, vendor_request_time_in_ms:) async: false, flow_path: params[:flow_path], vendor_request_time_in_ms: vendor_request_time_in_ms, + zip_code: zip_code, ).except(:classification_info). merge(acuant_sdk_upgrade_ab_test_data), ) diff --git a/app/services/analytics_events.rb b/app/services/analytics_events.rb index b6f0cf176b1..a2e67ab2aef 100644 --- a/app/services/analytics_events.rb +++ b/app/services/analytics_events.rb @@ -1127,6 +1127,7 @@ def idv_doc_auth_submitted_image_upload_form( # @param [Hash] portrait_match_results # @param [Hash] image_metrics # @param [Boolean] address_line2_present + # @param [String] zip_code # @option extra [String] 'DocumentName' # @option extra [String] 'DocAuthResult' # @option extra [String] 'DocIssuerCode' @@ -1177,6 +1178,7 @@ def idv_doc_auth_submitted_image_upload_vendor( portrait_match_results: nil, image_metrics: nil, address_line2_present: nil, + zip_code: nil, **extra ) track_event( @@ -1215,6 +1217,7 @@ def idv_doc_auth_submitted_image_upload_vendor( image_metrics:, address_line2_present:, liveness_checking_required:, + zip_code:, **extra, ) end diff --git a/lib/idp/constants.rb b/lib/idp/constants.rb index bd772c5fd60..5a3b32bce42 100644 --- a/lib/idp/constants.rb +++ b/lib/idp/constants.rb @@ -105,7 +105,7 @@ module Vendors state_id_jurisdiction: MOCK_IDV_APPLICANT_STATE_ID_JURISDICTION, state_id_number: '1111111111111', state_id_type: 'drivers_license', - zipcode: '59010', + zipcode: '59010-1234', issuing_country_code: 'US', }.freeze @@ -116,7 +116,7 @@ module Vendors identity_doc_address1: '123 Way St', identity_doc_address2: '2nd Address Line', identity_doc_city: 'Best City', - identity_doc_zipcode: '12345', + identity_doc_zipcode: '12345-4321', state_id_jurisdiction: 'Virginia', identity_doc_address_state: 'VA', state_id_number: '1111111111111', @@ -133,7 +133,7 @@ module Vendors identity_doc_address1: '123 Way St', identity_doc_address2: '2nd Address Line', identity_doc_city: 'Best City', - identity_doc_zipcode: '12345', + identity_doc_zipcode: '12345-4321', identity_doc_address_state: 'VA', same_address_as_id: 'false', ).freeze diff --git a/spec/controllers/idv/image_uploads_controller_spec.rb b/spec/controllers/idv/image_uploads_controller_spec.rb index b458af87f1a..b004ad3f587 100644 --- a/spec/controllers/idv/image_uploads_controller_spec.rb +++ b/spec/controllers/idv/image_uploads_controller_spec.rb @@ -462,6 +462,7 @@ vendor: nil, workflow: an_instance_of(String), birth_year: 1938, + zip_code: '59010', ) expect(@analytics).to have_logged_event( @@ -647,6 +648,7 @@ transaction_status: nil, vendor: nil, birth_year: 1938, + zip_code: '12345', ) expect(@analytics).to have_logged_event( @@ -760,6 +762,7 @@ transaction_status: nil, vendor: nil, birth_year: 1938, + zip_code: '12345', ) expect(@analytics).to have_logged_event( @@ -873,6 +876,7 @@ transaction_status: nil, vendor: nil, birth_year: 1938, + zip_code: '12345', ) expect(@analytics).to have_logged_event( @@ -983,6 +987,7 @@ transaction_status: nil, vendor: nil, birth_year: nil, + zip_code: '12345', ) expect(@analytics).to have_logged_event( @@ -1102,6 +1107,7 @@ transaction_status: nil, vendor: nil, birth_year: nil, + zip_code: nil, ) expect_funnel_update_counts(user, 1) @@ -1194,6 +1200,7 @@ vendor: nil, workflow: an_instance_of(String), birth_year: nil, + zip_code: nil, ) expect_funnel_update_counts(user, 1) diff --git a/spec/fixtures/ial2_test_portrait_match_success.yml b/spec/fixtures/ial2_test_portrait_match_success.yml index decfc65999d..5b63725e6b1 100644 --- a/spec/fixtures/ial2_test_portrait_match_success.yml +++ b/spec/fixtures/ial2_test_portrait_match_success.yml @@ -10,7 +10,7 @@ document: state_id_jurisdiction: ND state_id_number: '1111111111111' state_id_type: 'drivers_license' - zipcode: '59010' + zipcode: '59010-1234' doc_auth_result: Passed failed_alerts: [] portrait_match_results: diff --git a/spec/forms/idv/api_image_upload_form_spec.rb b/spec/forms/idv/api_image_upload_form_spec.rb index 87b2be2f466..fa657bebb9a 100644 --- a/spec/forms/idv/api_image_upload_form_spec.rb +++ b/spec/forms/idv/api_image_upload_form_spec.rb @@ -257,6 +257,7 @@ transaction_reason_code: nil, workflow: 'test_non_liveness_workflow', birth_year: 1938, + zip_code: '59010', ) end @@ -377,6 +378,7 @@ transaction_reason_code: nil, workflow: 'test_liveness_workflow', birth_year: 1938, + zip_code: '59010', ) end diff --git a/spec/services/doc_auth/mock/doc_auth_mock_client_spec.rb b/spec/services/doc_auth/mock/doc_auth_mock_client_spec.rb index e4ec9c1487c..821fefd18f1 100644 --- a/spec/services/doc_auth/mock/doc_auth_mock_client_spec.rb +++ b/spec/services/doc_auth/mock/doc_auth_mock_client_spec.rb @@ -32,7 +32,7 @@ address2: nil, city: 'GREAT FALLS', state: 'MT', - zipcode: '59010', + zipcode: '59010-1234', dob: '1938-10-06', state_id_number: '1111111111111', state_id_jurisdiction: 'ND', @@ -131,7 +131,7 @@ address2: nil, city: 'GREAT FALLS', state: 'MT', - zipcode: '59010', + zipcode: '59010-1234', dob: '1938-10-06', state_id_number: '1111111111111', state_id_jurisdiction: 'ND', diff --git a/spec/services/doc_auth/mock/result_response_spec.rb b/spec/services/doc_auth/mock/result_response_spec.rb index 0e247fd97b0..8398f56c89d 100644 --- a/spec/services/doc_auth/mock/result_response_spec.rb +++ b/spec/services/doc_auth/mock/result_response_spec.rb @@ -359,7 +359,7 @@ address2: nil, city: 'GREAT FALLS', state: 'MT', - zipcode: '59010', + zipcode: '59010-1234', dob: '1938-10-06', state_id_number: '1111111111111', state_id_jurisdiction: 'ND', diff --git a/spec/support/fake_analytics.rb b/spec/support/fake_analytics.rb index 63abdd58ca0..7862b5feb3a 100644 --- a/spec/support/fake_analytics.rb +++ b/spec/support/fake_analytics.rb @@ -25,7 +25,6 @@ def track_event(event, original_attributes = {}) :first_name, :last_name, :address1, - :zipcode, :dob, :state_id_number, ).each do |key, default_pii_value|