From 7aa8f0e961e48b9794eee1c040aca4feaa54da1e Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Fri, 3 May 2024 13:29:57 -0400 Subject: [PATCH] Remove unused method verification_method_choice changelog: Internal, Code Quality, Remove unused method --- app/decorators/null_service_provider_session.rb | 4 ---- app/decorators/service_provider_session.rb | 4 ---- config/locales/idv/en.yml | 4 ---- config/locales/idv/es.yml | 5 ----- config/locales/idv/fr.yml | 6 ------ config/locales/idv/zh.yml | 2 -- spec/decorators/null_service_provider_session_spec.rb | 8 -------- spec/decorators/service_provider_session_spec.rb | 8 -------- 8 files changed, 41 deletions(-) diff --git a/app/decorators/null_service_provider_session.rb b/app/decorators/null_service_provider_session.rb index 716d3876754..74cae9b0b4a 100644 --- a/app/decorators/null_service_provider_session.rb +++ b/app/decorators/null_service_provider_session.rb @@ -9,10 +9,6 @@ def new_session_heading I18n.t('headings.sign_in_without_sp') end - def verification_method_choice - I18n.t('idv.messages.select_verification_without_sp') - end - def cancel_link_url view_context.root_url end diff --git a/app/decorators/service_provider_session.rb b/app/decorators/service_provider_session.rb index 83c2d92490a..b1b70196278 100644 --- a/app/decorators/service_provider_session.rb +++ b/app/decorators/service_provider_session.rb @@ -52,10 +52,6 @@ def new_session_heading I18n.t('headings.sign_in_with_sp', sp: sp_name) end - def verification_method_choice - I18n.t('idv.messages.select_verification_with_sp', sp_name: sp_name) - end - def requested_attributes (sp_session[:requested_attributes] || service_provider_request.requested_attributes).sort end diff --git a/config/locales/idv/en.yml b/config/locales/idv/en.yml index 7799db46fd4..0420df3ad6a 100644 --- a/config/locales/idv/en.yml +++ b/config/locales/idv/en.yml @@ -259,10 +259,6 @@ en: - Based in the United States (including U.S. territories) - Your primary number (the one you use the most often) return_to_profile: '‹ Return to your %{app_name} profile' - select_verification_with_sp: To protect you from identity fraud, we will contact - you to confirm that this %{sp_name} account is legitimate. - select_verification_without_sp: To protect you from identity fraud, we will - contact you to confirm that this account is legitimate. sessions: enter_password_message: When you re-enter your password, %{app_name} will protect the information you’ve given us, so that only you can access diff --git a/config/locales/idv/es.yml b/config/locales/idv/es.yml index b49c1284df2..a6fd71e1b60 100644 --- a/config/locales/idv/es.yml +++ b/config/locales/idv/es.yml @@ -272,11 +272,6 @@ es: - Con base en Estados Unidos (incluidos los territorios de EE.UU.) - Su número principal (el que utiliza con más frecuencia) return_to_profile: '‹ Vuelva a su perfil de %{app_name}' - select_verification_with_sp: Para protegerle contra el fraude de identidad, - contactaremos con usted para confirmar que esta cuenta de %{sp_name} es - legítima. - select_verification_without_sp: Para protegerle contra el fraude de identidad, - contactaremos con usted para confirmar que esta cuenta es legítima. sessions: enter_password_message: Cuando vuelva a ingresar su contraseña, %{app_name} protegerá la información que nos dio, para que solo usted pueda diff --git a/config/locales/idv/fr.yml b/config/locales/idv/fr.yml index b3cb9a7bfe3..ab4e8a2887f 100644 --- a/config/locales/idv/fr.yml +++ b/config/locales/idv/fr.yml @@ -283,12 +283,6 @@ fr: - Basé aux Etats-Unis (y compris les territoires américains) - Votre numéro principal (celui que vous utilisez le plus souvent) return_to_profile: '‹ Revenir à votre profil %{app_name}' - select_verification_with_sp: Afin de vous protéger contre l’usurpation - d’identité, nous vous contacterons pour confirmer que ce compte - %{sp_name} est légitime. - select_verification_without_sp: Afin de vous protéger contre l’usurpation - d’identité, nous vous contacterons pour confirmer que ce compte est - légitime. sessions: enter_password_message: Lorsque vous ressaisirez votre mot de passe, %{app_name} protégera les informations que vous nous aurez données pour que vous diff --git a/config/locales/idv/zh.yml b/config/locales/idv/zh.yml index f97ab52ad66..24c9df3b1ff 100644 --- a/config/locales/idv/zh.yml +++ b/config/locales/idv/zh.yml @@ -211,8 +211,6 @@ zh: - 美国的（包括美国属地） - 你的主要号码（你最常用的） return_to_profile: '‹ 返回你的 %{app_name} 用户资料' - select_verification_with_sp: 为了保护你不受身份欺诈，我们会联系你确认该 %{sp_name} 账户是真实的。 - select_verification_without_sp: 为了保护你不受身份欺诈，我们会联系你确认该账户是真实的。 sessions: enter_password_message: 你重新输入密码时， %{app_name} 会保护你给我们的信息，这样只有你能访问这些信息。 no_pii: 测试站点 - 请勿使用真实个人信息（仅为演示目的） - 测试站点 diff --git a/spec/decorators/null_service_provider_session_spec.rb b/spec/decorators/null_service_provider_session_spec.rb index 55f373983fa..6c00ddc1fee 100644 --- a/spec/decorators/null_service_provider_session_spec.rb +++ b/spec/decorators/null_service_provider_session_spec.rb @@ -9,14 +9,6 @@ end end - describe '#verification_method_choice' do - it 'returns the correct string' do - expect(subject.verification_method_choice).to eq( - I18n.t('idv.messages.select_verification_without_sp'), - ) - end - end - describe '#sp_logo' do it 'returns nil' do expect(subject.sp_logo).to be_nil diff --git a/spec/decorators/service_provider_session_spec.rb b/spec/decorators/service_provider_session_spec.rb index 8106348ce5b..027bf9509a8 100644 --- a/spec/decorators/service_provider_session_spec.rb +++ b/spec/decorators/service_provider_session_spec.rb @@ -35,14 +35,6 @@ end end - describe '#verification_method_choice' do - it 'returns the correct string' do - expect(subject.verification_method_choice).to eq( - I18n.t('idv.messages.select_verification_with_sp', sp_name: sp_name), - ) - end - end - describe '#sp_alert' do context 'sp has custom alert' do it 'uses the custom template' do