diff --git a/app/controllers/idv/in_person/ssn_controller.rb b/app/controllers/idv/in_person/ssn_controller.rb index ced810f90da..5e56352d9f3 100644 --- a/app/controllers/idv/in_person/ssn_controller.rb +++ b/app/controllers/idv/in_person/ssn_controller.rb @@ -103,7 +103,7 @@ def analytics_arguments def confirm_in_person_address_step_complete return if flow_session[:pii_from_user] && flow_session[:pii_from_user][:address1].present? - redirect_to idv_in_person_proofing_address_url + redirect_to idv_in_person_address_url end end end diff --git a/app/controllers/idv/in_person_controller.rb b/app/controllers/idv/in_person_controller.rb index e7dce29c66b..eaf74d0b536 100644 --- a/app/controllers/idv/in_person_controller.rb +++ b/app/controllers/idv/in_person_controller.rb @@ -18,7 +18,7 @@ class InPersonController < ApplicationController FLOW_STATE_MACHINE_SETTINGS = { step_url: :idv_in_person_step_url, - final_url: :idv_in_person_proofing_address_url, + final_url: :idv_in_person_address_url, flow: Idv::Flows::InPersonFlow, analytics_id: 'In Person Proofing', }.freeze diff --git a/app/services/idv/steps/in_person/state_id_step.rb b/app/services/idv/steps/in_person/state_id_step.rb index 4d1a10458d9..3372f4f4c64 100644 --- a/app/services/idv/steps/in_person/state_id_step.rb +++ b/app/services/idv/steps/in_person/state_id_step.rb @@ -37,7 +37,7 @@ def call redirect_to idv_in_person_verify_info_url if updating_state_id? if pii_from_user[:same_address_as_id] == 'false' - redirect_to idv_in_person_proofing_address_url + redirect_to idv_in_person_address_url end end diff --git a/app/views/idv/in_person/verify_info/show.html.erb b/app/views/idv/in_person/verify_info/show.html.erb index 464b64e9d55..c89c3a20bf2 100644 --- a/app/views/idv/in_person/verify_info/show.html.erb +++ b/app/views/idv/in_person/verify_info/show.html.erb @@ -109,7 +109,7 @@ locals:
<%= link_to( t('idv.buttons.change_label'), - idv_in_person_proofing_address_url, + idv_in_person_address_url, 'aria-label': t('idv.buttons.change_address_label'), ) %>
diff --git a/config/routes.rb b/config/routes.rb index f37a9283f3a..be4a54a2ac5 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -389,14 +389,22 @@ # sometimes underscores get messed up when linked to via SMS as: :capture_doc_dashes - get '/in_person_proofing/address' => 'in_person/address#show' - put '/in_person_proofing/address' => 'in_person/address#update' + # DEPRECATION NOTICE + # Usage of the /in_person_proofing/address routes is deprecated. + # Use the /in_person/address routes instead. + # + # These have been left in temporarily to prevent any impact to users + # during the deprecation process. + get '/in_person_proofing/address' => redirect('/verify/in_person/address', status: 307) + put '/in_person_proofing/address' => redirect('/verify/in_person/address', status: 307) get '/in_person' => 'in_person#index' get '/in_person/ready_to_verify' => 'in_person/ready_to_verify#show', as: :in_person_ready_to_verify post '/in_person/usps_locations' => 'in_person/usps_locations#index' put '/in_person/usps_locations' => 'in_person/usps_locations#update' + get '/in_person/address' => 'in_person/address#show' + put '/in_person/address' => 'in_person/address#update' get '/in_person/ssn' => 'in_person/ssn#show' put '/in_person/ssn' => 'in_person/ssn#update' get '/in_person/verify_info' => 'in_person/verify_info#show' diff --git a/spec/controllers/idv/in_person/ssn_controller_spec.rb b/spec/controllers/idv/in_person/ssn_controller_spec.rb index 97545c9d660..895efa29d16 100644 --- a/spec/controllers/idv/in_person/ssn_controller_spec.rb +++ b/spec/controllers/idv/in_person/ssn_controller_spec.rb @@ -37,7 +37,7 @@ subject.user_session['idv/in_person'][:pii_from_user].delete(:address1) get :show - expect(response).to redirect_to idv_in_person_proofing_address_url + expect(response).to redirect_to idv_in_person_address_url end end end @@ -88,7 +88,7 @@ end context 'with an ssn in idv_session' do - let(:referer) { idv_in_person_proofing_address_url } + let(:referer) { idv_in_person_address_url } before do subject.idv_session.ssn = ssn request.env['HTTP_REFERER'] = referer diff --git a/spec/controllers/idv/in_person_controller_spec.rb b/spec/controllers/idv/in_person_controller_spec.rb index 2d6e748cfe5..0eb22a7a7d0 100644 --- a/spec/controllers/idv/in_person_controller_spec.rb +++ b/spec/controllers/idv/in_person_controller_spec.rb @@ -96,7 +96,7 @@ it 'finishes the flow' do put :update, params: { step: 'state_id' } - expect(response).to redirect_to idv_in_person_proofing_address_url + expect(response).to redirect_to idv_in_person_address_url end end end diff --git a/spec/features/idv/steps/in_person/address_spec.rb b/spec/features/idv/steps/in_person/address_spec.rb index 5d9f8e31593..def68be5983 100644 --- a/spec/features/idv/steps/in_person/address_spec.rb +++ b/spec/features/idv/steps/in_person/address_spec.rb @@ -14,7 +14,7 @@ it 'displays correct heading and button text', allow_browser_log: true do complete_idv_steps_before_address # residential address page - expect(page).to have_current_path(idv_in_person_proofing_address_url) + expect(page).to have_current_path(idv_in_person_address_url) expect(page).to have_content(t('forms.buttons.continue')) expect(page).to have_content(t('in_person_proofing.headings.address')) @@ -23,7 +23,7 @@ it 'allows the user to cancel and start over', allow_browser_log: true do complete_idv_steps_before_address - expect(page).to have_current_path(idv_in_person_proofing_address_url, wait: 10) + expect(page).to have_current_path(idv_in_person_address_url, wait: 10) expect(page).not_to have_content('forms.buttons.back') click_link t('links.cancel') @@ -38,7 +38,7 @@ click_link t('links.cancel') click_on t('idv.cancel.actions.keep_going') - expect(page).to have_current_path(idv_in_person_proofing_address_url) + expect(page).to have_current_path(idv_in_person_address_url) end it 'allows user to submit valid inputs on form', allow_browser_log: true do diff --git a/spec/features/idv/steps/in_person/state_id_step_spec.rb b/spec/features/idv/steps/in_person/state_id_step_spec.rb index 63a6117c18b..2acf3f8dfd5 100644 --- a/spec/features/idv/steps/in_person/state_id_step_spec.rb +++ b/spec/features/idv/steps/in_person/state_id_step_spec.rb @@ -382,7 +382,7 @@ with: InPersonHelper::GOOD_IDENTITY_DOC_CITY click_idv_continue - expect(page).to have_current_path(idv_in_person_proofing_address_url, wait: 10) + expect(page).to have_current_path(idv_in_person_address_url, wait: 10) end end diff --git a/spec/support/features/in_person_helper.rb b/spec/support/features/in_person_helper.rb index 98cedc76a37..1a6c4712d3a 100644 --- a/spec/support/features/in_person_helper.rb +++ b/spec/support/features/in_person_helper.rb @@ -129,7 +129,7 @@ def complete_state_id_step(_user = nil, same_address_as_id: true) fill_out_state_id_form_ok(same_address_as_id: same_address_as_id) click_idv_continue unless same_address_as_id - expect(page).to have_current_path(idv_in_person_proofing_address_path, wait: 10) + expect(page).to have_current_path(idv_in_person_address_path, wait: 10) expect_in_person_step_indicator_current_step(t('step_indicator.flows.idv.verify_info')) end end