From c91670c5cc8fea7c683e503265cb338dcae73be7 Mon Sep 17 00:00:00 2001 From: Jeremy Curcio Date: Tue, 19 Mar 2024 14:46:57 -0400 Subject: [PATCH 1/6] Add Pending GPO to report --- lib/reporting/drop_off_report.rb | 43 ++++++++++++-------------------- 1 file changed, 16 insertions(+), 27 deletions(-) diff --git a/lib/reporting/drop_off_report.rb b/lib/reporting/drop_off_report.rb index 05b5b34768b..5792ad67385 100644 --- a/lib/reporting/drop_off_report.rb +++ b/lib/reporting/drop_off_report.rb @@ -44,6 +44,7 @@ module Events IDV_DOC_AUTH_PHONE_VISITED = 'IdV: phone of record visited' IDV_ENTER_PASSWORD_VISITED = 'idv_enter_password_visited' OLD_IDV_ENTER_PASSWORD_VISITED = 'IdV: review info visited' + IDV_PENDING_GPO = 'IdV: USPS address letter enqueued' IDV_ENTER_PASSWORD_SUBMITTED = 'idv_enter_password_submitted' OLD_IDV_ENTER_PASSWORD_SUBMITTED = 'IdV: review complete' IDV_PERSONAL_KEY_SUBMITTED = 'IdV: personal key submitted' @@ -215,47 +216,31 @@ def dropoff_metrics_table ), ], [ - 'Verified (event)', - idv_personal_key_submitted, + 'Workflow Completed - Total Pending (event)', + idv_pending_gpo, dropoff = idv_enter_password_submitted - - idv_personal_key_submitted, + idv_pending_gpo, percent( numerator: dropoff, denominator: idv_enter_password_submitted, ), percent( - numerator: idv_personal_key_submitted, + numerator: idv_pending_gpo, denominator: idv_started, ), ], [ - 'Blanket proofing rate', - '', - '', - '', - percent( - numerator: idv_personal_key_submitted, - denominator: idv_doc_auth_welcome_submitted, - ), - ], - [ - 'Actual proofing rate', - '', - '', - '', + 'Verified (event)', + idv_personal_key_submitted, + dropoff = idv_enter_password_submitted - + idv_personal_key_submitted, percent( - numerator: idv_enter_password_visited, - denominator: idv_doc_auth_image_vendor_submitted, + numerator: dropoff, + denominator: idv_enter_password_submitted, ), - ], - [ - 'Verified proofing rate', - '', - '', - '', percent( numerator: idv_personal_key_submitted, - denominator: idv_doc_auth_image_vendor_submitted, + denominator: idv_started, ), ], ] @@ -383,6 +368,10 @@ def idv_personal_key_submitted data[Events::IDV_PERSONAL_KEY_SUBMITTED].count end + def idv_pending_gpo + data[Events::IDV_PERSONAL_KEY_SUBMITTED].count + end + def as_tables [ proofing_definition_table, From 38316648b338ec9d43a5c66cbd7f11a9d9b66a3d Mon Sep 17 00:00:00 2001 From: Jeremy Curcio Date: Fri, 22 Mar 2024 12:28:13 -0400 Subject: [PATCH 2/6] rename the letter event --- lib/reporting/drop_off_report.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/reporting/drop_off_report.rb b/lib/reporting/drop_off_report.rb index 5792ad67385..85900534f8d 100644 --- a/lib/reporting/drop_off_report.rb +++ b/lib/reporting/drop_off_report.rb @@ -216,7 +216,7 @@ def dropoff_metrics_table ), ], [ - 'Workflow Completed - Total Pending (event)', + 'USPS letter enqueued (event)', idv_pending_gpo, dropoff = idv_enter_password_submitted - idv_pending_gpo, From 70f5f0b3973f4f416ed15d9e594c8cb1114bcdcc Mon Sep 17 00:00:00 2001 From: Jeremy Curcio Date: Fri, 22 Mar 2024 12:35:11 -0400 Subject: [PATCH 3/6] Use the correct event --- lib/reporting/drop_off_report.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/reporting/drop_off_report.rb b/lib/reporting/drop_off_report.rb index 85900534f8d..c2240fed43e 100644 --- a/lib/reporting/drop_off_report.rb +++ b/lib/reporting/drop_off_report.rb @@ -369,7 +369,7 @@ def idv_personal_key_submitted end def idv_pending_gpo - data[Events::IDV_PERSONAL_KEY_SUBMITTED].count + data[Events::IDV_PENDING_GPO].count end def as_tables From 0613b4dca32237c397bff5ab95563c35c4230c8e Mon Sep 17 00:00:00 2001 From: Jeremy Curcio Date: Fri, 22 Mar 2024 12:59:34 -0400 Subject: [PATCH 4/6] Add USPS event to spec changelog: Internal, Data Reporting, Adds the IdV: USPS address letter enqueued event to the drop-off report --- spec/lib/reporting/drop_off_report_spec.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/lib/reporting/drop_off_report_spec.rb b/spec/lib/reporting/drop_off_report_spec.rb index a47087ffe08..139a20bd754 100644 --- a/spec/lib/reporting/drop_off_report_spec.rb +++ b/spec/lib/reporting/drop_off_report_spec.rb @@ -155,6 +155,7 @@ def expected_tables(strings: false) ['Phone finder (page view)'] + string_or_num(strings, 2, 0, 0.0, 0.4), ['Encrypt account: enter password (page view)'] + string_or_num(strings, 1, 1, 0.5, 0.2), ['Personal key input (page view)'] + string_or_num(strings, 1, 0, 0.0, 0.2), + ['USPS letter enqueued (event)'] + string_or_num(strings, 0, 1, 1.0, 0.0), ['Verified (event)'] + string_or_num(strings, 1, 0, 0.0, 0.2), ['Blanket proofing rate', '', '', ''] + string_or_num(strings, 0.2), ['Actual proofing rate', '', '', ''] + string_or_num(strings, 0.25), From 152685b8bc90e9874a1b1fc8fd6029a3061bd729 Mon Sep 17 00:00:00 2001 From: Jeremy Curcio Date: Fri, 22 Mar 2024 13:46:54 -0400 Subject: [PATCH 5/6] Not sure why I removed these --- lib/reporting/drop_off_report.rb | 30 ++++++++++++++++++++++++++++++ 1 file changed, 30 insertions(+) diff --git a/lib/reporting/drop_off_report.rb b/lib/reporting/drop_off_report.rb index c2240fed43e..3b6640a3dc4 100644 --- a/lib/reporting/drop_off_report.rb +++ b/lib/reporting/drop_off_report.rb @@ -243,6 +243,36 @@ def dropoff_metrics_table denominator: idv_started, ), ], + [ + 'Blanket proofing rate', + '', + '', + '', + percent( + numerator: idv_personal_key_submitted, + denominator: idv_doc_auth_welcome_submitted, + ), + ], + [ + 'Actual proofing rate', + '', + '', + '', + percent( + numerator: idv_enter_password_visited, + denominator: idv_doc_auth_image_vendor_submitted, + ), + ], + [ + 'Verified proofing rate', + '', + '', + '', + percent( + numerator: idv_personal_key_submitted, + denominator: idv_doc_auth_image_vendor_submitted, + ), + ], ] end From 78d975edf26109a70e77a2799cbf2b180c4aa546 Mon Sep 17 00:00:00 2001 From: Jeremy Curcio Date: Fri, 22 Mar 2024 14:23:48 -0400 Subject: [PATCH 6/6] Remove legacy percentages again --- lib/reporting/drop_off_report.rb | 30 ---------------------- spec/lib/reporting/drop_off_report_spec.rb | 3 --- 2 files changed, 33 deletions(-) diff --git a/lib/reporting/drop_off_report.rb b/lib/reporting/drop_off_report.rb index 3b6640a3dc4..c2240fed43e 100644 --- a/lib/reporting/drop_off_report.rb +++ b/lib/reporting/drop_off_report.rb @@ -243,36 +243,6 @@ def dropoff_metrics_table denominator: idv_started, ), ], - [ - 'Blanket proofing rate', - '', - '', - '', - percent( - numerator: idv_personal_key_submitted, - denominator: idv_doc_auth_welcome_submitted, - ), - ], - [ - 'Actual proofing rate', - '', - '', - '', - percent( - numerator: idv_enter_password_visited, - denominator: idv_doc_auth_image_vendor_submitted, - ), - ], - [ - 'Verified proofing rate', - '', - '', - '', - percent( - numerator: idv_personal_key_submitted, - denominator: idv_doc_auth_image_vendor_submitted, - ), - ], ] end diff --git a/spec/lib/reporting/drop_off_report_spec.rb b/spec/lib/reporting/drop_off_report_spec.rb index 139a20bd754..507eb1fbe9b 100644 --- a/spec/lib/reporting/drop_off_report_spec.rb +++ b/spec/lib/reporting/drop_off_report_spec.rb @@ -157,9 +157,6 @@ def expected_tables(strings: false) ['Personal key input (page view)'] + string_or_num(strings, 1, 0, 0.0, 0.2), ['USPS letter enqueued (event)'] + string_or_num(strings, 0, 1, 1.0, 0.0), ['Verified (event)'] + string_or_num(strings, 1, 0, 0.0, 0.2), - ['Blanket proofing rate', '', '', ''] + string_or_num(strings, 0.2), - ['Actual proofing rate', '', '', ''] + string_or_num(strings, 0.25), - ['Verified proofing rate', '', '', ''] + string_or_num(strings, 0.25), ], ] end