From be83824543a0bed0a0e0ba814aa5d95854b1bfc5 Mon Sep 17 00:00:00 2001 From: charleyf Date: Wed, 13 Mar 2024 12:23:48 -0400 Subject: [PATCH 1/7] Add missing analytics event --- app/controllers/frontend_log_controller.rb | 4 ++- app/services/analytics_events.rb | 32 ++++++++++++++++++++++ 2 files changed, 35 insertions(+), 1 deletion(-) diff --git a/app/controllers/frontend_log_controller.rb b/app/controllers/frontend_log_controller.rb index 04c903ff7c6..fb0341483c1 100644 --- a/app/controllers/frontend_log_controller.rb +++ b/app/controllers/frontend_log_controller.rb @@ -23,6 +23,8 @@ class FrontendLogController < ApplicationController 'IdV: exit optional questions' => :idv_exit_optional_questions, 'IdV: front image added' => :idv_front_image_added, 'IdV: front image clicked' => :idv_front_image_clicked, + 'IdV: selfie image added' => :idv_selfie_image_added, + 'IdV: selfie image clicked' => :idv_selfie_image_clicked, 'IdV: Image capture failed' => :idv_image_capture_failed, 'IdV: Link sent capture doc polling complete' => :idv_link_sent_capture_doc_polling_complete, 'IdV: Link sent capture doc polling started' => :idv_link_sent_capture_doc_polling_started, @@ -60,7 +62,7 @@ def create if success render json: { success: }, status: :ok else - render json: { success:, error_message: 'invalid event' }, status: :bad_request + render json: { success:, error_message: "invalid event, #{log_params[:event]} #{log_params[:payload]}" }, status: :bad_request end end diff --git a/app/services/analytics_events.rb b/app/services/analytics_events.rb index df5c5d39819..f0c64808410 100644 --- a/app/services/analytics_events.rb +++ b/app/services/analytics_events.rb @@ -2952,6 +2952,38 @@ def idv_selfie_image_added( end # rubocop:enable Naming/VariableName,Naming/MethodParameterName + # rubocop:disable Naming/VariableName,Naming/MethodParameterName, + # rubocop:disable IdentityIdp/AnalyticsEventNameLinter + # @param [Boolean] acuant_sdk_upgrade_a_b_testing_enabled + # @param [String] acuant_version + # @param [String] flow_path whether the user is in the hybrid or standard flow + # @param [Boolean] isDrop + # @param [String] source + # @param [String] use_alternate_sdk + # @param [Boolean] liveness_checking_required + def idv_selfie_image_clicked( + acuant_sdk_upgrade_a_b_testing_enabled:, + acuant_version:, + flow_path:, + isDrop:, + source:, + use_alternate_sdk:, + liveness_checking_required: nil, + **_extra + ) + track_event( + 'Frontend: IdV: selfie image clicked', + acuant_sdk_upgrade_a_b_testing_enabled: acuant_sdk_upgrade_a_b_testing_enabled, + acuant_version: acuant_version, + flow_path: flow_path, + isDrop: isDrop, + source: source, + use_alternate_sdk: use_alternate_sdk, + liveness_checking_required: liveness_checking_required, + ) + end + # rubocop:enable Naming/VariableName,Naming/MethodParameterName,IdentityIdp/AnalyticsEventNameLinter + # Tracks when the user visits one of the the session error pages. # @param [String] type # @param [Integer,nil] submit_attempts_remaining (previously called "attempts_remaining") From 17ceeeb7221c14a088fce6782ed811c3bb826742 Mon Sep 17 00:00:00 2001 From: charleyf Date: Wed, 13 Mar 2024 12:26:51 -0400 Subject: [PATCH 2/7] Revert change used for diagnosing --- app/controllers/frontend_log_controller.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/controllers/frontend_log_controller.rb b/app/controllers/frontend_log_controller.rb index fb0341483c1..737362e42d8 100644 --- a/app/controllers/frontend_log_controller.rb +++ b/app/controllers/frontend_log_controller.rb @@ -62,7 +62,7 @@ def create if success render json: { success: }, status: :ok else - render json: { success:, error_message: "invalid event, #{log_params[:event]} #{log_params[:payload]}" }, status: :bad_request + render json: { success:, error_message: 'invalid event' }, status: :bad_request end end From b96b033bd46bce771f69b525529cb906b1f2a51a Mon Sep 17 00:00:00 2001 From: charleyf Date: Wed, 13 Mar 2024 15:48:58 -0400 Subject: [PATCH 3/7] changelog: Bug Fixes, fix selfie logging From 3e0cf823452a9a0d101bd8269d031dc0a493e76a Mon Sep 17 00:00:00 2001 From: charleyf Date: Wed, 13 Mar 2024 15:49:22 -0400 Subject: [PATCH 4/7] Fix order --- app/controllers/frontend_log_controller.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/frontend_log_controller.rb b/app/controllers/frontend_log_controller.rb index 737362e42d8..1ca533ad16e 100644 --- a/app/controllers/frontend_log_controller.rb +++ b/app/controllers/frontend_log_controller.rb @@ -23,8 +23,6 @@ class FrontendLogController < ApplicationController 'IdV: exit optional questions' => :idv_exit_optional_questions, 'IdV: front image added' => :idv_front_image_added, 'IdV: front image clicked' => :idv_front_image_clicked, - 'IdV: selfie image added' => :idv_selfie_image_added, - 'IdV: selfie image clicked' => :idv_selfie_image_clicked, 'IdV: Image capture failed' => :idv_image_capture_failed, 'IdV: Link sent capture doc polling complete' => :idv_link_sent_capture_doc_polling_complete, 'IdV: Link sent capture doc polling started' => :idv_link_sent_capture_doc_polling_started, @@ -35,6 +33,8 @@ class FrontendLogController < ApplicationController 'IdV: personal key acknowledgment toggled' => :idv_personal_key_acknowledgment_toggled, 'IdV: prepare submitted' => :idv_in_person_prepare_submitted, 'IdV: prepare visited' => :idv_in_person_prepare_visited, + 'IdV: selfie image added' => :idv_selfie_image_added, + 'IdV: selfie image clicked' => :idv_selfie_image_clicked, 'IdV: switch_back submitted' => :idv_in_person_switch_back_submitted, 'IdV: switch_back visited' => :idv_in_person_switch_back_visited, 'IdV: user clicked sp link on ready to verify page' => :idv_in_person_ready_to_verify_sp_link_clicked, From 255a29671603728638be6390a6f39176680098c9 Mon Sep 17 00:00:00 2001 From: charleyf Date: Thu, 14 Mar 2024 11:37:13 -0400 Subject: [PATCH 5/7] Rename event to match our new naming convention --- app/services/analytics_events.rb | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/app/services/analytics_events.rb b/app/services/analytics_events.rb index f0c64808410..08597c09462 100644 --- a/app/services/analytics_events.rb +++ b/app/services/analytics_events.rb @@ -2953,7 +2953,6 @@ def idv_selfie_image_added( # rubocop:enable Naming/VariableName,Naming/MethodParameterName # rubocop:disable Naming/VariableName,Naming/MethodParameterName, - # rubocop:disable IdentityIdp/AnalyticsEventNameLinter # @param [Boolean] acuant_sdk_upgrade_a_b_testing_enabled # @param [String] acuant_version # @param [String] flow_path whether the user is in the hybrid or standard flow @@ -2972,7 +2971,7 @@ def idv_selfie_image_clicked( **_extra ) track_event( - 'Frontend: IdV: selfie image clicked', + :idv_selfie_image_clicked, acuant_sdk_upgrade_a_b_testing_enabled: acuant_sdk_upgrade_a_b_testing_enabled, acuant_version: acuant_version, flow_path: flow_path, @@ -2982,7 +2981,7 @@ def idv_selfie_image_clicked( liveness_checking_required: liveness_checking_required, ) end - # rubocop:enable Naming/VariableName,Naming/MethodParameterName,IdentityIdp/AnalyticsEventNameLinter + # rubocop:enable Naming/VariableName,Naming/MethodParameterName # Tracks when the user visits one of the the session error pages. # @param [String] type From d0193a90906d66c61cfeb7022cc2afc4e8630eaa Mon Sep 17 00:00:00 2001 From: charleyf Date: Thu, 14 Mar 2024 11:40:32 -0400 Subject: [PATCH 6/7] Remove unnessecary 'added' event --- app/controllers/frontend_log_controller.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/app/controllers/frontend_log_controller.rb b/app/controllers/frontend_log_controller.rb index 1ca533ad16e..37ee24f6f98 100644 --- a/app/controllers/frontend_log_controller.rb +++ b/app/controllers/frontend_log_controller.rb @@ -33,7 +33,6 @@ class FrontendLogController < ApplicationController 'IdV: personal key acknowledgment toggled' => :idv_personal_key_acknowledgment_toggled, 'IdV: prepare submitted' => :idv_in_person_prepare_submitted, 'IdV: prepare visited' => :idv_in_person_prepare_visited, - 'IdV: selfie image added' => :idv_selfie_image_added, 'IdV: selfie image clicked' => :idv_selfie_image_clicked, 'IdV: switch_back submitted' => :idv_in_person_switch_back_submitted, 'IdV: switch_back visited' => :idv_in_person_switch_back_visited, From 1060dd3fe9da50d04810fce396b7ee8ffb6226b3 Mon Sep 17 00:00:00 2001 From: charleyf Date: Thu, 14 Mar 2024 11:41:42 -0400 Subject: [PATCH 7/7] changelog: Bug Fixes, In Person Proofing, Add a missing log method to analytics