From 803a8df968110002360d6e287484eddd6ed15c62 Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Mon, 22 Mar 2021 11:27:18 -0400 Subject: [PATCH 1/3] Buttons: Use "inherit" for font smoothing reset See: https://github.com/uswds/uswds/pull/4115 --- CHANGELOG.md | 6 ++++++ src/scss/components/_buttons.scss | 3 ++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ea1a1de7..6ebbcc9f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,9 @@ +## 5.0.2 + +### Bug Fixes + +- Fix an issue where unstyled buttons may appear heavier than an equivalent link. + ## 5.0.1 ### Bug Fixes diff --git a/src/scss/components/_buttons.scss b/src/scss/components/_buttons.scss index 8ad06317..94df40cb 100644 --- a/src/scss/components/_buttons.scss +++ b/src/scss/components/_buttons.scss @@ -31,7 +31,8 @@ &.usa-button--active, &:disabled, &.usa-button--disabled { - @include no-knockout-font-smoothing; + -moz-osx-font-smoothing: inherit; + -webkit-font-smoothing: inherit; background-color: transparent; box-shadow: none; text-decoration: underline; From 7e89687462a6dc344b4948c04f8c3e2e903ba842 Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Mon, 22 Mar 2021 11:29:58 -0400 Subject: [PATCH 2/3] Buttons: Remove underline offset from unstyled buttons **Why**: So that unstyled buttons appear visually identical to links --- CHANGELOG.md | 2 +- src/scss/components/_buttons.scss | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 6ebbcc9f..03c7093a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ### Bug Fixes -- Fix an issue where unstyled buttons may appear heavier than an equivalent link. +- Fix the appearance of unstyled buttons to appear visually identical to a link. ## 5.0.1 diff --git a/src/scss/components/_buttons.scss b/src/scss/components/_buttons.scss index 94df40cb..0f0d4e4e 100644 --- a/src/scss/components/_buttons.scss +++ b/src/scss/components/_buttons.scss @@ -19,7 +19,6 @@ // Since we override base button styles, we must re-apply the unstyled button styles. @include button-unstyled; position: relative; - text-underline-offset: 3px; // USWDS currently only sets hover and active unstyled button styles for the browser-native // states, and not with the modifier classes. It also does not apply these styles to the disabled From b4f5f1f9e2a0041a399262d1d641df16c3cd258b Mon Sep 17 00:00:00 2001 From: Andrew Duthie Date: Mon, 22 Mar 2021 16:37:32 -0400 Subject: [PATCH 3/3] 5.0.2 --- package-lock.json | 2 +- package.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/package-lock.json b/package-lock.json index b3f12854..3958dfff 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "identity-style-guide", - "version": "5.0.1", + "version": "5.0.2", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/package.json b/package.json index 04f56d8d..05eea4c2 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "identity-style-guide", - "version": "5.0.1", + "version": "5.0.2", "description": "The global style of login.gov", "main": "./build/cjs/index.js", "module": "./build/esm/index.js",