Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Sinkholes #20

Open
BrekiTomasson opened this issue Jun 16, 2020 · 1 comment
Open

Idea: Sinkholes #20

BrekiTomasson opened this issue Jun 16, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@BrekiTomasson
Copy link

First of all - love the mod! This kind of thing was always on my wishlist when playing Minecraft, the ability for landscapes to change over time based on things like water and wind erosion. Wind is obviously still on my wishlist ;)

Now, as for my idea: A lot of times, I see small lakes burrowing underground and creating a larger, subterranean, lake. Often, there's only a single grass_block above it, leading to what I feel like a fairly large, unsupported piece of land. My suggestion would be for this mod to periodically do checks that include checking whatever is above the water it is affecting, breaking "floating" flowers and grass and having a chance to degrade "floating" grass_block, dirt, or podzol above it.

Basically; if it looks 1 block up from the water block and finds one of those three types blocks, and then 1 up from that and it finds air, then it should be able to degrade that block. By the time that block becomes sand or gravel, gravity should do the rest.

@13rac1
Copy link
Owner

13rac1 commented Jun 24, 2020

Thanks! ❤️

I've actually already implemented sinkholes in an unreleased branch: Water blocks looking downwards for something erodable, then air. Eroding starts if air is found, but the search stops if rock is found. The only problem is I need to deal with underwater plants. May have to start checking all waterlogged objects? Not sure how to handle it correctly yet. 🤔 Some screenshots

Version 1.1.1/1.1.2 - No Sinkholes
2020-04-13_22 52 47-sinkhole-before

Feature branch with Sinkholes
2020-04-13_22 53 17-sinkhole-after

@13rac1 13rac1 added the enhancement New feature or request label Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants