Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to kill the process during build #3517

Open
groenroos opened this issue Oct 29, 2024 · 2 comments
Open

Not able to kill the process during build #3517

groenroos opened this issue Oct 29, 2024 · 2 comments

Comments

@groenroos
Copy link

Operating system

macOS Sonoma 14.4.1

Eleventy

3.0.0

Describe the bug

While Eleventy is building the site, it's not possible to kill the process with Ctrl-C. Only after the build is complete, will the Ctrl-C take effect and Eleventy exits with code 1.

With a large site where build times are in the tens of seconds, this can get frustrating, especially when you already know the build will fail (e.g. because of missing npm dependencies when switching git branches).

Reproduction steps

  1. Start a build of a large site
  2. Wait until the templates start processing (i.e. after any async data has been fetched)
  3. Try to kill the process with Ctrl-C
  4. The process will not die until after the build is complete

Expected behavior

The build should be interrupted and the process should exit instantly.

Reproduction URL

No response

Screenshots

No response

@nhoizey
Copy link
Contributor

nhoizey commented Oct 29, 2024

This is indeed a new behavior I've noticed with Eleventy 3.

Ctrl + C doesn't kill the shell execution, I have to use ps to get the process id then kill it.

@nhoizey
Copy link
Contributor

nhoizey commented Oct 29, 2024

There are similar issues open in npm's repository.

For example:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants