-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Peer dependency error with plugin #5
Comments
The relevants bits from the plugin are the peer dependency in the "peerDependencies": {
"@11ty/eleventy": ">=0.10.0-beta.1"
}, I need to drill into why Worth noting this is probably only due to the major version bump / canary, not the actual dev server implementation as it errors on package install |
There's a super helpful semver calculator, but pre-releases seem brittle. I want to support everything past
And it still hits some edge cases Since there are so many pre-releases and none of them really need to break, I might just remove the peer dependency check altogether? |
Hey y’all—I’ve solved this in Eleventy core. Check out this pattern to use instead of
The Read more at 11ty/eleventy#2001 |
Going to close this one—sorry! Per my comment above, I’d recommend using the pattern above to warn about dependency mismatches in Eleventy. You may want to open another issue over at I created 11ty/eleventy#2269 to add some additional official docs for plugin authoring best practices |
Did, indeed. TY as always, sir. |
Mentioning to you (and will do so in the affected plugin, too) only because it may be that other plugins will be similarly affected, but 2.0.0-canary.1 crashed on launch with the following (cc @KyleMit):
The text was updated successfully, but these errors were encountered: