Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets svn propset commands fail #98

Closed
lucyllewy opened this issue Jun 28, 2022 · 0 comments · Fixed by #99
Closed

Assets svn propset commands fail #98

lucyllewy opened this issue Jun 28, 2022 · 0 comments · Fixed by #99
Assignees
Milestone

Comments

@lucyllewy
Copy link
Contributor

Describe the bug

The glob of *.png, *.jpg, *.gif, and *.svg in the svn propset svn:mime-type commands fail due to being quoted. SVN does not support expanding the globs itself, so we need to rely on the shell expanding them. Shell globs are only expanded when the * is unquoted, but currently the whole path including the glob is within quotes meaning that we're trying to pass the literal string *.png etc with the * unexpanded.

Steps to Reproduce

  1. Ensure you have image assets in .wordpress.org directory in your plugin repo
  2. Run the action
  3. Check the logs
  4. Scroll down to '➤ Copying tag...'
  5. See error:
➤ Copying tag...
A         tags/4.3.0
'assets/*.png' is not under version control
svn: E155010: The node '/home/runner/svn-a-z-listing/assets/*.png' was not found.
'assets/*.jpg' is not under version control
svn: E155010: The node '/home/runner/svn-a-z-listing/assets/*.jpg' was not found.
'assets/*.svg' is not under version control
svn: E155010: The node '/home/runner/svn-a-z-listing/assets/*.svg' was not found.

Expected behavior

svn propset commands succeed

@jeffpaul jeffpaul added this to the 2.2.0 milestone Jun 28, 2022
@jeffpaul jeffpaul moved this to Incoming in Open Source Practice Jun 28, 2022
@jeffpaul jeffpaul moved this from Incoming to In Review in Open Source Practice Jun 28, 2022
Repository owner moved this from In Review to Merged in Open Source Practice Jul 5, 2022
@dinhtungdu dinhtungdu modified the milestones: 2.2.0, 2.1.1 Aug 11, 2022
@vikrampm1 vikrampm1 moved this from Merged to Done/Released in Open Source Practice Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants