ethmonitor: review behaviour if Options.LogTopics is defined

[attente]

ethkit/ethmonitor/ethmonitor.go

Lines 324 to 347 in 7d9af4e

	topics := [][]common.Hash{}
	if len(m.options.LogTopics) > 0 {
	topics = append(topics, m.options.LogTopics)
	}
	logs, err := m.provider.FilterLogs(tctx, ethereum.FilterQuery{
	BlockHash: &blockHash,
	Topics: topics,
	})
	if err == nil {
	// check the logsBloom from the block to check if we should be expecting logs. logsBloom
	// will be included for any indexed logs.
	if len(logs) > 0 || block.Bloom() == (types.Bloom{}) {
	// successful backfill
	if logs == nil {
	block.Logs = []types.Log{}
	} else {
	block.Logs = logs
	}
	block.OK = true
	continue
	}
	}

I haven't tried this, but I think if topics are specified, then it's possible to receive no logs, while the logs bloom filter is non-zero. This means the block is never considered backfilled and causes the monitor to hang if logs are requested.

[0xbsa]

I'm facing this exact issue. My topics slice is non-empty and the monitor hangs after encountering a block without any matching logs (as per topics filter)

[0xbsa]

Why is this check required at all?

ethkit/ethmonitor/ethmonitor.go

Line 337 in 7d9af4e

if len(logs) > 0 || block.Bloom() == (types.Bloom{}) {

[pkieltyka]

outdated