Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch building should use arcs #531

Closed
Tracked by #514
Mirko-von-Leipzig opened this issue Oct 28, 2024 · 3 comments
Closed
Tracked by #514

Batch building should use arcs #531

Mirko-von-Leipzig opened this issue Oct 28, 2024 · 3 comments
Assignees
@Mirko-von-Leipzig
Milestone
v0.7

Comments

@Mirko-von-Leipzig
Copy link
Contributor

The batch builder in the block-producer rework should take in Arc<ProvenTransaction> to prevent cloning them.

#530 (comment)
This was referenced Oct 28, 2024
Merged
Closed
@Mirko-von-Leipzig
Copy link
Contributor Author

I agree. I don't think there is a good reason why TransactionBatch::new() cannot take something like IntoIterator<Item = AsRef<ProvenTransaction> as input.

Originally posted by @bobbinth in #541 (comment)

@Mirko-von-Leipzig Mirko-von-Leipzig mentioned this issue Nov 5, 2024
Merged
@Mirko-von-Leipzig Mirko-von-Leipzig self-assigned this Nov 5, 2024
@Mirko-von-Leipzig Mirko-von-Leipzig mentioned this issue Nov 5, 2024
Merged
@Mirko-von-Leipzig
Copy link
Contributor Author

It appears I managed to rebase out these changes somehow. Will need to re-do #544 once #562 lands on next.

@bobbinth bobbinth added this to the v0.7 milestone Dec 6, 2024
@Mirko-von-Leipzig Mirko-von-Leipzig mentioned this issue Dec 9, 2024
Merged
@Mirko-von-Leipzig
Copy link
Contributor Author

Closed by #570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mirko-von-Leipzig Mirko-von-Leipzig

Labels
None yet
Projects
User's testnet
Status: Done
Milestone
v0.7
Development

No branches or pull requests
2 participants
@bobbinth @Mirko-von-Leipzig