Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicates of sample config files for the node #318

Closed
bobbinth opened this issue Apr 12, 2024 · 1 comment
Closed

Remove duplicates of sample config files for the node #318

bobbinth opened this issue Apr 12, 2024 · 1 comment
Assignees
Labels
node Related to the node component
Milestone

Comments

@bobbinth
Copy link
Contributor

After merging #312, we will have sample config files (miden-node.toml and genesis.toml) stored in 2 different places (i.e., in node and in packaging directories). This is not a big deal, but I think ideally we should have a "single source of truth" for these. Assuming we want to do this, we have the following options:

  1. Keep the only copies in the node directory. I think we'll need to update the packaging task to work with this.
  2. Keep the only copies in the packaging directory. We may need to update our docker build scripts for this (and maybe something else?).
  3. Put these files into some dedicated directory (e.g., config). We'll need to update both the Debian package task and docker build script.

I'm not sure what's the best approach here is - maybe option 3?

@bobbinth
Copy link
Contributor Author

Closed by #353.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
node Related to the node component
Projects
Status: Done
Development

No branches or pull requests

2 participants