Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Refactor note-related messages to include a NoteMetadata #315

Closed
3 of 5 tasks
igamigo opened this issue Apr 11, 2024 · 1 comment
Closed
3 of 5 tasks

[Task]: Refactor note-related messages to include a NoteMetadata #315

igamigo opened this issue Apr 11, 2024 · 1 comment
Assignees
Milestone

Comments

@igamigo
Copy link
Collaborator

igamigo commented Apr 11, 2024

Node's components affected by this task

  • RPC
  • Block producer
  • Store
  • Protobuf messages
  • Testing

What should be done?

Currently note-related messages in protobuf contain the same fields. These should be refactored out into its own NoteMetadata object

How should it be done?

https://github.com/0xPolygonMiden/miden-node/blob/25529ac9bc629e4ac1f0d2c8bc9739b0d1bc2866/proto/proto/note.proto

Change messages to include a new NoteMetadata field that looks something like this:

message NoteMetadata {
    account.AccountId sender  = 1;
    uint32 note_type = 2;
    fixed32 tag = 3;
    fixed64 aux = 4; // unsure if we want/need this for a first iteration
}

and replaces the pertinent fields.

When is this task done?

When note messages contain NoteMetadata as a specific field.

Additional context

No response

@bobbinth
Copy link
Contributor

bobbinth commented May 3, 2024

Closed by #338.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants