Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Address note_type enum codegen issues #314

Closed
2 of 5 tasks
igamigo opened this issue Apr 10, 2024 · 1 comment
Closed
2 of 5 tasks

[Task]: Address note_type enum codegen issues #314

igamigo opened this issue Apr 10, 2024 · 1 comment
Assignees
Milestone

Comments

@igamigo
Copy link
Collaborator

igamigo commented Apr 10, 2024

Node's components affected by this task

  • RPC
  • Block producer
  • Store
  • Protobuf messages
  • Testing

What should be done?

On #311 we added note_type to NoteSyncRecord. Ideally this would be an enum in the protobuf messages, but when using something like this:

enum NoteType {
  PUBLIC = 0;
  OFF_CHAIN = 1;
  ENCRYPTED = 2;
}

The codegen creates conflicting definitions of some types due to deriving some attributes twice. See this for more information.

How should it be done?

Fix the codegen when using enums

When is this task done?

When on a clean build the types are generated correctly and the protobuf definition files contain the enums.

Additional context

The linked PR contains mor econtext.

@bobbinth
Copy link
Contributor

bobbinth commented May 3, 2024

As a part of #338, we invested this but decided to keep note_type as an int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants