We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
note_type
On #311 we added note_type to NoteSyncRecord. Ideally this would be an enum in the protobuf messages, but when using something like this:
NoteSyncRecord
enum NoteType { PUBLIC = 0; OFF_CHAIN = 1; ENCRYPTED = 2; }
The codegen creates conflicting definitions of some types due to deriving some attributes twice. See this for more information.
Fix the codegen when using enums
When on a clean build the types are generated correctly and the protobuf definition files contain the enums.
The linked PR contains mor econtext.
The text was updated successfully, but these errors were encountered:
NoteMetadata
NoteType
As a part of #338, we invested this but decided to keep note_type as an int.
Sorry, something went wrong.
igamigo
No branches or pull requests
Node's components affected by this task
What should be done?
On #311 we added
note_type
toNoteSyncRecord
. Ideally this would be an enum in the protobuf messages, but when using something like this:The codegen creates conflicting definitions of some types due to deriving some attributes twice. See this for more information.
How should it be done?
Fix the codegen when using enums
When is this task done?
When on a clean build the types are generated correctly and the protobuf definition files contain the enums.
Additional context
The linked PR contains mor econtext.
The text was updated successfully, but these errors were encountered: