Added transaction IDs into the Block struct
#734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # objects/src/block/header.rs
bobbinth
reviewed
Jun 6, 2024
objects/src/testing/block.rs
Outdated
Comment on lines
470
to
471
| // TODO: Set tx_hash and proof_hash to the correct values once the kernel is available. | ||
| let tx_hash = Digest::default(); |
There was a problem hiding this comment.
not sure if this comment is still relevant for tx_hash as it no longer has anything to do with the kernel.
It may be tricky to set the tx_hash here correctly as we don't explicitly say which transactions where executed to get this state transition - but the comment should be different.
Also, cc @igamigo as this is probably relevant to the mock object refactoring you are working on.
bobbinth
reviewed
Jun 6, 2024
mFragaBA
reviewed
Jun 7, 2024
| @@ -163,7 +163,7 @@ fn block_data_memory_assertions(process: &Process<MockHost>, inputs: &PreparedTr | |||
|
|
|||
| assert_eq!( | |||
| read_root_mem_value(process, BATCH_ROOT_PTR), | |||
| inputs.block_header().batch_root().as_elements(), | |||
| inputs.block_header().tx_hash().as_elements(), | |||
| "The batch root should be stored at the BATCH_ROOT_PTR" | |||
There was a problem hiding this comment.
should BATCH_ROOT_PTR and the error message refer to the transaction hash?
There was a problem hiding this comment.
Good catch! @polydez - could you make a small PR to fix this (and check if we have any other similar references)?
Dominik1999
pushed a commit
that referenced
this pull request
Jun 12, 2024
bobbinth
pushed a commit
that referenced
this pull request
Jul 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #722