Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dedicated *_foreign procedures #922

Closed
Fumuran opened this issue Oct 15, 2024 · 1 comment · Fixed by #942
Closed

Remove dedicated *_foreign procedures #922

Fumuran opened this issue Oct 15, 2024 · 1 comment · Fixed by #942
Assignees
Labels
kernels Related to transaction, batch, or block kernels refactoring Code clean-ups, improvements, and refactoring
Milestone

Comments

@Fumuran
Copy link
Contributor

Fumuran commented Oct 15, 2024

What should be done?

As soon as the refactoring of the DYN operation and fix of the bug in the CALLER instruction will be done, we will be able to rework the way the foreign procedures are called during the execution of the execute_foreign_procedure. Namely, get_item_foreign, get_map_item_foreign and authenticate_account_origin_foreign procedures become unnecessary: we will be able to use the basic versions of these procedures.

How should it be done?

get_item_foreign and get_map_item_foreign procedures should be removed from the api.masm, FPI tests in the test_tx.rs should call get_item and get_map_item instead. authenticate_account_origin_foreign procedure should be removed from the api.masm, since it was used only in the "foreign" versions of the get_item and get_map_item procedures.

When is this task done?

This task is done when we will be able to achieve the same functionality of the foreign procedure invocation using only "non-foreign" procedures.

Additional context

No response

@Fumuran Fumuran added kernels Related to transaction, batch, or block kernels refactoring Code clean-ups, improvements, and refactoring labels Oct 15, 2024
@Fumuran Fumuran self-assigned this Oct 15, 2024
@bobbinth bobbinth added this to the v0.6 milestone Oct 15, 2024
@Dominik1999 Dominik1999 moved this to In Progress in User's testnet Oct 21, 2024
@Fumuran Fumuran linked a pull request Oct 30, 2024 that will close this issue
@bobbinth
Copy link
Contributor

bobbinth commented Nov 4, 2024

Closed by #942.

@bobbinth bobbinth closed this as completed Nov 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in User's testnet Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kernels Related to transaction, batch, or block kernels refactoring Code clean-ups, improvements, and refactoring
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants